From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9CEDC433B4 for ; Tue, 18 May 2021 11:42:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD47561261 for ; Tue, 18 May 2021 11:42:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244747AbhERLnj (ORCPT ); Tue, 18 May 2021 07:43:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245026AbhERLnc (ORCPT ); Tue, 18 May 2021 07:43:32 -0400 Received: from mail-pj1-x102b.google.com (mail-pj1-x102b.google.com [IPv6:2607:f8b0:4864:20::102b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D228C061573 for ; Tue, 18 May 2021 04:42:14 -0700 (PDT) Received: by mail-pj1-x102b.google.com with SMTP id gm21so5350016pjb.5 for ; Tue, 18 May 2021 04:42:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7S6PUZObKkIfh3dODhQCy9E7mIQHbGFC9dWCAcju/jo=; b=SwBpWj+/Sbd3xmdoFsEWL4TtWjdKN15Sfgx7w030cR7SVp6Ye1cVLF/GgJrB8PdJ3t +bWWuSUBuB1S6wyeQTzPboeQVPgyIKTIfegE/8OIhCCSCynGDynUFDGzQz6mXE7+pvIW dM353u8JWAaT6zEiBJ+LSggu4nM//+AIqjqXyRGO6UDLpxPZlkun7Hpvdt41hBAmP/gj oVN/+/9BJWbZCzVcLMu7EFQ21iZ8eCc6cB2IWdLhb5dbMmgsFpTcJ9BJysNFQ/6IX3BC 0pQwP9p4EGhKsuCMF5q6BL4n6VkGpnyTbZPZ0sCvIo/HrvdSb4eM2LIgM1Cr5ViZj5rp hvLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7S6PUZObKkIfh3dODhQCy9E7mIQHbGFC9dWCAcju/jo=; b=MFZ+RFCIa2nz+CY8mwFCdFb+P/pdkPGi5xggNSKiaIH2MexX7ATdGGFSPii7eT82SK Z6VP/E0BEd+179lYHkMk/DuY0e89sVRko30Qp8DIvAK222G8P4eKiUpCnlzTuFBdghI7 F8cFJ0ktfJmoBfBroxtlx1KXJ8950vH2uoyBDl1QehkMrZCnlz6Winn1+6DeY025fLWM Cl1MKr2LTRnH6hjniwiVFxKqqPtRpZ/K1TptOnKAt6nazre9G1TNUSSOtWrAkiHhieyU OdkMM2f/zoeikZY/TZjTI6TlsVrWvKeQMOLFNTG/TCVVjxTf0jpVZTgljn1N61IufaK9 jh5Q== X-Gm-Message-State: AOAM532TnXBoVbeAXMN29/UjBzZnyBIQY5z/IYruNb2msA7EtLRfE44v gBOFaKo58c1T+eG6UyNFzlLzovdXtHy4eoMNbKAKbA== X-Google-Smtp-Source: ABdhPJxFfhcir7SromnhgqTH2KqWlndpO3tIOi4AVJmcHUKmPMiLDixKblE4Sk6MK9lPqY7c+ddadZP+ObGtVwvmRCk= X-Received: by 2002:a17:90a:e391:: with SMTP id b17mr282959pjz.75.1621338133894; Tue, 18 May 2021 04:42:13 -0700 (PDT) MIME-Version: 1.0 References: <20210513175258.5842-1-jonathan@marek.ca> <20210513175258.5842-4-jonathan@marek.ca> In-Reply-To: <20210513175258.5842-4-jonathan@marek.ca> From: Robert Foss Date: Tue, 18 May 2021 13:42:02 +0200 Message-ID: Subject: Re: [PATCH 3/3] clk: qcom: Add camera clock controller driver for SM8250 To: Jonathan Marek Cc: MSM , Andrey Konovalov , Andy Gross , Bjorn Andersson , Michael Turquette , Stephen Boyd , open list , "open list:COMMON CLK FRAMEWORK" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hey Jonathan, > +static int cam_cc_sm8250_probe(struct platform_device *pdev) > +{ > + struct regmap *regmap; > + > + regmap = qcom_cc_map(pdev, &cam_cc_sm8250_desc); > + if (IS_ERR(regmap)) > + return PTR_ERR(regmap); > + > + clk_lucid_pll_configure(&cam_cc_pll0, regmap, &cam_cc_pll0_config); > + clk_lucid_pll_configure(&cam_cc_pll1, regmap, &cam_cc_pll1_config); > + clk_lucid_pll_configure(&cam_cc_pll3, regmap, &cam_cc_pll3_config); > + clk_lucid_pll_configure(&cam_cc_pll4, regmap, &cam_cc_pll4_config); > + > + return qcom_cc_really_probe(pdev, &cam_cc_sm8250_desc, regmap);; Remove a semicolon. > +} > + > +static struct platform_driver cam_cc_sm8250_driver = { > + .probe = cam_cc_sm8250_probe, > + .driver = { > + .name = "cam_cc-sm8250", Maybe conforming with the naming scheme of "sdm845-camcc" is the better way to go. > + .of_match_table = cam_cc_sm8250_match_table, > + }, > +}; > + > +static int __init cam_cc_sm8250_init(void) > +{ > + return platform_driver_register(&cam_cc_sm8250_driver); > +} > +subsys_initcall(cam_cc_sm8250_init); > + > +static void __exit cam_cc_sm8250_exit(void) > +{ > + platform_driver_unregister(&cam_cc_sm8250_driver); > +} > +module_exit(cam_cc_sm8250_exit); > + > +MODULE_DESCRIPTION("QTI CAMCC SM8250 Driver"); > +MODULE_LICENSE("GPL v2"); > -- > 2.26.1 >