From: Robert Foss <robert.foss@linaro.org>
To: Yang Yingliang <yangyingliang@huawei.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
linux-media <linux-media@vger.kernel.org>
Subject: Re: [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init()
Date: Tue, 6 Apr 2021 10:30:58 +0200 [thread overview]
Message-ID: <CAG3jFyteoPaHe=0Q2FrduRchH+Or+M+PDBCor0uKYaGH3feyog@mail.gmail.com> (raw)
In-Reply-To: <20210402093255.2457184-1-yangyingliang@huawei.com>
Hi Yang,
Thanks for the fix.
Reviewed-by: Robert Foss <robert.foss@linaro.org>
On Fri, 2 Apr 2021 at 11:29, Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> There is a error message within devm_ioremap_resource
> already, so remove the dev_err call to avoid redundant
> error message.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/platform/qcom/camss/camss-csid.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
> index 463760c29294..cc11fbfdae13 100644
> --- a/drivers/media/platform/qcom/camss/camss-csid.c
> +++ b/drivers/media/platform/qcom/camss/camss-csid.c
> @@ -568,10 +568,8 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
>
> r = platform_get_resource_byname(pdev, IORESOURCE_MEM, res->reg[0]);
> csid->base = devm_ioremap_resource(dev, r);
> - if (IS_ERR(csid->base)) {
> - dev_err(dev, "could not map memory\n");
> + if (IS_ERR(csid->base))
> return PTR_ERR(csid->base);
> - }
>
> /* Interrupt */
>
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-04-06 8:31 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-02 9:32 [PATCH -next] media: camss: csid: Remove redundant dev_err call in msm_csid_subdev_init() Yang Yingliang
2021-04-06 8:30 ` Robert Foss [this message]
2021-05-26 19:03 ` patchwork-bot+linux-arm-msm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAG3jFyteoPaHe=0Q2FrduRchH+Or+M+PDBCor0uKYaGH3feyog@mail.gmail.com' \
--to=robert.foss@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).