From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AADD3C433ED for ; Thu, 20 May 2021 12:15:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8817B611AD for ; Thu, 20 May 2021 12:15:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234477AbhETMQa (ORCPT ); Thu, 20 May 2021 08:16:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53040 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234723AbhETMQO (ORCPT ); Thu, 20 May 2021 08:16:14 -0400 Received: from mail-pl1-x632.google.com (mail-pl1-x632.google.com [IPv6:2607:f8b0:4864:20::632]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C0540C07E5EE for ; Thu, 20 May 2021 03:57:30 -0700 (PDT) Received: by mail-pl1-x632.google.com with SMTP id s4so7246116plg.12 for ; Thu, 20 May 2021 03:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=PlV0ND2zMSHfNqzEpFSjKgb1Ow4U28pqFWjx1oA2ZI8=; b=BYZSBLouIgG4roXRxQcWWuJimWgriJIdH1kbtNbl8WjMOcvjShw3+qTxXf7yDjxjRw TuMJKaWlgb33vo8JffUd/G1Wivv9JHXi1KKaeh8S2YX1Yyl9kNwgDxuQ7p0dAP+UzVYS 3pc64XxVU33PaEzebd7oX6QQ8UF3hKt0ciOx8yi6Ci9XX4YxEerxDDWHDerw3cmz8Zv+ a0Uj4YgxKlxrdpJCI4DOTVdzd80YNL4ArB4vIpCbHBjZo5wQA5yRuLfVaptNpVqKl8K5 u/QBbXWx1/NM0rGtjw9raSNbbCwiwraBRm0lQYHSZzESZxnS+IRoYvyb2OiXZEDx26DK ECWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PlV0ND2zMSHfNqzEpFSjKgb1Ow4U28pqFWjx1oA2ZI8=; b=P9b46cvCqbPNSr7JifBKhlHtnCATLFehL35iTg0qzRZDDMsrhxhJty4aMlkjNGmpVz PLvK+KPLOKnYYU4zNNEafnyzPlkIpz6wNhV7e7ma/QF+gGkJGagriGLBBxMSyTIZnLKg pCYrWBjNIpGS2C4TONnPthKuLy6P2OlMi3h8DrxNSRFhvGxgAS842rEXA5la8M0p093e Ex/usHOPBd3ptr4Md1/IXuQIQyQCCYPimlywBShqNgShEiHhc0DPQZjTJfmXoFT+5/R6 FkIk4qDICRiH2WKvmqpgHEH086BlnhLojGu31vGYQ/YIJD/rXOZqTcO5O753VEBHMwZ4 h8OA== X-Gm-Message-State: AOAM532+L4KjMweQrfyh7p3DH2K7kVTzZ+UF+jCzrmJJxDoBAAaB3M9H LstmcPMDr4bIZFNh0UKlgr3odX7KPS5sMZH58k3n8g== X-Google-Smtp-Source: ABdhPJxGZPs13PLXuzze7/vkQeHoAbJomuHm3IrrZMyl4A5feCJsHjkf8pa88MmpcuR6RrfFqIkrob0bkH4c+26E8pQ= X-Received: by 2002:a17:902:b70f:b029:f4:5445:cd9f with SMTP id d15-20020a170902b70fb02900f45445cd9fmr5339434pls.32.1621508250299; Thu, 20 May 2021 03:57:30 -0700 (PDT) MIME-Version: 1.0 References: <20210511180728.23781-1-jonathan@marek.ca> <20210511180728.23781-7-jonathan@marek.ca> In-Reply-To: <20210511180728.23781-7-jonathan@marek.ca> From: Robert Foss Date: Thu, 20 May 2021 12:57:18 +0200 Message-ID: Subject: Re: [PATCH 06/17] media: camss: csid-170: remove stray comment To: Jonathan Marek Cc: MSM , Andrey Konovalov , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , Hans Verkuil , "open list:QUALCOMM CAMERA SUBSYSTEM DRIVER" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 11 May 2021 at 20:08, Jonathan Marek wrote: > > This is a leftover from my original patches, it doesn't serve any purpose. > (it was a reminder to figure out how downstream sets a particular field in > the register). > > Fixes: eebe6d00e9bf ("media: camss: Add support for CSID hardware version Titan 170") > Signed-off-by: Jonathan Marek > --- > drivers/media/platform/qcom/camss/camss-csid-170.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-170.c b/drivers/media/platform/qcom/camss/camss-csid-170.c > index 2bc695819919..3958bacd7b97 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-170.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-170.c > @@ -441,7 +441,7 @@ static void csid_configure_stream(struct csid_device *csid, u8 enable) > > val = 1 << CSI2_RX_CFG1_PACKET_ECC_CORRECTION_EN; > val |= 1 << CSI2_RX_CFG1_MISR_EN; > - writel_relaxed(val, csid->base + CSID_CSI2_RX_CFG1); // csi2_vc_mode_shift_val ? > + writel_relaxed(val, csid->base + CSID_CSI2_RX_CFG1); > > val = 1 << RDI_CTRL_HALT_CMD; > writel_relaxed(val, csid->base + CSID_RDI_CTRL(0)); Reviewed-by: Robert Foss