linux-arm-msm.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Robert Foss <robert.foss@linaro.org>
To: Vinod Koul <vkoul@kernel.org>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>,
	MSM <linux-arm-msm@vger.kernel.org>,
	Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sm8350: fix the node unit addresses
Date: Mon, 10 May 2021 10:31:40 +0200	[thread overview]
Message-ID: <CAG3jFyukM7tYMdQC_0HWGUBLZtafYu21yvk2LDLS0Ha_jJKm8g@mail.gmail.com> (raw)
In-Reply-To: <20210510070532.3838598-1-vkoul@kernel.org>

Hey Vinod,

Thanks for catching this.

On Mon, 10 May 2021 at 09:05, Vinod Koul <vkoul@kernel.org> wrote:
>
> Some node unit addresses were put wrongly in the dts, resulting in
> below warning when run with W=1
>
> arch/arm64/boot/dts/qcom/sm8350.dtsi:693.34-702.5: Warning (simple_bus_reg): /soc@0/thermal-sensor@c222000: simple-bus unit address format error, expected "c263000"
> arch/arm64/boot/dts/qcom/sm8350.dtsi:704.34-713.5: Warning (simple_bus_reg): /soc@0/thermal-sensor@c223000: simple-bus unit address format error, expected "c265000"
> arch/arm64/boot/dts/qcom/sm8350.dtsi:1180.32-1185.5: Warning (simple_bus_reg): /soc@0/interconnect@90e0000: simple-bus unit address format error, expected "90c0000"
>
> Fix by correcting to the correct address as given in reg node
>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
> ---
>  arch/arm64/boot/dts/qcom/sm8350.dtsi | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> index a8cd224a2f31..d015a9ca95a5 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi
> @@ -6,6 +6,7 @@
>  #include <dt-bindings/interrupt-controller/arm-gic.h>
>  #include <dt-bindings/clock/qcom,gcc-sm8350.h>
>  #include <dt-bindings/clock/qcom,rpmh.h>
> +#include <dt-bindings/interconnect/qcom,sm8350.h>
>  #include <dt-bindings/mailbox/qcom-ipcc.h>
>  #include <dt-bindings/power/qcom-aoss-qmp.h>
>  #include <dt-bindings/power/qcom-rpmpd.h>
> @@ -689,7 +690,7 @@ pdc: interrupt-controller@b220000 {
>                         interrupt-controller;
>                 };
>
> -               tsens0: thermal-sensor@c222000 {
> +               tsens0: thermal-sensor@c263000 {
>                         compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
>                         reg = <0 0x0c263000 0 0x1ff>, /* TM */
>                               <0 0x0c222000 0 0x8>; /* SROT */
> @@ -700,7 +701,7 @@ tsens0: thermal-sensor@c222000 {
>                         #thermal-sensor-cells = <1>;
>                 };
>
> -               tsens1: thermal-sensor@c223000 {
> +               tsens1: thermal-sensor@c265000 {
>                         compatible = "qcom,sm8350-tsens", "qcom,tsens-v2";
>                         reg = <0 0x0c265000 0 0x1ff>, /* TM */
>                               <0 0x0c223000 0 0x8>; /* SROT */
> @@ -1176,7 +1177,7 @@ usb_2_ssphy: phy@88ebe00 {
>                         };
>                 };
>
> -               dc_noc: interconnect@90e0000 {
> +               dc_noc: interconnect@90c0000 {
>                         compatible = "qcom,sm8350-dc-noc";
>                         reg = <0 0x090c0000 0 0x4200>;
>                         #interconnect-cells = <1>;

Reviewed-by: Robert Foss <robert.foss@linaro.org>

      reply	other threads:[~2021-05-10  8:31 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-05-10  7:05 Vinod Koul
2021-05-10  8:31 ` Robert Foss [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAG3jFyukM7tYMdQC_0HWGUBLZtafYu21yvk2LDLS0Ha_jJKm8g@mail.gmail.com \
    --to=robert.foss@linaro.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    --subject='Re: [PATCH] arm64: dts: qcom: sm8350: fix the node unit addresses' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).