From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43171C47080 for ; Mon, 31 May 2021 12:15:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1DB2B61364 for ; Mon, 31 May 2021 12:15:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231450AbhEaMQw (ORCPT ); Mon, 31 May 2021 08:16:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42216 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231409AbhEaMQv (ORCPT ); Mon, 31 May 2021 08:16:51 -0400 Received: from mail-pg1-x535.google.com (mail-pg1-x535.google.com [IPv6:2607:f8b0:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C598FC061760 for ; Mon, 31 May 2021 05:15:10 -0700 (PDT) Received: by mail-pg1-x535.google.com with SMTP id j12so8219099pgh.7 for ; Mon, 31 May 2021 05:15:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZrO5EoGp0aqI4U9edzA9+DdGnIJnfZ7S2pNXXSDEWA0=; b=gByaRhuj+Slb+b7TGJsldTArZ7e+3mhcvn2wdxsjqw+VkLABw9qrj+23Bu5Gts0R+G Ds/5gGZG3A04sxfGh6H5QgqXNK5lfTbNAPbeJcjcs/M7yXXb3bmKzEOIjSlKOxs00d7f rBCf4xiIlK6KoatAADWC/Q7uZavmRY/a1TmPBb1ACLxd43nbBkA89ywo+r56+b2MoaJb 24Rzeawazy9krqSUVBeNFISE76rrhST8syqtSyywRAc6VB54CMyzVc8+uz82A4SK1g+l ysyaJDxytTgbopr/OFNt5KptPHTDeN9xTu1lvoIJKS1vCPkMNbJNaYDIX6qn4bLZlfPw Wlgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZrO5EoGp0aqI4U9edzA9+DdGnIJnfZ7S2pNXXSDEWA0=; b=MXLn+tNi5L+sYRABaFRTcw4nvnkuIXGbwPkIh6lLGKeGR5HoXt4ikdgiUwcHlGzdHZ mzuk8n7Lkhm2DXM6NAm6vqVxwlp4QuR0/kwb5AiaRMSJF3STfe1oou+lv/zUNUZQtF8B zMWG1c0u0DxsHPpTvWiIS4/DETjIsJBPK2gdX5hMWyhFUn9ejK6ZXIhfbUKNLTGtzDTL abkX5+Rbx/U3v1d5bm81dCY3QumjARof0qqlaT7KBA0xIUk2UORW8I2taX7iSjmMyMvv Ib63UXHjprn/P3NAZY7WKMT9CnnNVQjyzPCU4z0bLDYzykAIYWpDTjzEPDbD9Y1aPjn4 W3xw== X-Gm-Message-State: AOAM532OnKuy21kRfey6aerMQYOBaZVspJ6LdPS0BxB6fIayO+ySQUrn tVgAJJsZCTuQMjC4YO3UoBUmJxFouwZVsCFwbZ37sA== X-Google-Smtp-Source: ABdhPJyLKIYECrVKVAGsrwT0VjrtzJzkkKBVsPZ9SKhee3M1rS+GLkUfJoHa1mex6LZID9vPr8JMha2BXW8PPLAeO1s= X-Received: by 2002:a05:6a00:88a:b029:261:6d37:dac6 with SMTP id q10-20020a056a00088ab02902616d37dac6mr16678883pfj.18.1622463310297; Mon, 31 May 2021 05:15:10 -0700 (PDT) MIME-Version: 1.0 References: <20210511180728.23781-1-jonathan@marek.ca> <20210511180728.23781-16-jonathan@marek.ca> In-Reply-To: <20210511180728.23781-16-jonathan@marek.ca> From: Robert Foss Date: Mon, 31 May 2021 14:14:59 +0200 Message-ID: Subject: Re: [PATCH 15/17] media: camss: add support for V4L2_PIX_FMT_GREY for sdm845 HW To: Jonathan Marek Cc: MSM , Andrey Konovalov , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , "open list:QUALCOMM CAMERA SUBSYSTEM DRIVER" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 11 May 2021 at 20:08, Jonathan Marek wrote: > > Add this common format to the various format lists relevant to sdm845. > > Signed-off-by: Jonathan Marek > --- > drivers/media/platform/qcom/camss/camss-csid-170.c | 7 +++++++ > drivers/media/platform/qcom/camss/camss-csiphy.c | 1 + > drivers/media/platform/qcom/camss/camss-vfe.c | 1 + > drivers/media/platform/qcom/camss/camss-video.c | 2 ++ > 4 files changed, 11 insertions(+) > > diff --git a/drivers/media/platform/qcom/camss/camss-csid-170.c b/drivers/media/platform/qcom/camss/camss-csid-170.c > index 9f6334fd68fc..5258e2099a43 100644 > --- a/drivers/media/platform/qcom/camss/camss-csid-170.c > +++ b/drivers/media/platform/qcom/camss/camss-csid-170.c > @@ -262,6 +262,13 @@ static const struct csid_format csid_formats[] = { > 10, > 1, > }, > + { > + MEDIA_BUS_FMT_Y8_1X8, > + DATA_TYPE_RAW_8BIT, > + DECODE_FORMAT_UNCOMPRESSED_8_BIT, > + 10, > + 1, > + }, > { > MEDIA_BUS_FMT_Y10_1X10, > DATA_TYPE_RAW_10BIT, > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy.c b/drivers/media/platform/qcom/camss/camss-csiphy.c > index b3c3bf19e522..f82f1e2aa688 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy.c > @@ -94,6 +94,7 @@ static const struct csiphy_format csiphy_formats_sdm845[] = { > { MEDIA_BUS_FMT_SGBRG14_1X14, 14 }, > { MEDIA_BUS_FMT_SGRBG14_1X14, 14 }, > { MEDIA_BUS_FMT_SRGGB14_1X14, 14 }, > + { MEDIA_BUS_FMT_Y8_1X8, 8 }, > { MEDIA_BUS_FMT_Y10_1X10, 10 }, > }; > > diff --git a/drivers/media/platform/qcom/camss/camss-vfe.c b/drivers/media/platform/qcom/camss/camss-vfe.c > index dec89079c6ae..e7ab2c175ac9 100644 > --- a/drivers/media/platform/qcom/camss/camss-vfe.c > +++ b/drivers/media/platform/qcom/camss/camss-vfe.c > @@ -118,6 +118,7 @@ static const struct vfe_format formats_rdi_845[] = { > { MEDIA_BUS_FMT_SGBRG14_1X14, 14 }, > { MEDIA_BUS_FMT_SGRBG14_1X14, 14 }, > { MEDIA_BUS_FMT_SRGGB14_1X14, 14 }, > + { MEDIA_BUS_FMT_Y8_1X8, 8 }, > { MEDIA_BUS_FMT_Y10_1X10, 10 }, > { MEDIA_BUS_FMT_Y10_2X8_PADHI_LE, 16 }, > }; > diff --git a/drivers/media/platform/qcom/camss/camss-video.c b/drivers/media/platform/qcom/camss/camss-video.c > index f282275af626..54e77d30d452 100644 > --- a/drivers/media/platform/qcom/camss/camss-video.c > +++ b/drivers/media/platform/qcom/camss/camss-video.c > @@ -176,6 +176,8 @@ static const struct camss_format_info formats_rdi_845[] = { > { { 1, 1 } }, { { 1, 1 } }, { 14 } }, > { MEDIA_BUS_FMT_SRGGB14_1X14, V4L2_PIX_FMT_SRGGB14P, 1, > { { 1, 1 } }, { { 1, 1 } }, { 14 } }, > + { MEDIA_BUS_FMT_Y8_1X8, V4L2_PIX_FMT_GREY, 1, > + { { 1, 1 } }, { { 1, 1 } }, { 8 } }, > { MEDIA_BUS_FMT_Y10_1X10, V4L2_PIX_FMT_Y10P, 1, > { { 1, 1 } }, { { 1, 1 } }, { 10 } }, > { MEDIA_BUS_FMT_Y10_2X8_PADHI_LE, V4L2_PIX_FMT_Y10, 1, Reviewed-by: Robert Foss