From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1BA4EC433ED for ; Wed, 19 May 2021 15:52:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id EEB5B611BD for ; Wed, 19 May 2021 15:52:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355009AbhESPyJ (ORCPT ); Wed, 19 May 2021 11:54:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60834 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346825AbhESPyD (ORCPT ); Wed, 19 May 2021 11:54:03 -0400 Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 81DFFC06175F for ; Wed, 19 May 2021 08:52:43 -0700 (PDT) Received: by mail-pl1-x630.google.com with SMTP id z4so5083484plg.8 for ; Wed, 19 May 2021 08:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AjaxYg4bUUARP67WdGinpCbYpxiblugMhlcvL7HjH8s=; b=exnK+d2N5ecA63XuVyOCKzjR4/cye2CMBz3pcMSTaRcM9gs5Ic38YZqMewJJFd16MT p0x7DhlXbr/+0VixgDfqq+En4zwXPeji2FA+ulvWQVxzmUldfdo2e5AwOMJ/Cw2EV4oY x3Y/nGHpsqOaI9GDwedwIJWbklq13gbzEENJgnvabAJquqBHI4IivPX3XPntBMDd1IUb bYOXHrIBxfyouKSWEnaeCawybiTYK/murqLNxF+VzIyNbtFHbAJA7cVZBkDQzhKODo+K 977ADWL9KRjFVmDH4i0jL3MaQi+mjoNfaOItgTT2V8h88glq7/WacRl3u1mclRFsneSH we5w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AjaxYg4bUUARP67WdGinpCbYpxiblugMhlcvL7HjH8s=; b=WpLps0xKiwTo9UNf4b5etKrd2ZL43JlIEUp/8nlhf24OLRD831W/U7UJykFNSfXPc9 Gz2JBctst4bxPmWL4Yn89ByG9fwuwz7dABvBFqnunlu/t46WZ7sb3dBt5MblnLLLbMDM N5c968iHvECX2J5wU+mHiW1h618ew1X+Uimjdv6uLHuWP2hqUj8U/7ncT5KmlpxdZDBS h17RrQbfopa1Rv1OJ+QK2eBl7qqHGmIWQYPKGEyjARrN+tNFUeV5/tMa0hHuPQK0CuII JFiIIsOakN+dmo1ImXXGuooxnWkLtcWWkEQ+CcCdg/vYhLVzGbRr/w/lbZXEY9EGaFTZ dDrQ== X-Gm-Message-State: AOAM533b5fU9UDNHl4S2mEPEN/XwEEcMisO0KmYQEAKSFpVFItktKH3F ZgIWkK5h88lYwApTHKoASyOoyRfvelEoKqDcUctdbQ== X-Google-Smtp-Source: ABdhPJznYOweZXIKYDgZ3nLOZlhjx+oq97Yjw8fXxaWJMMRlfhU/ljaNm1YJbtniMdzPJeCNQ4PYsRKhN4xoAo/Jfkk= X-Received: by 2002:a17:90a:b38d:: with SMTP id e13mr11507026pjr.222.1621439562957; Wed, 19 May 2021 08:52:42 -0700 (PDT) MIME-Version: 1.0 References: <20210511180728.23781-1-jonathan@marek.ca> <20210511180728.23781-3-jonathan@marek.ca> In-Reply-To: <20210511180728.23781-3-jonathan@marek.ca> From: Robert Foss Date: Wed, 19 May 2021 17:52:31 +0200 Message-ID: Subject: Re: [PATCH 02/17] media: camss: csiphy-3ph: disable interrupts To: Jonathan Marek Cc: MSM , Andrey Konovalov , Todor Tomov , Andy Gross , Bjorn Andersson , Mauro Carvalho Chehab , "open list:QUALCOMM CAMERA SUBSYSTEM DRIVER" , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 11 May 2021 at 20:08, Jonathan Marek wrote: > > The driver does nothing with the interrupts, so set the irq mask registers > to zero to avoid wasting CPU time for thing. > > Signed-off-by: Jonathan Marek > --- > .../qcom/camss/camss-csiphy-3ph-1-0.c | 35 ++----------------- > 1 file changed, 3 insertions(+), 32 deletions(-) > > diff --git a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > index 5948abdcd220..783b65295d20 100644 > --- a/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > +++ b/drivers/media/platform/qcom/camss/camss-csiphy-3ph-1-0.c > @@ -352,38 +352,9 @@ static void csiphy_lanes_enable(struct csiphy_device *csiphy, > else if (csiphy->camss->version == CAMSS_845) > csiphy_gen2_config_lanes(csiphy, settle_cnt); > > - val = 0xff; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(11)); > - > - val = 0xff; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(12)); > - > - val = 0xfb; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(13)); > - > - val = 0xff; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(14)); > - > - val = 0x7f; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(15)); > - > - val = 0xff; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(16)); > - > - val = 0xff; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(17)); > - > - val = 0xef; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(18)); > - > - val = 0xff; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(19)); > - > - val = 0xff; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(20)); > - > - val = 0xff; > - writel_relaxed(val, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(21)); > + /* IRQ_MASK registers - disable all interrupts */ > + for (i = 11; i < 22; i++) > + writel_relaxed(0, csiphy->base + CSIPHY_3PH_CMN_CSI_COMMON_CTRLn(i)); > } > > static void csiphy_lanes_disable(struct csiphy_device *csiphy, Reviewed-by: Robert Foss