From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9B95AC47082 for ; Mon, 7 Jun 2021 21:23:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7808660FF4 for ; Mon, 7 Jun 2021 21:23:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230444AbhFGVZc (ORCPT ); Mon, 7 Jun 2021 17:25:32 -0400 Received: from mail-oi1-f174.google.com ([209.85.167.174]:39562 "EHLO mail-oi1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230394AbhFGVZb (ORCPT ); Mon, 7 Jun 2021 17:25:31 -0400 Received: by mail-oi1-f174.google.com with SMTP id m137so15613518oig.6 for ; Mon, 07 Jun 2021 14:23:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=w6cymmwnuygy/COmkDxXiw8w0MLPT3SB23LZKuJIhqk=; b=Imw57YSTwplWKEaH2jMh6y9gjQOKM8C1ctxHYEQ4dx59CFGUQ1ETLCB1TpAKziLjwt a0i4CTX50+J9bvQdiQKTP7+RxQ4AbFp5UGPNgoOyW1WPlhMuuTP+ythNexcFfqigCdUp A8VqriRQAwEurYZ+P/KtbMwxGC4UUy3jZUGdydWEBQNfk/1qSx2vxv886TtRRN3tuCbY ERaBsHn+VcrwzET8xcvKm6k1a5vlk85NgZhckQ8VWlzBq5j6gfKukSm8+wVsOG8Advq0 HwD1RnVxQ+XmmD572VlV/Kr3MZtY2KCI37jpWNU95JdLcW332f/+KXdwb7GBOpQ+k+fS cQ8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w6cymmwnuygy/COmkDxXiw8w0MLPT3SB23LZKuJIhqk=; b=OaipIZsK+X+JxguCdn0FkIUDSdLnWP7E6gdlwwGun4JSObZSFBq6BAj/THmXNC3riv OQ6eF9/oxRCOtJk9oQvhJsnGPs2kNudFZvj3ZomA7BBUGv4VziG2M71idePZnxR4/sdg F64gI0hkGRKJSTulzh0nzGq5gX6nAhAoCTi97rnSysT09rKcb7nTqDzojozZvg3LwCdx Hck+kOpa4iOPYnFL5XappaBw5RatVS8QJCfvSEX3yXHlPPC0R2cvWzDAWWroC7jKNJrk OWDJOkWwGvU4HfsG6DskwtgvQYBvCrt+X2h1uC1XhOLVs0tImHXBqFuAXngPuhnmKid9 pbpA== X-Gm-Message-State: AOAM5324JKQoSpl89DCH8UvhC2DV/yfZ5m9ynItB5Js8h24Um7QWyypT O8Z1j54RVvP8/7sqzzM74P/OeCn1m1VUwQO3kZ5+8g== X-Google-Smtp-Source: ABdhPJzVFi4ifcs3tEOiN3F0lwd561XWqjtWfo2MVoHwh8/TETf0Auy+GPFCcuTowEovcpU5FdnKuZ9hUIPCM2+C734= X-Received: by 2002:a05:6808:f0b:: with SMTP id m11mr675937oiw.12.1623100959866; Mon, 07 Jun 2021 14:22:39 -0700 (PDT) MIME-Version: 1.0 References: <20210607113840.15435-1-bhupesh.sharma@linaro.org> <20210607113840.15435-9-bhupesh.sharma@linaro.org> In-Reply-To: From: Bhupesh Sharma Date: Tue, 8 Jun 2021 02:52:28 +0530 Message-ID: Subject: Re: [PATCH 8/8] arm64: dts: qcom: sa8155p-adp: Add base dts file To: Vinod Koul Cc: linux-arm-msm@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Bjorn Andersson , Rob Herring , Andy Gross , devicetree , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , bhupesh.linux@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Vinod, Thanks for your review. On Mon, 7 Jun 2021 at 20:52, Vinod Koul wrote: > > On 07-06-21, 17:08, Bhupesh Sharma wrote: > > Add base DTS file for sa8155p-adp and enable boot to console, > > tlmm reserved range and also include pmic file(s). > > I see ufs added too, pls mention that as well Oops, missed that. Will fix it in v2. > --- a/arch/arm64/boot/dts/qcom/Makefile > > +++ b/arch/arm64/boot/dts/qcom/Makefile > > @@ -71,6 +71,7 @@ dtb-$(CONFIG_ARCH_QCOM) += sdm845-xiaomi-beryllium.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sdm850-lenovo-yoga-c630.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sm8150-hdk.dtb > > dtb-$(CONFIG_ARCH_QCOM) += sm8150-mtp.dtb > > +dtb-$(CONFIG_ARCH_QCOM) += sa8155p-adp.dtb > > I think this should go before sdm.. Oh, ok, I thought of keeping all boards based on sm8150 SoC together. But alphabetically, it makes more sense to put it earlier. > > + vdd_usb_hs_core: > > + vdda_pll_hv_cc_ebi01: > > + vdda_pll_hv_cc_ebi23: > > + vdda_ufs_2ln_core: > > + vdda_ufs_2ln_core: > > + vdda_usb_ss_core: > > + vdda_usb_ss_dp_core_1: > > + vdda_usb_ss_dp_core_2: > > + vdda_sp_sensor: > > + vdda_qlink_lv: > > + vdda_qlink_lv_ck: > > + vdda_qrefs_0p875_5: > > I didnt find these labels very useful, so maybe remove? > It helped me to understand that a regulator is vreg_l5a_0p88 as it > implies I am using l5a with 0p88V :) While a few labels like 'vdd_usb_hs_core' are used in this patch (for example) to denote 'vdda-pll-supply ' of 'usb_1_hsphy', the others would be required as we enable further on-boards peripherals in the dts. I will recheck and limit these further in v2. > > + vreg_l5a_0p88: ldo5 { > > + regulator-min-microvolt = <880000>; > > + regulator-max-microvolt = <880000>; > > + regulator-initial-mode = ; > > Pls do add regulator-name property, it helps in understanding which ldo > in logs/debugfs, otherwise ldo5 will comes for both pmics That's a good point. Will fix this in v2. Regards, Bhupesh > -- > ~Vinod