From: Bhupesh Sharma <bhupesh.sharma@linaro.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: linux-arm-msm@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, bhupesh.linux@gmail.com Subject: Re: [PATCH 5/8] pinctrl: qcom/pinctrl-spmi-gpio: Add compatibles for pmic-gpios on SA8155p-adp Date: Mon, 14 Jun 2021 14:00:01 +0530 [thread overview] Message-ID: <CAH=2Ntwkk4Hw1VQcXu9y08jPHWf99EFmj=7GG0V4uuwbNK7c0A@mail.gmail.com> (raw) In-Reply-To: <YMLR11+6A/6klgqJ@builder.lan> Hi Bjorn, On Fri, 11 Jun 2021 at 08:30, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > > > SA8155p-adp PMICs (PMM8155AU_1 and PMM8155AU_2) expose > > the following PMIC GPIO blocks: > > > > - PMM8155AU_1: gpio1-gpio10 (with holes on gpio2, gpio5, gpio7 and gpio8) > > - PMM8155AU_2: gpio1-gpio10 (with holes on gpio2, gpio5, gpio7) > > > > Add support for the same in the pinctrl driver. > > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Liam Girdwood <lgirdwood@gmail.com> > > Cc: Mark Brown <broonie@kernel.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Vinod Koul <vkoul@kernel.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Andy Gross <agross@kernel.org> > > Cc: devicetree@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-gpio@vger.kernel.org > > Cc: bhupesh.linux@gmail.com > > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org> > > --- > > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > > index 00870da0c94e..890c44b6e198 100644 > > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > > @@ -1127,6 +1127,10 @@ static const struct of_device_id pmic_gpio_of_match[] = { > > { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 }, > > /* pm8150l has 12 GPIOs with holes on 7 */ > > { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 }, > > + /* pmm8155au-1 has 10 GPIOs with holes on 2, 5, 7 and 8 */ > > + { .compatible = "qcom,pmm8155au-1-gpio", .data = (void *) 10 }, > > As noted in the binding, I think this should be "qcom,pmm8155au-gpio" > and please skip the comment about the holes. Similar to what I noted in the binding patch review thread, the pmic gpio holes seem different as per the downstream dtsi. So, please let me know and if required, I can make the suggested change in v2. Thanks, Bhupesh > > + /* pmm8155au-2 has 10 GPIOs with holes on 2, 5 and 7 */ > > + { .compatible = "qcom,pmm8155au-2-gpio", .data = (void *) 10 }, > > { .compatible = "qcom,pm8350-gpio", .data = (void *) 10 }, > > { .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 }, > > { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 }, > > -- > > 2.31.1 > >
next prev parent reply other threads:[~2021-06-14 8:30 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 11:38 [PATCH 0/8] arm64: dts: qcom: Add SA8155p-adp board DTS Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 1/8] dt-bindings: qcom: rpmh-regulator: Add compatible for SA8155p-adp board pmics Bhupesh Sharma 2021-06-11 2:48 ` Bjorn Andersson 2021-06-14 8:05 ` Bhupesh Sharma 2021-06-14 16:28 ` Bjorn Andersson 2021-06-15 4:43 ` Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 2/8] dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for SA8155p-adp Bhupesh Sharma 2021-06-11 2:51 ` Bjorn Andersson 2021-06-14 8:13 ` Bhupesh Sharma 2021-06-14 16:09 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 3/8] dt-bindings: arm: qcom: Add compatible for SA8155p-adp board Bhupesh Sharma 2021-06-11 2:59 ` Bjorn Andersson 2021-06-14 8:14 ` Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 4/8] regulator: qcom-rpmh: Add new regulator types found on SA8155p adp board Bhupesh Sharma 2021-06-07 12:09 ` Andy Shevchenko 2021-06-07 12:30 ` Bhupesh Sharma 2021-06-14 16:17 ` Bjorn Andersson 2021-06-15 4:47 ` Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 5/8] pinctrl: qcom/pinctrl-spmi-gpio: Add compatibles for pmic-gpios on SA8155p-adp Bhupesh Sharma 2021-06-11 3:00 ` Bjorn Andersson 2021-06-14 8:30 ` Bhupesh Sharma [this message] 2021-06-14 16:12 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 6/8] arm64: dts: qcom: pmm8155au_1: Add base dts file Bhupesh Sharma 2021-06-11 3:12 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 7/8] arm64: dts: qcom: pmm8155au_2: " Bhupesh Sharma 2021-06-11 3:13 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 8/8] arm64: dts: qcom: sa8155p-adp: " Bhupesh Sharma 2021-06-07 15:22 ` Vinod Koul 2021-06-07 21:22 ` Bhupesh Sharma 2021-06-11 2:25 ` Bjorn Andersson 2021-06-14 8:19 ` Bhupesh Sharma 2021-06-15 4:41 ` Bhupesh Sharma
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAH=2Ntwkk4Hw1VQcXu9y08jPHWf99EFmj=7GG0V4uuwbNK7c0A@mail.gmail.com' \ --to=bhupesh.sharma@linaro.org \ --cc=agross@kernel.org \ --cc=bhupesh.linux@gmail.com \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ --subject='Re: [PATCH 5/8] pinctrl: qcom/pinctrl-spmi-gpio: Add compatibles for pmic-gpios on SA8155p-adp' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).