From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 942F3C48BE6 for ; Mon, 14 Jun 2021 08:30:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7226C61380 for ; Mon, 14 Jun 2021 08:30:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232594AbhFNIcb (ORCPT ); Mon, 14 Jun 2021 04:32:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232568AbhFNIc3 (ORCPT ); Mon, 14 Jun 2021 04:32:29 -0400 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 83A18C061766 for ; Mon, 14 Jun 2021 01:30:12 -0700 (PDT) Received: by mail-oi1-x22c.google.com with SMTP id w127so13576528oig.12 for ; Mon, 14 Jun 2021 01:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QSAHKTcFLCX8/C+Bt+qS/8aN90gNtcFpqWMBF4o9Lj8=; b=VxonmO7//XNFF8uHng7+ibIJaaO64cmwcIbhuWWcRpu/HZC9Vw4PUvNSjFlajDj6A+ k15Onk8ncCro83SlDNSU7GWY8afW2uvs+Bv3R4wHcW+KPAkbYs+FTuBfCFY2LWQH5dmJ /y4weBRLHacyVQOkSitblHkwFMKQZ+qqgNQtuRK1Jo2BxYotu0dmCYSVtLG+kEclv1NW CD6I6QaH0BSFKeEAG+trxVzJDtllSmsGLwhrNbQo0RE2ijIZvSihb5qe5W9UK4E5raNC butaxzrAlZ6SFSkaCGX8G2TTOrQNpCR25EhCtUBEaiAP2RQSRWJ1WCiKysdjRMziZg73 GzXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QSAHKTcFLCX8/C+Bt+qS/8aN90gNtcFpqWMBF4o9Lj8=; b=K9FMi3L8Ifc4wuhL/UQCCnBg04XuvyqROslJ/X2+JwdTi2o/yoptV8CfccsRBW8I7O W8c457nq57VLRWOMzqjTy6olQp7mxnZO8ay/vyrVO029U1BdhcdHRRpKybW0ZitCkMI+ DZpS4GiYKClgkEvfFZ+e+3JJk0ILjbRYbGbTG3vqG5apk7dMEoHvmCtyN51vHw0g0W1d 2aY70YiugFuKCr3iha0YCk6ssraDN/NahsrYAKw9fbzTG7BAgZIopp5GqgaIT8uhvyOq LpQdOE0EABabK5JZMyQZkh0j7ZUkEDcg464KKzvl5OodrXBcIpaJMUfeKkXZiSgUHP02 4G9A== X-Gm-Message-State: AOAM531L73r8k7JJhRGiK9aL1yBaUsL43Idbpdb1W+uF1sML/HCKcJT/ G1l5yNeQjS+qskyRo+MfiiBFtdWTkwXeGT/hhqHWZA== X-Google-Smtp-Source: ABdhPJz/rFMYq32ngA97nWv9bcy6sRojEmIB+U6ypCZQVoSHnGd1gzxCypoSPG3LS0SUdLiasD1CgGdr6DWCs/LTaCU= X-Received: by 2002:aca:4bd7:: with SMTP id y206mr9866132oia.40.1623659411792; Mon, 14 Jun 2021 01:30:11 -0700 (PDT) MIME-Version: 1.0 References: <20210607113840.15435-1-bhupesh.sharma@linaro.org> <20210607113840.15435-6-bhupesh.sharma@linaro.org> In-Reply-To: From: Bhupesh Sharma Date: Mon, 14 Jun 2021 14:00:01 +0530 Message-ID: Subject: Re: [PATCH 5/8] pinctrl: qcom/pinctrl-spmi-gpio: Add compatibles for pmic-gpios on SA8155p-adp To: Bjorn Andersson Cc: linux-arm-msm@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Vinod Koul , Rob Herring , Andy Gross , devicetree , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , bhupesh.linux@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Bjorn, On Fri, 11 Jun 2021 at 08:30, Bjorn Andersson wrote: > > On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > > > SA8155p-adp PMICs (PMM8155AU_1 and PMM8155AU_2) expose > > the following PMIC GPIO blocks: > > > > - PMM8155AU_1: gpio1-gpio10 (with holes on gpio2, gpio5, gpio7 and gpio8) > > - PMM8155AU_2: gpio1-gpio10 (with holes on gpio2, gpio5, gpio7) > > > > Add support for the same in the pinctrl driver. > > > > Cc: Linus Walleij > > Cc: Liam Girdwood > > Cc: Mark Brown > > Cc: Bjorn Andersson > > Cc: Vinod Koul > > Cc: Rob Herring > > Cc: Andy Gross > > Cc: devicetree@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-gpio@vger.kernel.org > > Cc: bhupesh.linux@gmail.com > > Signed-off-by: Bhupesh Sharma > > --- > > drivers/pinctrl/qcom/pinctrl-spmi-gpio.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > > index 00870da0c94e..890c44b6e198 100644 > > --- a/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > > +++ b/drivers/pinctrl/qcom/pinctrl-spmi-gpio.c > > @@ -1127,6 +1127,10 @@ static const struct of_device_id pmic_gpio_of_match[] = { > > { .compatible = "qcom,pm8150b-gpio", .data = (void *) 12 }, > > /* pm8150l has 12 GPIOs with holes on 7 */ > > { .compatible = "qcom,pm8150l-gpio", .data = (void *) 12 }, > > + /* pmm8155au-1 has 10 GPIOs with holes on 2, 5, 7 and 8 */ > > + { .compatible = "qcom,pmm8155au-1-gpio", .data = (void *) 10 }, > > As noted in the binding, I think this should be "qcom,pmm8155au-gpio" > and please skip the comment about the holes. Similar to what I noted in the binding patch review thread, the pmic gpio holes seem different as per the downstream dtsi. So, please let me know and if required, I can make the suggested change in v2. Thanks, Bhupesh > > + /* pmm8155au-2 has 10 GPIOs with holes on 2, 5 and 7 */ > > + { .compatible = "qcom,pmm8155au-2-gpio", .data = (void *) 10 }, > > { .compatible = "qcom,pm8350-gpio", .data = (void *) 10 }, > > { .compatible = "qcom,pm8350b-gpio", .data = (void *) 8 }, > > { .compatible = "qcom,pm8350c-gpio", .data = (void *) 9 }, > > -- > > 2.31.1 > >