From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA657C433EF for ; Wed, 13 Oct 2021 17:15:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B5FD9610EA for ; Wed, 13 Oct 2021 17:15:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237860AbhJMRRL (ORCPT ); Wed, 13 Oct 2021 13:17:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60924 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237654AbhJMRRJ (ORCPT ); Wed, 13 Oct 2021 13:17:09 -0400 Received: from mail-oi1-x236.google.com (mail-oi1-x236.google.com [IPv6:2607:f8b0:4864:20::236]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 041C3C061749 for ; Wed, 13 Oct 2021 10:15:06 -0700 (PDT) Received: by mail-oi1-x236.google.com with SMTP id g125so4731907oif.9 for ; Wed, 13 Oct 2021 10:15:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EagSEJLuJ76DU1xuVtP8rPwTPOeomx72A3YkYCudisw=; b=QC1Nf8QJGGrpFuYv0xu/VPSu8kkfNkQpIgx/LAvTCvhSVujjNyQLtWm2c34LJnZfbw hMFNl/JEfTo+fG3NTl30MTUhtWinqVy/q/EqcwV31Sz5tv7rUpLOJwsqDX3TM0pEGm+X nCAcpAcyWvnoRpixKQCr+K+Pe9KfQtQwIZeh23IaRBR7uYqC2i9s7sBBSJUVYx3gTCVQ wsfPAxkB36YxNKfRcCu+1osxADUi/r39xrUjaQKdOB20xmdMKK0uITRt5OpDS2G9nkkc AHdDDLtf5hEGC+6tLibOaabbxFo2UqhxGiw7/UrvIPqEh/aEHUBs51krN+eC2cGVLo4d YS7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EagSEJLuJ76DU1xuVtP8rPwTPOeomx72A3YkYCudisw=; b=uUC+vJhwBwsExeTXDuS9J9uy+yunrIkiymf5N/VKXAKB7v+DPAbtdKcJnRFxNIQCXG PPpJXZ46piMrUERCpLhHihGKuHJRMKQrOJjAZKM6JusXuTxplwqvCtginFIPK0DeE6jq lqhYu46whqAzfJFbWPI53Fs70juOy1FJNNbKNogx4Iy5xq7lT8nHfdx5j3UnvJCTLGqJ 8Tk14w56Z50gSG3fUVNHsyCLtEKBok4rAo2ShXx3dcO4oy81Jh1RaldsSo6ktwIJzTSv ZWjrZxRoGCPyB8Vw/Uo8RmfAxyOlPmK9ihaVYxVbht2osfNiLim54OpVyyEDxPGsjg6w 9Vxw== X-Gm-Message-State: AOAM530vdDiRmvF0lg9k6Ic6ZeSnSkRqxa3PDX10z50JSB5Tx2HEwOY7 VFjU40i1adPnjVJDolee1Jx0mfXTFDAGwJTt5lImGQ== X-Google-Smtp-Source: ABdhPJyof8AP6eNsSD6J4Oos5uZK9mgOi8QhTiPR4KT65njhsOIHv+m0av05pydrGtvWHgaPSyadSiB8AdaiL3xhziY= X-Received: by 2002:aca:6549:: with SMTP id j9mr9524859oiw.126.1634145305328; Wed, 13 Oct 2021 10:15:05 -0700 (PDT) MIME-Version: 1.0 References: <20211013105541.68045-1-bhupesh.sharma@linaro.org> <20211013105541.68045-6-bhupesh.sharma@linaro.org> <6d325686-461a-b321-148c-0142933a29e4@linaro.org> In-Reply-To: <6d325686-461a-b321-148c-0142933a29e4@linaro.org> From: Bhupesh Sharma Date: Wed, 13 Oct 2021 22:44:54 +0530 Message-ID: Subject: Re: [PATCH v4 05/20] dt-bindings: qcom-bam: Add 'interconnects' & 'interconnect-names' to optional properties To: Vladimir Zapolskiy Cc: MSM , linux-crypto@vger.kernel.org, bhupesh.linux@gmail.com, Linux Kernel Mailing List , devicetree , Rob Herring , Andy Gross , Herbert Xu , "David S . Miller" , Thara Gopinath , Bjorn Andersson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Vladimir, On Wed, 13 Oct 2021 at 18:33, Vladimir Zapolskiy wrote: > > Hi Bhupesh, > > On 10/13/21 1:55 PM, Bhupesh Sharma wrote: > > Add new optional properties - 'interconnects' and > > 'interconnect-names' to the device-tree binding documentation for > > qcom-bam DMA IP. > > > > These properties describe the interconnect path between bam and main > > memory and the interconnect type respectively. > > > > Cc: Thara Gopinath > > Cc: Bjorn Andersson > > Cc: Rob Herring > > Signed-off-by: Bhupesh Sharma > > --- > > Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > > index 32b47e3b7769..602e68df971f 100644 > > --- a/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > > +++ b/Documentation/devicetree/bindings/dma/qcom_bam_dma.yaml > > @@ -45,6 +45,14 @@ properties: > > const: 1 > > description: The single cell represents the channel index. > > > > + interconnects: > > + maxItems: 1 > > + description: | > > here I have the same comment about the set literal style of the > multi-line description, which is one-line, likely the specifier > is not needed... Ok, I will fix it in v5. Regards, Bhupesh > > + Interconnect path between bam and main memory. > > + > > + interconnect-names: > > + const: memory > > + > > qcom,ee: > > $ref: /schemas/types.yaml#/definitions/uint32 > > description: > > > > -- > Best wishes, > Vladimir