From: Bhupesh Sharma <bhupesh.sharma@linaro.org> To: Bjorn Andersson <bjorn.andersson@linaro.org> Cc: linux-arm-msm@vger.kernel.org, Linus Walleij <linus.walleij@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org>, devicetree <devicetree@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, bhupesh.linux@gmail.com Subject: Re: [PATCH 8/8] arm64: dts: qcom: sa8155p-adp: Add base dts file Date: Tue, 15 Jun 2021 10:11:31 +0530 [thread overview] Message-ID: <CAH=2Ntyi=a0tiyW0D-MvGW+dDdWjNVS4EAcrWZBc=fU8bRphng@mail.gmail.com> (raw) In-Reply-To: <YMLJsieGd+G+/kxK@builder.lan> On Fri, 11 Jun 2021 at 07:55, Bjorn Andersson <bjorn.andersson@linaro.org> wrote: > > On Mon 07 Jun 06:38 CDT 2021, Bhupesh Sharma wrote: > > > Add base DTS file for sa8155p-adp and enable boot to console, > > Please spell out "sa8155-adp", i.e. "Add base DTS for SA8155p Automotive > Development Platform." > > > tlmm reserved range and also include pmic file(s). > > > > SA8155p-adp board is based on sm8150 Qualcomm Snapdragon SoC. > > > > It's not based on sm8150, it's based on sa8155p, so let's express this > as "The SA8155p platform is similar to the SM8150, so use this as base > for now", to document why we decided to do this. > > > Cc: Linus Walleij <linus.walleij@linaro.org> > > Cc: Liam Girdwood <lgirdwood@gmail.com> > > Cc: Mark Brown <broonie@kernel.org> > > Cc: Bjorn Andersson <bjorn.andersson@linaro.org> > > Cc: Vinod Koul <vkoul@kernel.org> > > Cc: Rob Herring <robh+dt@kernel.org> > > Cc: Andy Gross <agross@kernel.org> > > Cc: devicetree@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > Cc: linux-gpio@vger.kernel.org > > Cc: bhupesh.linux@gmail.com <..snip..> > > +&apps_rsc { > > + pmm8155au-1-rpmh-regulators { > > + compatible = "qcom,pmm8155au-1-rpmh-regulators"; > > + qcom,pmic-id = "a"; > > + > > + vdd-s1-supply = <&vreg_3p3>; > > + vdd-s2-supply = <&vreg_3p3>; > > + vdd-s3-supply = <&vreg_3p3>; > > + vdd-s4-supply = <&vreg_3p3>; > > + vdd-s5-supply = <&vreg_3p3>; > > + vdd-s6-supply = <&vreg_3p3>; > > + vdd-s7-supply = <&vreg_3p3>; > > + vdd-s8-supply = <&vreg_3p3>; > > + vdd-s9-supply = <&vreg_3p3>; > > + vdd-s10-supply = <&vreg_3p3>; > > + > > + vdd-l1-l8-l11-supply = <&vreg_s6a_0p92>; > > + vdd-l2-l10-supply = <&vreg_3p3>; > > + vdd-l3-l4-l5-l18-supply = <&vreg_s6a_0p92>; > > + vdd-l6-l9-supply = <&vreg_s6a_0p92>; > > + vdd-l7-l12-l14-l15-supply = <&vreg_s5a_2p04>; > > + vdd-l13-l16-l17-supply = <&vreg_3p3>; > > + > > + vreg_s5a_2p04: smps5 { > > + regulator-min-microvolt = <1904000>; > > + regulator-max-microvolt = <2000000>; > > + }; > > + > > + vreg_s6a_0p92: smps6 { > > + regulator-min-microvolt = <920000>; > > + regulator-max-microvolt = <1128000>; > > + }; > > + > > + vdda_wcss_pll: > > This is the "label" of the pad which the regulator typically is > connected to (rather than a denotion of which regulator it is). So even > though we have these in some of the other boards, I would prefer if you > skip them and only use the vreg_xyz_abc variant. Lets keep the 'vdd_xx_abc labels' though which are used as input supply pads for peripherals, for e.g.: &usb_1_hsphy { status = "okay"; vdda-pll-supply = <&vdd_usb_hs_core>; vdda33-supply = <&vdda_usb_hs_3p1>; vdda18-supply = <&vdda_usb_hs_1p8>; }; IMO, here it makes sense to retain labels 'vdda_usb_hs_3p1' and 'vdda_usb_hs_1p8' in the dts (also making it easier to trace the same in schematics). I will send the v2 with the other suggested changes shortly. Regards, Bhupesh <..snip..>
prev parent reply other threads:[~2021-06-15 4:41 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-07 11:38 [PATCH 0/8] arm64: dts: qcom: Add SA8155p-adp board DTS Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 1/8] dt-bindings: qcom: rpmh-regulator: Add compatible for SA8155p-adp board pmics Bhupesh Sharma 2021-06-11 2:48 ` Bjorn Andersson 2021-06-14 8:05 ` Bhupesh Sharma 2021-06-14 16:28 ` Bjorn Andersson 2021-06-15 4:43 ` Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 2/8] dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for SA8155p-adp Bhupesh Sharma 2021-06-11 2:51 ` Bjorn Andersson 2021-06-14 8:13 ` Bhupesh Sharma 2021-06-14 16:09 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 3/8] dt-bindings: arm: qcom: Add compatible for SA8155p-adp board Bhupesh Sharma 2021-06-11 2:59 ` Bjorn Andersson 2021-06-14 8:14 ` Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 4/8] regulator: qcom-rpmh: Add new regulator types found on SA8155p adp board Bhupesh Sharma 2021-06-07 12:09 ` Andy Shevchenko 2021-06-07 12:30 ` Bhupesh Sharma 2021-06-14 16:17 ` Bjorn Andersson 2021-06-15 4:47 ` Bhupesh Sharma 2021-06-07 11:38 ` [PATCH 5/8] pinctrl: qcom/pinctrl-spmi-gpio: Add compatibles for pmic-gpios on SA8155p-adp Bhupesh Sharma 2021-06-11 3:00 ` Bjorn Andersson 2021-06-14 8:30 ` Bhupesh Sharma 2021-06-14 16:12 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 6/8] arm64: dts: qcom: pmm8155au_1: Add base dts file Bhupesh Sharma 2021-06-11 3:12 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 7/8] arm64: dts: qcom: pmm8155au_2: " Bhupesh Sharma 2021-06-11 3:13 ` Bjorn Andersson 2021-06-07 11:38 ` [PATCH 8/8] arm64: dts: qcom: sa8155p-adp: " Bhupesh Sharma 2021-06-07 15:22 ` Vinod Koul 2021-06-07 21:22 ` Bhupesh Sharma 2021-06-11 2:25 ` Bjorn Andersson 2021-06-14 8:19 ` Bhupesh Sharma 2021-06-15 4:41 ` Bhupesh Sharma [this message]
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAH=2Ntyi=a0tiyW0D-MvGW+dDdWjNVS4EAcrWZBc=fU8bRphng@mail.gmail.com' \ --to=bhupesh.sharma@linaro.org \ --cc=agross@kernel.org \ --cc=bhupesh.linux@gmail.com \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=lgirdwood@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ --subject='Re: [PATCH 8/8] arm64: dts: qcom: sa8155p-adp: Add base dts file' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).