From: Bhupesh Sharma <bhupesh.sharma@linaro.org> To: Konrad Dybcio <konrad.dybcio@somainline.org> Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com, "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, devicetree <devicetree@vger.kernel.org>, Linus Walleij <linus.walleij@linaro.org>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Bjorn Andersson <bjorn.andersson@linaro.org>, Vinod Koul <vkoul@kernel.org>, Rob Herring <robh+dt@kernel.org>, Andy Gross <agross@kernel.org> Subject: Re: [PATCH v2 10/10] arm64: dts: qcom: sa8155p-adp: Add base dts file Date: Tue, 15 Jun 2021 22:30:39 +0530 [thread overview] Message-ID: <CAH=2NtzOzA9HmxFUUuhX9Vy=KW3iRSx5HiuD9Cf11v+eijEWsQ@mail.gmail.com> (raw) In-Reply-To: <0b012d77-8d61-f852-f455-8b6cceb03ebf@somainline.org> Hi Konrad, Thanks for the review. On Tue, 15 Jun 2021 at 20:23, Konrad Dybcio <konrad.dybcio@somainline.org> wrote: > > Hi, > > > > + > > + reset-gpios = <&tlmm 175 GPIO_ACTIVE_LOW>; > > + > > + vcc-supply = <&vreg_l10a_2p96>; > > + vcc-max-microamp = <750000>; > > + vccq-supply = <&vreg_l5c_1p2>; > > + vccq-max-microamp = <700000>; > > + vccq2-supply = <&vreg_s4a_1p8>; > > + vccq2-max-microamp = <750000>; > > You need to add "regulator-allow-set-load;" to the mentioned supplies, > > as you're controlling the amperage here. Ok, I will fix this in v3. > > +}; > > + > > +&ufs_mem_phy { > > + status = "okay"; > > + > > + vdda-phy-supply = <&vreg_l8c_1p2>; > > + vdda-max-microamp = <87100>; > > + vdda-pll-supply = <&vreg_l5a_0p88>; > > + vdda-pll-max-microamp = <18300>; > > Ditto Sure, I will fix it in v3. Thanks, Bhupesh
next prev parent reply other threads:[~2021-06-15 17:00 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-06-15 7:45 [PATCH v2 00/10] arm64: dts: qcom: Add SA8155p-adp board DTS Bhupesh Sharma 2021-06-15 7:45 ` [PATCH v2 01/10] dt-bindings: qcom: rpmh-regulator: Add compatible for SA8155p-adp board pmic Bhupesh Sharma 2021-06-24 20:47 ` Rob Herring 2021-06-15 7:45 ` [PATCH v2 02/10] dt-bindings: pinctrl: qcom,pmic-gpio: Add compatible for SA8155p-adp Bhupesh Sharma 2021-06-15 21:00 ` Bjorn Andersson 2021-06-16 6:26 ` Bhupesh Sharma 2021-06-15 7:45 ` [PATCH v2 03/10] dt-bindings: arm: qcom: Add compatible for sm8150-mtp board Bhupesh Sharma 2021-06-15 7:45 ` [PATCH v2 04/10] dt-bindings: arm: qcom: Add compatible for SA8155p-adp board Bhupesh Sharma 2021-06-15 7:45 ` [PATCH v2 05/10] regulator: qcom-rpmh: Cleanup terminator line commas Bhupesh Sharma 2021-06-15 21:06 ` Bjorn Andersson 2021-06-15 7:45 ` [PATCH v2 06/10] regulator: qcom-rpmh: Add new regulator found on SA8155p adp board Bhupesh Sharma 2021-06-15 11:12 ` Mark Brown 2021-06-15 14:38 ` Bhupesh Sharma 2021-06-15 15:35 ` Mark Brown 2021-06-15 21:10 ` Bjorn Andersson 2021-06-15 7:45 ` [PATCH v2 07/10] pinctrl: qcom/pinctrl-spmi-gpio: Add compatible for pmic-gpio on SA8155p-adp Bhupesh Sharma 2021-06-15 21:07 ` Bjorn Andersson 2021-06-15 7:45 ` [PATCH v2 08/10] arm64: dts: qcom: pmm8155au_1: Add base dts file Bhupesh Sharma 2021-06-15 21:08 ` Bjorn Andersson 2021-06-15 7:45 ` [PATCH v2 09/10] arm64: dts: qcom: pmm8155au_2: " Bhupesh Sharma 2021-06-15 21:09 ` Bjorn Andersson 2021-06-15 7:45 ` [PATCH v2 10/10] arm64: dts: qcom: sa8155p-adp: " Bhupesh Sharma 2021-06-15 14:53 ` Konrad Dybcio 2021-06-15 17:00 ` Bhupesh Sharma [this message] 2021-06-15 21:13 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAH=2NtzOzA9HmxFUUuhX9Vy=KW3iRSx5HiuD9Cf11v+eijEWsQ@mail.gmail.com' \ --to=bhupesh.sharma@linaro.org \ --cc=agross@kernel.org \ --cc=bhupesh.linux@gmail.com \ --cc=bjorn.andersson@linaro.org \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=konrad.dybcio@somainline.org \ --cc=lgirdwood@gmail.com \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-gpio@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=vkoul@kernel.org \ --subject='Re: [PATCH v2 10/10] arm64: dts: qcom: sa8155p-adp: Add base dts file' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).