From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 42365C3A59B for ; Fri, 30 Aug 2019 16:40:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 190E52343B for ; Fri, 30 Aug 2019 16:40:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Az1Gi5Tn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728057AbfH3Qkh (ORCPT ); Fri, 30 Aug 2019 12:40:37 -0400 Received: from mail-vs1-f66.google.com ([209.85.217.66]:33641 "EHLO mail-vs1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728213AbfH3Qkh (ORCPT ); Fri, 30 Aug 2019 12:40:37 -0400 Received: by mail-vs1-f66.google.com with SMTP id m18so5179678vsr.0 for ; Fri, 30 Aug 2019 09:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FFEm8wnPyI70hvEmm2P3x6q7Jm7rJLu+QxiBEYWlIyU=; b=Az1Gi5TnAI4hFvybyYWbK+kY5uHpzIYo+o2d4fFMkAR8JxEWt1+SHjs8JUveORST6i Gd64ynQza92S8iVFSgaTo8l3iE4CvAdDU2coF4oOsqwwJfBiYQJKYwbUX8LujJTsiWTN wi/cOSOreMTOdb7b3mAoHJSXPGD6fzpyWxLIT329lNx6TGkuBvPre2rtLkRs/tnbRsd1 +yM5KS/siWcWBOs/K2sslc+UzXBGW+Zc0vw3iaR0/r09ZilQiD9lJiKOkOw3ErAyZMNg K/AIETEuQOm1nWHlRnf0RDYI2pN+ijMN3IZ8pd95grX2lJr0DFw7Bg6DqEyWjwEnWykb pryQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FFEm8wnPyI70hvEmm2P3x6q7Jm7rJLu+QxiBEYWlIyU=; b=UP0iU9GChyzRsudYW5t1zkhpjJVSUdPMwYp0fOeJCgIp1b5R2qMxMnybL/wdcHAdQZ 2r8yvLHPUva9KboAp7WsIGOQzf6sKUJkkoZjzOxGrvvWSnKyxY5UK2niIec2qHVEERto LzcnExjjMO4MqxoIZ62sHWmLRIsOl9h54mjRP4GSXn2QuUe1EMs/ndkDQ5tc+tostnDp O317lYMDdRnlqtNPVcBsZ8uJAkhvsGK4sMFdlV0wIjNykeiBqeitEXo5pOd8QkgQNqnc lUi/U3odm0B9CChfAFdtZR+OmZSKHb+UZdiKcQM3NXBlBlebY3YFhJVbLVhTiVAACdS3 P90w== X-Gm-Message-State: APjAAAXWQNnF1pZjcNomStXZ6vtIfYsOaXKFiMCF11RN8SWQishmUcbe Pgv0Let6IJgs9hvTkqoe06dU3K2EkgzdneBYlqA3uQ== X-Google-Smtp-Source: APXvYqxSX6rgglBoPn04e5TToAhGtd/FXdxa1G/PbV8Cm/B9SvCHsyiX8a3uGPV5I0xaid3Rv899mDqEZOJRM5dDNMs= X-Received: by 2002:a67:b445:: with SMTP id c5mr4384433vsm.182.1567183236380; Fri, 30 Aug 2019 09:40:36 -0700 (PDT) MIME-Version: 1.0 References: <66ac3d3707d6296ef85bf1fa321f7f1ee0c02131.1566907161.git.amit.kucheria@linaro.org> <5d65cbe9.1c69fb81.1ceb.2374@mx.google.com> <5d67e6cf.1c69fb81.5aec9.3b71@mx.google.com> <5d6946fa.1c69fb81.44ab7.8d72@mx.google.com> In-Reply-To: <5d6946fa.1c69fb81.44ab7.8d72@mx.google.com> From: Amit Kucheria Date: Fri, 30 Aug 2019 22:10:24 +0530 Message-ID: Subject: Re: [PATCH v2 07/15] dt: thermal: tsens: Document interrupt support in tsens driver To: Stephen Boyd Cc: Daniel Lezcano , Mark Rutland , Rob Herring , Zhang Rui , Andy Gross , Bjorn Andersson , Eduardo Valentin , linux-arm-msm , Linux Kernel Mailing List , Marc Gonzalez , Brian Masney , Linux PM list , DTML Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Aug 30, 2019 at 9:25 PM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-08-30 04:32:54) > > On Thu, Aug 29, 2019 at 10:04 PM Amit Kucheria wrote: > > > > > > On Thu, Aug 29, 2019 at 8:23 PM Stephen Boyd wrote: > > > > > > > > Can we get a known quantity of interrupts for a particular compatible > > > > string instead? Let's be as specific as possible. The index matters too, > > > > so please list them in the order that is desired. > > > > > > I *think* we can predict what platforms have uplow and critical > > > interrupts based on IP version currently[1]. For newer interrupt > > > types, we might need more fine-grained platform compatibles. > > > > > > [1] Caveat: this is based only on the list of platforms I've currently > > > looked at, there might be something internally that breaks these > > > rules. > > > > What do you think if we changed the wording to something like the following, > > > > - interrupt-names: Must be one of the following depending on IP version: > > For compatibles qcom,msm8916-tsens, qcom,msm8974-tsens, > > qcom,qcs404-tsens, qcom,tsens-v1, use > > interrupt-names = "uplow"; > > For compatibles qcom,msm8996-tsens, qcom,msm8998-tsens, > > qcom,sdm845-tsens, qcom,tsens-v2, use > > interrupt-names = "uplow", "critical"; > > Ok. I would still prefer YAML/JSON schema for this binding so that it's > much more explicit about numbers and the order of interrupts, etc. OK, I'll look around for some examples.