From: Amit Kucheria <amit.kucheria@linaro.org>
To: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Stephen Boyd <swboyd@chromium.org>,
sivaa@codeaurora.org, Andy Gross <agross@kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v4 4/7] drivers: thermal: tsens: Add critical interrupt support
Date: Tue, 18 Feb 2020 23:38:43 +0530 [thread overview]
Message-ID: <CAHLCerNi2kb-bU_xsmB4aGLtUKPXfUrqDMLJLU=XXTnk-Kk=+A@mail.gmail.com> (raw)
In-Reply-To: <20200203181413.GF3948@builder>
On Mon, Feb 3, 2020 at 11:44 PM Bjorn Andersson
<bjorn.andersson@linaro.org> wrote:
>
> On Thu 30 Jan 05:27 PST 2020, Amit Kucheria wrote:
>
> > TSENS IP v2.x adds critical threshold interrupt support for each sensor
> > in addition to the upper/lower threshold interrupt. Add support in the
> > driver.
> >
> > While the critical interrupts themselves aren't currently used by Linux,
> > the HW line is also used by the TSENS watchdog. So this patch acts as
> > infrastructure to enable watchdog functionality for the TSENS IP.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > ---
>
> Please do provide a changelog when respinning your patches.
>
> > drivers/thermal/qcom/tsens-common.c | 120 ++++++++++++++++++++++++++--
> > drivers/thermal/qcom/tsens-v2.c | 8 +-
> > drivers/thermal/qcom/tsens.c | 24 +++++-
> > drivers/thermal/qcom/tsens.h | 71 ++++++++++++++++
> > 4 files changed, 212 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> [..]
> > +irqreturn_t tsens_critical_irq_thread(int irq, void *data)
> > +{
> > + struct tsens_priv *priv = data;
> > + struct tsens_irq_data d;
> > + unsigned long flags;
> > + int temp, ret, i;
> > +
> > + for (i = 0; i < priv->num_sensors; i++) {
> > + const struct tsens_sensor *s = &priv->sensor[i];
> > + u32 hw_id = s->hw_id;
> > +
> > + if (IS_ERR(s->tzd))
> > + continue;
> > + if (!tsens_threshold_violated(priv, hw_id, &d))
> > + continue;
> > + ret = get_temp_tsens_valid(s, &temp);
> > + if (ret) {
> > + dev_err(priv->dev, "[%u] %s: error reading sensor\n", hw_id, __func__);
> > + continue;
> > + }
> > +
> > + spin_lock_irqsave(&priv->crit_lock, flags);
> > +
>
> I see that I failed to follow up on the discussion on the previous
> revision. The handler is called from a single thread, so you don't need
> a lock to protect the irq handler from itself.
Makes sense now. Will fix.
Thanks for the review.
Regards,
Amit
next prev parent reply other threads:[~2020-02-18 18:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-30 13:27 [PATCH v4 0/7] thermal: tsens: Handle critical interrupts Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 1/7] drivers: thermal: tsens: Pass around struct tsens_sensor as a constant Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 2/7] drivers: thermal: tsens: use simpler variables Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 3/7] drivers: thermal: tsens: Release device in success path Amit Kucheria
2020-02-03 18:05 ` Bjorn Andersson
2020-01-30 13:27 ` [PATCH v4 4/7] drivers: thermal: tsens: Add critical interrupt support Amit Kucheria
2020-02-03 18:14 ` Bjorn Andersson
2020-02-18 18:08 ` Amit Kucheria [this message]
2020-01-30 13:27 ` [PATCH v4 5/7] drivers: thermal: tsens: Add watchdog support Amit Kucheria
2020-02-03 18:42 ` Bjorn Andersson
2020-02-18 18:08 ` Amit Kucheria
2020-01-30 13:27 ` [PATCH v4 6/7] drivers: thermal: tsens: kernel-doc fixup Amit Kucheria
2020-02-03 18:43 ` Bjorn Andersson
2020-01-30 13:27 ` [PATCH v4 7/7] drivers: thermal: tsens: Remove unnecessary irq flag Amit Kucheria
2020-02-03 18:44 ` Bjorn Andersson
2020-02-17 15:25 ` [PATCH v4 0/7] thermal: tsens: Handle critical interrupts Daniel Lezcano
2020-02-18 5:36 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHLCerNi2kb-bU_xsmB4aGLtUKPXfUrqDMLJLU=XXTnk-Kk=+A@mail.gmail.com' \
--to=amit.kucheria@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sivaa@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).