From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE04DC3F2D1 for ; Thu, 5 Mar 2020 15:43:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC77E2073D for ; Thu, 5 Mar 2020 15:43:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="lKqr2+6Y" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726007AbgCEPn2 (ORCPT ); Thu, 5 Mar 2020 10:43:28 -0500 Received: from mail-ua1-f65.google.com ([209.85.222.65]:33569 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726822AbgCEPn2 (ORCPT ); Thu, 5 Mar 2020 10:43:28 -0500 Received: by mail-ua1-f65.google.com with SMTP id 94so2232394uat.0 for ; Thu, 05 Mar 2020 07:43:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BtkP4rjLPJJ3tMCB0I86aLFGaPPlP5RT1g3Fl+k0ezY=; b=lKqr2+6Y70nMAQIyJl5JRc7tIiLa+hzIz7tEvf/tovFCfmf+e7RuHwdMVi4tryYNTD +pymGTN4XbCQi1CQ2PWP9jPf1sDURpvJEBqC59VhPJF1ZTtb8ifBnbcHDu7/o3b8UX+/ BupJMhndJtlKuYaGJ/ZOifRB1mOciw3bd+8KEN2jkk5w0PbDET9x7GDPdVZcHA4HMCSU DIrYETeAQerh3c1CrVA3ipFhiuj7XLqCfmLKdZLc/gC2IxdYCTgy6CmtM3Qa7kLf6ltZ yiKe1i/cC5h5GYiBTHxi3IJSLiLC9sGHsOuncMXK3UHEnqsauLAX3vSUQXR1vMznxLBR Q4YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BtkP4rjLPJJ3tMCB0I86aLFGaPPlP5RT1g3Fl+k0ezY=; b=phVhc3eojdTiDHWWePx7v1P/VbAWjPaAhl0Itplnx/HCKlB9vzaalOgKX+Jwz0mOS7 MfCeBFp+jjSEr2oWlBMUmLWPvYClFzs6xvd88vbmhslSlnokLoNCrVqhFRPaZG0fGm8C MWIX4nJQwpm0pdVZJS1Xm2vQF2/kbAmW81K9nyKcIALu03aKgk8JBqeGKEDYo4WtI5Qh DIR4ec8/fogIumuKAO8YsXWp9u4euh17PfLn0+nvP1nCsoIJ7Bpt5yp3TQ/MdkX3P84l o3UJGQrsxTVrnGoxc58PJTeCbxSI1ZyGBeWjbuSbK57vWAG/L0hJmradmsZh6+Z7EEAG 7Qqg== X-Gm-Message-State: ANhLgQ0HI17aWzr7vEVp/bJyMDMy1cZGTAWJXfhKIlpmAWs/Jh2m3Bxt zTNa95NZEKgji42oa8QQXYa9c2f9aGpspvO/uDm+kg== X-Google-Smtp-Source: ADFU+vtnAS2M6fsz0X4CPT/qujFk6wJUPdYM8Pmr5JuuT0heSqdLkpUK6njwODFUJ11mFbZK5GofJhtZiCjNvuUC940= X-Received: by 2002:ab0:7518:: with SMTP id m24mr4824318uap.60.1583423006775; Thu, 05 Mar 2020 07:43:26 -0800 (PST) MIME-Version: 1.0 References: <59d24f8ec98e29d119c5cbdb2abe6d4644cc51cf.1582528977.git.amit.kucheria@linaro.org> <20200224184003.GA3607@bogus> In-Reply-To: From: Amit Kucheria Date: Thu, 5 Mar 2020 21:13:15 +0530 Message-ID: Subject: Re: [RFC PATCH v1 3/3] dt-bindings: thermal: Add yaml bindings for thermal zones To: Rob Herring Cc: LKML , linux-arm-msm , Stephen Boyd , Matthias Kaehlcke , Daniel Lezcano , Zhang Rui , Linux PM list , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Mar 5, 2020 at 9:08 PM Rob Herring wrote: > > On Thu, Mar 5, 2020 at 6:50 AM Amit Kucheria wrote: > > > > On Tue, Feb 25, 2020 at 12:10 AM Rob Herring wrote: > > > > > > On Mon, 24 Feb 2020 12:55:37 +0530, Amit Kucheria wrote: > > > > As part of moving the thermal bindings to YAML, split it up into 3 > > > > bindings: thermal sensors, cooling devices and thermal zones. > > > > > > > > The thermal-zone binding is a software abstraction to capture the > > > > properties of each zone - how often they should be checked, the > > > > temperature thresholds (trips) at which mitigation actions need to be > > > > taken and the level of mitigation needed at those thresholds. > > > > > > > > Signed-off-by: Amit Kucheria > > > > --- > > > > .../bindings/thermal/thermal-zones.yaml | 302 ++++++++++++++++++ > > > > 1 file changed, 302 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/thermal/thermal-zones.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > Documentation/devicetree/bindings/display/simple-framebuffer.example.dts:21.16-37.11: Warning (chosen_node_is_root): /example-0/chosen: chosen node must be at root node > > > > This one isn't due to my patch, I believe. > > Right, that's the one known warning... > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c263000: interrupt-names: ['uplow'] is too short > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c263000: interrupts: [[0, 506, 4]] is too short > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c265000: interrupt-names: ['uplow'] is too short > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml: thermal-sensor@c265000: interrupts: [[0, 507, 4]] is too short > > > > Fixed. Just for my information, did the check somehow figure out that > > this (incomplete) example needed the qcom-tsens.yaml binding (based on > > compatible string?) and then apply those rules to throw this error? > > Yes. And setting DT_SCHEMA_FILES did change that to only check with > the specified schema file. However, that's now changed in linux-next > such that examples are always checked by all schemas and > DT_SCHEMA_FILES just limits which bindings to build and check. DT_SCHEMA_FILES doesn't seem to take wildcards. Individual yaml files worked fine. $ make -k -j`nproc` ARCH=arm64 CROSS_COMPILE="ccache aarch64-linux-gnu-" O=~/work/builds/build-aarch64/ dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/thermal/thermal*.yaml make[1]: Entering directory '/home/amit/work/builds/build-aarch64' make[2]: Circular Documentation/devicetree/bindings/processed-schema.yaml <- Documentation/devicetree/bindings/thermal/thermal-sensor.example.dt.yaml dependency dropped. make[2]: Circular Documentation/devicetree/bindings/thermal/thermal-zones.example.dt.yaml <- Documentation/devicetree/bindings/processed-schema.yaml dependency dropped. make[2]: Circular Documentation/devicetree/bindings/thermal/thermal-cooling-devices.example.dt.yaml <- Documentation/devicetree/bindings/processed-schema.yaml dependency dropped. SCHEMA Documentation/devicetree/bindings/processed-schema.yaml Traceback (most recent call last): File "/home/amit/.local/bin/dt-mk-schema", line 7, in exec(compile(f.read(), __file__, 'exec')) File "/home/amit/work/sources/tools-dt-schema.git/tools/dt-mk-schema", line 32, in schemas = dtschema.process_schemas(args.schemas, core_schema=(not args.useronly)) File "/home/amit/work/sources/tools-dt-schema.git/dtschema/lib.py", line 475, in process_schemas sch = process_schema(os.path.abspath(filename)) File "/home/amit/work/sources/tools-dt-schema.git/dtschema/lib.py", line 435, in process_schema DTValidator.check_schema(schema) File "/home/amit/work/sources/tools-dt-schema.git/dtschema/lib.py", line 582, in check_schema meta_schema = cls.resolver.resolve_from_url(schema['$schema']) TypeError: list indices must be integers or slices, not str make[2]: *** [/home/amit/work/sources/linux-amit.git/Documentation/devicetree/bindings/Makefile:34: Documentation/devicetree/bindings/processed-schema.yaml] Error 1 make[2]: Target '__build' not remade because of errors. make[1]: *** [/home/amit/work/sources/linux-amit.git/Makefile:1262: dt_binding_check] Error 2 make[1]: Leaving directory '/home/amit/work/builds/build-aarch64' make: *** [Makefile:179: sub-make] Error 2 make: Target 'dt_binding_check' not remade because of errors.