From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEC3AC04AAF for ; Thu, 16 May 2019 11:54:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AF32520645 for ; Thu, 16 May 2019 11:54:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="v26qoU6H" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727272AbfEPLy6 (ORCPT ); Thu, 16 May 2019 07:54:58 -0400 Received: from mail-vk1-f195.google.com ([209.85.221.195]:37537 "EHLO mail-vk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726723AbfEPLy5 (ORCPT ); Thu, 16 May 2019 07:54:57 -0400 Received: by mail-vk1-f195.google.com with SMTP id o187so937941vkg.4 for ; Thu, 16 May 2019 04:54:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gw9Ghc+xQrqh42btkF+tSwScblo1M5MvWvdVH4TT7i0=; b=v26qoU6H8L1eKcYMoea7paIcbwqKfFyFfh4g29/LlGR6+AUpIUNU3bNE8s3wyNQJKd kQCGJb9CAIQ2AgFYlk0SLoUn4HsoNoh0eNBdhek1FO+tVLDcJ5NcdPQjy6BRdvLxlaQK 0aIlSfSssyMkTz7GipBksDjARihKegYcNTAz8t5xd/SHkEavzcNuZ/+vIVV1I/nndpea MP06okMhU0f1Athz5O6dl7kceRU43aFcm0qDLB0uMM12eSEiS6XTppcIe0Y4FZn/2rV1 GuoBk8CKXPPLoHvogkLGbVn8coLEnYox/LkyrDuG7ZQXRrykgKDd2NWvR7GV7av2PyfU /tCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gw9Ghc+xQrqh42btkF+tSwScblo1M5MvWvdVH4TT7i0=; b=rR3OfRJAnh50JtGi1kikfdLjmsVXQKR1xWoPNZka/8wyB5l5+ihUlFwgCvQufuk0VW KYZ2CWydRUGJMtjLTBLlTKOJsAJfTM35dT7g5Hy4OL0Mv7mWuN20IW8LKkFNQweaAr/e bFjPSmhrkk0DJufIARTyaH8UNrcnkHBTibZF97rucJFZMVVA0/ssdarGDhk9vJsR9qon wCOv8MplmZW79Bc+PvjVCM5rAMGwhWEs8lNSbq6FJ4fP+x9fok9EVfatSnqji+2cAX1c VVBsadCVYub6PifVJVYBSD4erkn5IoBKj1Au2mB9eOR6KAE+8CI3QmJ6aYUlAx6OGKVr cwOg== X-Gm-Message-State: APjAAAWZen1cIp88j+Qh2xzQ5qDMUzkeonfI9lVBUh44n6wVa24ReKsU 6dW54zuCru41u63EgRpNIqzSup922sak+xt169ZxmQ== X-Google-Smtp-Source: APXvYqy+0i0NCLJY9mu7r+K0u56+d0TTe1O6WRw/Ai9J8XZgwGaPKyF4TLUj8e80gKzDj9M2oxm9yBWBX3AdrhjAKaY= X-Received: by 2002:a1f:812:: with SMTP id 18mr22833450vki.68.1558007696693; Thu, 16 May 2019 04:54:56 -0700 (PDT) MIME-Version: 1.0 References: <20190114184255.258318-1-mka@chromium.org> <155786856719.14659.2902538189660269078@swboyd.mtv.corp.google.com> In-Reply-To: <155786856719.14659.2902538189660269078@swboyd.mtv.corp.google.com> From: Amit Kucheria Date: Thu, 16 May 2019 17:24:45 +0530 Message-ID: Subject: Re: [PATCH] arm64: dts: sdm845: Add CPU topology To: Stephen Boyd , Andy Gross Cc: Matthias Kaehlcke , David Brown , Rob Herring , Mark Rutland , linux-arm-msm , "open list:ARM/QUALCOMM SUPPORT" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , LKML , Douglas Anderson , Rajendra Nayak Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org (cc'ing Andy's correct email address) On Wed, May 15, 2019 at 2:46 AM Stephen Boyd wrote: > > Quoting Amit Kucheria (2019-05-13 04:54:12) > > On Mon, May 13, 2019 at 4:31 PM Amit Kucheria wrote: > > > > > > On Tue, Jan 15, 2019 at 12:13 AM Matthias Kaehlcke wrote: > > > > > > > > The 8 CPU cores of the SDM845 are organized in two clusters of 4 big > > > > ("gold") and 4 little ("silver") cores. Add a cpu-map node to the DT > > > > that describes this topology. > > > > > > This is partly true. There are two groups of gold and silver cores, > > > but AFAICT they are in a single cluster, not two separate ones. SDM845 > > > is one of the early examples of ARM's Dynamiq architecture. > > > > > > > Signed-off-by: Matthias Kaehlcke > > > > > > I noticed that this patch sneaked through for this merge window but > > > perhaps we can whip up a quick fix for -rc2? > > > > > > > And please find attached a patch to fix this up. Andy, since this > > hasn't landed yet (can we still squash this into the original patch?), > > I couldn't add a Fixes tag. > > > > I had the same concern. Thanks for catching this. I suspect this must > cause some problem for IPA given that it can't discern between the big > and little "power clusters"? Both EAS and IPA, I believe. It influences the scheduler's view of the the topology. > Either way, > > Reviewed-by: Stephen Boyd Thanks. Andy/Bjorn, can we squeeze this in for -rc2 as a bugfix? Regards, Amit