From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 80982C7EE2A for ; Thu, 1 Jun 2023 08:42:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231895AbjFAImv (ORCPT ); Thu, 1 Jun 2023 04:42:51 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47388 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231694AbjFAImu (ORCPT ); Thu, 1 Jun 2023 04:42:50 -0400 Received: from mail-qt1-x836.google.com (mail-qt1-x836.google.com [IPv6:2607:f8b0:4864:20::836]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DE19FB for ; Thu, 1 Jun 2023 01:42:46 -0700 (PDT) Received: by mail-qt1-x836.google.com with SMTP id d75a77b69052e-3f767eec104so4937481cf.1 for ; Thu, 01 Jun 2023 01:42:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nexus-software-ie.20221208.gappssmtp.com; s=20221208; t=1685608965; x=1688200965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=mOHClv3EmZ5BC3wC17xcl4hTpc6sk/oBTzMD5jV9A1U=; b=T+fEJ8MlR4KHrrWHZaVkuXopdtCLepCVfBAECMwZjmqdNEwNC6Bgag4lvkdnJttjqG kvPSAHJclDqCmk2FjFHQ8uyCRrJL2PaHeluGbzlQRi2NqgfZZVRdL0GQ0LwzKQ3jHmnZ v/AFlGwYnGklHBhYx7Fn/2CeFAkzTYucPr/j3zZXXc3msN9KyfKR3n1sZN09ALFhkdW8 dVL8TVf7xu9Nohbt/DNVjnHEaW1Ys4IYv5QQBOnhZZBb/KSkKorVUDMf6CjnuKulVZvP cF7QiDngi14DRKbYW9qE4Ls9dcr33RkZHy8U8iT+bt0YF+2buWVR7Vqv3UeL86eGGN3M B2KA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685608965; x=1688200965; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mOHClv3EmZ5BC3wC17xcl4hTpc6sk/oBTzMD5jV9A1U=; b=N/G5xHVxHSjS0bEosXhuNWfm5aXW9NLTvoa9PVQSHl4BRZxQtm0bIErvu3WKNsOLxB BxJBl8PKrb4PkRZtGV3LGiKR6apPl9nGZxeW4H73+LzEP3IixAqjaPfVWJMlktyL1DVN xdavjC53KC+lsjw+Ee3OWs5QLDSTi0hAMh4q3owG5eLla/yh8Wqm047Mdi0sdf/Y51jg 5Ta7M5zKiZOIXp0GAVittlE/CsbfJqIEA7cKTQNwrzoo4rCG6Rut6wpT1wkgVHL7uDEG OJMsglQuSz0e/TYBSgm4lQz9pMQycy+ca7hLcb5qHunx41bgzrSFM1gnPuhoT+W45w9i /G7A== X-Gm-Message-State: AC+VfDxeklH/0lVIza7oaX/r9zFq+tdMLMDoIfG/4j8d5bnSVngYUQEJ N8+GGozX65A0DRHLBj6QTmIIKs1Xn92gbPLcl53TIw== X-Google-Smtp-Source: ACHHUZ64B9aPj3MnaxAoV1VqJcmNXpqutdESG4B/ynheLTITdb7rBWLgFOJzuXb75zVf3DoZRlJQepZrwBTnxNF+Mtc= X-Received: by 2002:a05:622a:58a:b0:3f6:b151:7db1 with SMTP id c10-20020a05622a058a00b003f6b1517db1mr9299207qtb.62.1685608965598; Thu, 01 Jun 2023 01:42:45 -0700 (PDT) MIME-Version: 1.0 References: <20230531-topic-8998_mmssclk-v1-0-2b5a8fc90991@linaro.org> <20230531-topic-8998_mmssclk-v1-1-2b5a8fc90991@linaro.org> In-Reply-To: <20230531-topic-8998_mmssclk-v1-1-2b5a8fc90991@linaro.org> From: "Bryan O'Donoghue" Date: Thu, 1 Jun 2023 10:42:33 +0200 Message-ID: Subject: Re: [PATCH 1/4] arm64: dts: qcom: msm8998: Properly describe MMSS SMMU To: Konrad Dybcio Cc: Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Conor Dooley , AngeloGioacchino Del Regno , Michael Turquette , Stephen Boyd , Jeffrey Hugo , Imran Khan , Rajendra Nayak , Joonwoo Park , Jeffrey Hugo , Marijn Suijten , Dmitry Baryshkov , Jami Kettunen , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, May 31, 2023 at 11:01=E2=80=AFAM Konrad Dybcio wrote: > > The MMSS SMMU has been abusingly consuming the exposed RPM interconnect > clock and not describing the power domain it needs. Put an end to that. > > Fixes: 05ce21b54423 ("arm64: dts: qcom: msm8998: Configure the multimedia= subsystem iommu") > Signed-off-by: Konrad Dybcio > --- > arch/arm64/boot/dts/qcom/msm8998.dtsi | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/msm8998.dtsi b/arch/arm64/boot/dts/= qcom/msm8998.dtsi > index f0e943ff0046..a4016085b750 100644 > --- a/arch/arm64/boot/dts/qcom/msm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8998.dtsi > @@ -2737,10 +2737,10 @@ mmss_smmu: iommu@cd00000 { > > clocks =3D <&mmcc MNOC_AHB_CLK>, > <&mmcc BIMC_SMMU_AHB_CLK>, > - <&rpmcc RPM_SMD_MMAXI_CLK>, > <&mmcc BIMC_SMMU_AXI_CLK>; > - clock-names =3D "iface-mm", "iface-smmu", > - "bus-mm", "bus-smmu"; > + clock-names =3D "iface-mm", > + "iface-smmu", > + "bus-smmu"; > > #global-interrupts =3D <0>; > interrupts =3D > @@ -2764,6 +2764,8 @@ mmss_smmu: iommu@cd00000 { > , > , > ; > + > + power-domains =3D <&mmcc BIMC_SMMU_GDSC>; > }; > > remoteproc_adsp: remoteproc@17300000 { > > -- > 2.40.1 > I think you should split this up. This should be two patches. One to describe the power-domain and another for the removal of interconnect clocks. I guess none of the multi-media connected stuff on 8998 works ... no venus, mdp, camera - which would surely fail without the multi-media AXI clock being on.. Anyway please split this patch up !