From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EDBCC433FE for ; Mon, 27 Sep 2021 20:16:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 397DB6113A for ; Mon, 27 Sep 2021 20:16:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236937AbhI0URm (ORCPT ); Mon, 27 Sep 2021 16:17:42 -0400 Received: from mail.kernel.org ([198.145.29.99]:35706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236763AbhI0URl (ORCPT ); Mon, 27 Sep 2021 16:17:41 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 46BD5611C3; Mon, 27 Sep 2021 20:16:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1632773763; bh=Lb3LIgfAEjVXdf1vE2V7OoMMbogeWMravjEabJ1Nxyg=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=aoqynUkGyB6ZPUI0PZbhRVWrRQEh4dUFl+HnGRbJEjz36swl07OI+waO5juXrxZEL jHlAKLJtp7vLEn53dGPq9ybdvqoV7skp3bnJ2v0dt7b3LCLaWszZoJwfgXGV5CewIZ EeT9Puax/p5vO3xFfjNQpP/s5z+vV6IucH/tDVc9OrhV9apJ4xfqmWfbZVQ6mT6zds T7V/1iyHvtmaHFbCozBGLs87R9buQKkqhGe1GFJbwuhVxRAw/14pw6aQABaZ9IXQ/3 OdqLZFHV5ZJBQxWkAwNJ0thZGMxGk74lNv+sDueBnQKqvqp7vbKRWok7c77AtHcBAs PL2/kpsfVk1jA== Received: by mail-wr1-f53.google.com with SMTP id g16so54027899wrb.3; Mon, 27 Sep 2021 13:16:03 -0700 (PDT) X-Gm-Message-State: AOAM533A9Dlo5xlQ9wTe8lwQ5Rw/y18zWiNA8hEYg0fKcAx9F0YYwwjL WQIZl1vHv7uaSF3bXhgVCcdRMt2ZOCzYk9VWg9E= X-Google-Smtp-Source: ABdhPJxhSUG+xfsMcnYBJG/aU9zQ/jW83Rbf6e2ezlqzSM1qdDuC1ur8sa8pPTTU3lbMghJJfkyUaLecI/p3sCcMSis= X-Received: by 2002:a5d:6cb4:: with SMTP id a20mr1431020wra.428.1632773761805; Mon, 27 Sep 2021 13:16:01 -0700 (PDT) MIME-Version: 1.0 References: <20210927152412.2900928-1-arnd@kernel.org> In-Reply-To: From: Arnd Bergmann Date: Mon, 27 Sep 2021 22:15:45 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] [RFC] qcom_scm: hide Kconfig symbol To: Bjorn Andersson Cc: John Stultz , Arnd Bergmann , Rob Clark , Sean Paul , David Airlie , Daniel Vetter , Joerg Roedel , Will Deacon , Mauro Carvalho Chehab , Ulf Hansson , Alex Elder , "David S. Miller" , Jakub Kicinski , Kalle Valo , Andy Gross , Linus Walleij , Maxime Ripard , Chen-Yu Tsai , Jernej Skrabec , Mark Rutland , Lorenzo Pieralisi , Sudeep Holla , Linux Kernel Mailing List , linux-arm-msm , dri-devel , freedreno , "open list:IOMMU DRIVERS" , Linux Media Mailing List , linux-mmc , Networking , ath10k@lists.infradead.org, linux-wireless , "open list:GPIO SUBSYSTEM" , Linux ARM , linux-sunxi@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Sep 27, 2021 at 9:52 PM Bjorn Andersson wrote: > On Mon 27 Sep 08:22 PDT 2021, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > - To avoid a circular dependency chain involving RESET_CONTROLLER > > and PINCTRL_SUNXI, change the 'depends on RESET_CONTROLLER' in > > the latter one to 'select'. > > Can you please help me understand why this is part of the same patch? This can be done as a preparatory patch if we decide to do it this way, for the review it seemed better to spell out that this is required. I still hope that we can avoid adding another 'select RESET_CONTROLLER' if someone can figure out what to do instead. The problem here is that QCOM_SCM selects RESET_CONTROLLER, and turning that into 'depends on' would in turn mean that any driver that wants to select QCOM_SCM would have to have the same RESET_CONTROLLER dependency. An easier option might be to find a way to build QCOM_SCM without RESET_CONTROLLER for compile testing purposes. I don't know what would break from that. Arnd