From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7E938C3F2C6 for ; Wed, 11 Mar 2020 08:27:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 56EFC20866 for ; Wed, 11 Mar 2020 08:27:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="J2DX4Bve" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728554AbgCKI1L (ORCPT ); Wed, 11 Mar 2020 04:27:11 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:41418 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728555AbgCKI1L (ORCPT ); Wed, 11 Mar 2020 04:27:11 -0400 Received: by mail-lj1-f196.google.com with SMTP id o10so1278361ljc.8 for ; Wed, 11 Mar 2020 01:27:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NWQU7YCcR/s5BfakGwEM5MbP1hNswxlqWffpTanXogY=; b=J2DX4Bveq98DNDNLQytIzyqNO5U/1AlZAea10CrmXpFd7AVX90yX5Tdtt+c1ZwmWBZ fnvYHqNq/BJufaeH84JB+sQjUiXLFXeaTifVEvrmHuiDonL/w9rW4NDoo9gCju2Dl/uo 92ROgYAY+nNd2sqIH4YekmH8HwlZ6JuBBRQsWxmOiiilOB9ivaFB5mgwNHFSOq6GqvmG XYAEumikhY4sYyW8zmTqNh2JpUimiMOYo4K1+CWkHjkpq5kQobVPWERlz52TuW7OzqND D5qGNapWdFpE4kihUbV51Sbe3VJveaBctzaZgQREo6+0ZclVJVf1bdwNSMkGk2rPCgpc fFEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NWQU7YCcR/s5BfakGwEM5MbP1hNswxlqWffpTanXogY=; b=RQC0pg38g67rk+/9KLMBbimKX4zGkNTnhfHDZrTyu7al8/AoO3f4cxXWnXikVefXHx 8uWd+/FBBg7CGfr0hDSArA7uo+nOObtvmLRh82w4FmHoDLY9+9CqSIoucmh7CqPVTb6j Hp0r10BqPkyK8h7+k7X5XR784n+wC5Hq/y8kUhg4oHHSLH5mOAIHbY8MyIHfYkRW4e0Q LbvCfoY4qgR3Q+N+8Pot2lriZrAdQzVkM2sY1pGMjccSqJSezkkn5w7bvLMyDBN30pUP YmNbLWSMihM+N6KZXqmgpHXGmJV9uHb9aQonc8WrfNVb9BLZXCgCCcepcLlK3FXnQ1gj 7vcw== X-Gm-Message-State: ANhLgQ3nPGkmKkqX0TGn94u+/Kw+/Xe/U4r03mVrfno7mOww0JfRmCHS aeYwGAglxbyW05XG8sHl0di7n4TCwBBt9dmLVcYfJg== X-Google-Smtp-Source: ADFU+vvaBLQx0v3t5e1U81RlRAcTudqkB2UQUvNAnj10TA+zBwZty+uumu0htJHaLHRRaMeDZa+YsS6rF0AAu8Ma6cs= X-Received: by 2002:a2e:a0cc:: with SMTP id f12mr1365444ljm.154.1583915228511; Wed, 11 Mar 2020 01:27:08 -0700 (PDT) MIME-Version: 1.0 References: <93466e6c031c0084de09bd6b448556a6c5080880.1583412540.git.amit.kucheria@linaro.org> In-Reply-To: <93466e6c031c0084de09bd6b448556a6c5080880.1583412540.git.amit.kucheria@linaro.org> From: Vincent Guittot Date: Wed, 11 Mar 2020 09:26:56 +0100 Message-ID: Subject: Re: [PATCH v2 1/3] dt-bindings: thermal: Add yaml bindings for thermal sensors To: Amit Kucheria Cc: linux-kernel , linux-arm-msm , Stephen Boyd , Matthias Kaehlcke , Daniel Lezcano , Amit Kucheria , Zhang Rui , "open list:THERMAL" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 5 Mar 2020 at 13:56, Amit Kucheria wrote: > > As part of moving the thermal bindings to YAML, split it up into 3 > bindings: thermal sensors, cooling devices and thermal zones. > > The property #thermal-sensor-cells is required in each device that acts > as a thermal sensor. It is used to uniquely identify the instance of the > thermal sensor inside the system. > > Signed-off-by: Amit Kucheria > --- > .../bindings/thermal/thermal-sensor.yaml | 72 +++++++++++++++++++ > 1 file changed, 72 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/thermal-sensor.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/thermal-sensor.yaml b/Documentation/devicetree/bindings/thermal/thermal-sensor.yaml > new file mode 100644 > index 0000000000000..920ee7667591d > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/thermal-sensor.yaml > @@ -0,0 +1,72 @@ > +# SPDX-License-Identifier: (GPL-2.0) > +# Copyright 2020 Linaro Ltd. > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/thermal-sensor.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Thermal sensor binding > + > +maintainers: > + - Amit Kucheria > + > +description: | > + Thermal management is achieved in devicetree by describing the sensor hardware > + and the software abstraction of thermal zones required to take appropriate > + action to mitigate thermal overloads. > + > + The following node types are used to completely describe a thermal management > + system in devicetree: > + - thermal-sensor: device that measures temperature, has SoC-specific bindings > + - cooling-device: device used to dissipate heat either passively or artively typo: s/artively/actively/ > + - thermal-zones: a container of the following node types used to describe all > + thermal data for the platform > + > + This binding describes the thermal-sensor. > + > + Thermal sensor devices provide temperature sensing capabilities on thermal > + zones. Typical devices are I2C ADC converters and bandgaps. Thermal sensor > + devices may control one or more internal sensors. > + > +properties: > + "#thermal-sensor-cells": > + description: > + Used to uniquely identify a thermal sensor instance within an IC. Will be > + 0 on sensor nodes with only a single sensor and at least 1 on nodes > + containing several internal sensors. > + enum: [0, 1] > + > +examples: > + - | > + #include > + > + // Example 1: SDM845 TSENS > + soc: soc@0 { > + #address-cells = <2>; > + #size-cells = <2>; > + > + /* ... */ > + > + tsens0: thermal-sensor@c263000 { > + compatible = "qcom,sdm845-tsens", "qcom,tsens-v2"; > + reg = <0 0x0c263000 0 0x1ff>, /* TM */ > + <0 0x0c222000 0 0x1ff>; /* SROT */ > + #qcom,sensors = <13>; > + interrupts = , > + ; > + interrupt-names = "uplow", "critical"; > + #thermal-sensor-cells = <1>; > + }; > + > + tsens1: thermal-sensor@c265000 { > + compatible = "qcom,sdm845-tsens", "qcom,tsens-v2"; > + reg = <0 0x0c265000 0 0x1ff>, /* TM */ > + <0 0x0c223000 0 0x1ff>; /* SROT */ > + #qcom,sensors = <8>; > + interrupts = , > + ; > + interrupt-names = "uplow", "critical"; > + #thermal-sensor-cells = <1>; > + }; > + }; > +... > -- > 2.20.1 >