From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE1E9C5519F for ; Tue, 17 Nov 2020 10:03:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 62B26222EC for ; Tue, 17 Nov 2020 10:03:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Zn2SMY+e" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727425AbgKQKDv (ORCPT ); Tue, 17 Nov 2020 05:03:51 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727353AbgKQKDu (ORCPT ); Tue, 17 Nov 2020 05:03:50 -0500 Received: from mail-il1-x142.google.com (mail-il1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 89172C0617A6 for ; Tue, 17 Nov 2020 02:03:50 -0800 (PST) Received: by mail-il1-x142.google.com with SMTP id l12so18056707ilo.1 for ; Tue, 17 Nov 2020 02:03:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DPHGLiORbaJbLxUM7+BhRXlMBVSZRTpOSLRe1ua1EJU=; b=Zn2SMY+essfbJPuhgilqqLmFJylQDR9RinMiH8a5O3JxvWKq3503dJmQxlV9cUvyN7 kRW3XmOMkiKgkrQ12XtFqBg1/28VixwRrmA5WLxPAWEohqQMZHeiCvG7p2lp7BKbSNnz mijKzcpj+gO/ZFU96WloUL3Tu6VXC4WlEyLVqSQPHWOIC0h+q0fON5KEKzmtuMTPPyNk 9pbgOxrBjcs5mIpiniS2rCZSSimk4v+hlJMW33vpPjMkLxmnnCTwqC7AVWloaQv1+GLo nDhhadH1doOxU6a2QA7hffRyqhuyg6A0zrnBwnMqDVtFzV4F7re2h7cVCcDMJPYTNli6 xwjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DPHGLiORbaJbLxUM7+BhRXlMBVSZRTpOSLRe1ua1EJU=; b=N1oLGInGn9h4rh3DFPQypv8yPXfNK3yQvo8ctKGCjo/KliuD67As4+gi3LCrsP+Mtz 1VEKbgkS7JHBguABTRhDlS4x6bW9eXxZAc3G1Wfu9G1xPLVZ4dY0xEaGL+bFZjqZpuBu 64F4pxzum9ce+ijIK2vtUfB+k6hfkw0dgWcCjgbqrecX0hx52EDPufENR6pJcBvdiAUq D7cc4sgKpnuoNHwRN0pzevDdGc0XG2dv7bbgM5KD78bIyGHAESasWWzq89KXbav4qpyN tfkpLCnPKn1Vo+jBnblI4MU+/1aGuagnAPuYwJfdToqpzpM3uXC8RS6uRUBvteKS+vR8 N7Tw== X-Gm-Message-State: AOAM530aLcYsX87Tm5oRKPARmXIDeVn4mZQA56F5z0TYcwAdPLkEg2nj AZnUkVkyF0wxgLhwKSoKr8Uoxa4lRSfgeQjxUDMJOA== X-Google-Smtp-Source: ABdhPJxpzE0hfqNEPElqTxkhKxnLGbU0Jc7DfYxYbIEhVnGR5svnoF49V7Yxf7pgQ7SOPd3w1CySAUjKJwnaY89p1O8= X-Received: by 2002:a92:ac02:: with SMTP id r2mr11518854ilh.31.1605607429892; Tue, 17 Nov 2020 02:03:49 -0800 (PST) MIME-Version: 1.0 References: <20201020112413.xbk2vow2kgjky3pb@vireshk-i7> <20201022080644.2ck4okrxygmkuatn@vireshk-i7> <20201027113532.nriqqws7gdcu5su6@vireshk-i7> <20201103054715.4l5j57pyjz6zd6ed@vireshk-i7> <20201104030353.ny7zvakgb4fsye6r@vireshk-i7> <20201106071621.j732gt4nqifjrccd@vireshk-i7> In-Reply-To: <20201106071621.j732gt4nqifjrccd@vireshk-i7> From: Viresh Kumar Date: Tue, 17 Nov 2020 15:33:38 +0530 Message-ID: Subject: Re: [PATCH v2 07/22] drm/msm: Do rpm get sooner in the submit path To: Rob Clark Cc: Daniel Vetter , dri-devel , Rob Clark , Sean Paul , David Airlie , "open list:DRM DRIVER FOR MSM ADRENO GPU" , "open list:DRM DRIVER FOR MSM ADRENO GPU" , open list , "Menon, Nishanth" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, 6 Nov 2020 at 12:46, Viresh Kumar wrote: > > On 05-11-20, 11:24, Rob Clark wrote: > > On Tue, Nov 3, 2020 at 7:04 PM Viresh Kumar wrote: > > > > > > On 03-11-20, 08:50, Rob Clark wrote: > > > > sorry, it didn't apply cleanly (which I guess is due to some other > > > > dependencies that need to be picked back to v5.4 product kernel), and > > > > due to some other things I'm in middle of debugging I didn't have time > > > > yet to switch to v5.10-rc or look at what else needs to > > > > cherry-picked.. > > > > > > > > If you could, pushing a branch with this patch somewhere would be a > > > > bit easier to work with (ie. fetch && cherry-pick is easier to deal > > > > with than picking things from list) > > > > > > It has been in linux-next for a few days. Here is the HEAD to pick > > > from. There are few patches there since rc1. > > > > > > commit 203e29749cc0 ("opp: Allocate the OPP table outside of opp_table_lock") > > > > > > > sorry for the delay, with that cherry-picked, I'm getting a whole lot of: > > Ahh, sorry about that and thanks for reporting it. Here is the fix: > > diff --git a/drivers/opp/of.c b/drivers/opp/of.c > index c718092757d9..6b7f0066942d 100644 > --- a/drivers/opp/of.c > +++ b/drivers/opp/of.c > @@ -112,8 +112,6 @@ static struct opp_table *_find_table_of_opp_np(struct device_node *opp_np) > struct opp_table *opp_table; > struct device_node *opp_table_np; > > - lockdep_assert_held(&opp_table_lock); > - > opp_table_np = of_get_parent(opp_np); > if (!opp_table_np) > goto err; > @@ -121,12 +119,15 @@ static struct opp_table *_find_table_of_opp_np(struct device_node *opp_np) > /* It is safe to put the node now as all we need now is its address */ > of_node_put(opp_table_np); > > + mutex_lock(&opp_table_lock); > list_for_each_entry(opp_table, &opp_tables, node) { > if (opp_table_np == opp_table->np) { > _get_opp_table_kref(opp_table); > + mutex_unlock(&opp_table_lock); > return opp_table; > } > } > + mutex_unlock(&opp_table_lock); > > err: > return ERR_PTR(-ENODEV); Ping.