From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F15D0C282DD for ; Mon, 10 Jun 2019 08:47:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3943207E0 for ; Mon, 10 Jun 2019 08:47:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="sr8LqP50" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388380AbfFJIrS (ORCPT ); Mon, 10 Jun 2019 04:47:18 -0400 Received: from mail-it1-f196.google.com ([209.85.166.196]:36571 "EHLO mail-it1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388218AbfFJIrS (ORCPT ); Mon, 10 Jun 2019 04:47:18 -0400 Received: by mail-it1-f196.google.com with SMTP id r135so11949087ith.1 for ; Mon, 10 Jun 2019 01:47:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RmMgFC6x9c/PorZ5L1nntqs3jUWepuR6IOl/Io6t8sA=; b=sr8LqP500iKG1pr5zd1qhsvzDTNmX/T7ykQZZsyxgglCuxvXsuoG2h2rzKF1mareen K5i73RDXA9cNqJMjk4i7hxv/kSfuQqnj+jH5Ap1EihoQIxgAMPoB9lTd8HITSyHf0KNL 0Q1vQ8j8bvqoz3mcV5cEqFzhPOabZZ7eNVRF944TG7eiZ+7qHZ8IYqCcsJrOSgavffCU t+MwCweWLy+1yPOrDWbg7Ob/+p5s+niwe6dh9AyMCMBqKnZ9S/KKQ1kGnf1iB463WxUl sIDeELFr0jraRh2oL+VHH+gFD3/1J2XrIZtVvdu6ak6ZMzc3fabZsLNkuqLNXOM/y6UY bofQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RmMgFC6x9c/PorZ5L1nntqs3jUWepuR6IOl/Io6t8sA=; b=ntFDPcWQHJMVb4mUOlVf/ZAepmMlL9Wjsyu9ckAgmy2Ymr91T9Nmo4eKA+bOf7xurv DKNaAaTSBVw2gTuigDS+EIjUmLB+jlUNccMDy0wPSget/e3Efx04zkrsx5LgExtXldWd YPIbV/1N1sh5vE1opRatpvVcnTON/R25jqGWG1Vzuwq/mV1tn3KgwukQ+aOi46EnXOz1 axE8k68C7VZr0o7nfjFpe2S14F/rQpZ+4Pryt3DmxECsrZlE4f8keFLXLyaC2FyFFPOx 1QPx0rnL7kbznqKvURVLi1L+qlLTwYigd3XEOsju/fpU/UFPgmA6FmXMHAbrpIOVqF+i UJMQ== X-Gm-Message-State: APjAAAUjdncb5ptoU/lQVDUJphj5juvAxmeAsa8SUbtXDwLyydUuor9w AopRpraEkVAGOhnDdExJU/0VveFSC9zTBDVnwWS2VQ== X-Google-Smtp-Source: APXvYqwYB5U4OOSNSqzBUVwcdMd5AxTJod5Bfub6eHYJFeIO+izmDcMKGFZM5Fn9MIcLTMjawmgYjhbtGhG/6pzPbWM= X-Received: by 2002:a24:5f87:: with SMTP id r129mr813080itb.104.1560156437323; Mon, 10 Jun 2019 01:47:17 -0700 (PDT) MIME-Version: 1.0 References: <20190610084213.1052-1-lee.jones@linaro.org> <20190610084213.1052-5-lee.jones@linaro.org> In-Reply-To: <20190610084213.1052-5-lee.jones@linaro.org> From: Ard Biesheuvel Date: Mon, 10 Jun 2019 10:47:05 +0200 Message-ID: Subject: Re: [PATCH v3 5/8] soc: qcom: geni: Add support for ACPI To: Lee Jones Cc: alokc@codeaurora.org, Andy Gross , David Brown , wsa+renesas@sang-engineering.com, Bjorn Andersson , Linus Walleij , balbi@kernel.org, Greg Kroah-Hartman , Jeffrey Hugo , linux-i2c , linux-arm-msm , "open list:GPIO SUBSYSTEM" , linux-usb , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, 10 Jun 2019 at 10:42, Lee Jones wrote: > > When booting with ACPI as the active set of configuration tables, > all; clocks, regulators, pin functions ect are expected to be at > their ideal values/levels/rates, thus the associated frameworks > are unavailable. Ensure calls to these APIs are shielded when > ACPI is enabled. > > Signed-off-by: Lee Jones Acked-by: Ard Biesheuvel > --- > drivers/soc/qcom/qcom-geni-se.c | 21 +++++++++++++++------ > 1 file changed, 15 insertions(+), 6 deletions(-) > > diff --git a/drivers/soc/qcom/qcom-geni-se.c b/drivers/soc/qcom/qcom-geni-se.c > index 6b8ef01472e9..d5cf953b4337 100644 > --- a/drivers/soc/qcom/qcom-geni-se.c > +++ b/drivers/soc/qcom/qcom-geni-se.c > @@ -1,6 +1,7 @@ > // SPDX-License-Identifier: GPL-2.0 > // Copyright (c) 2017-2018, The Linux Foundation. All rights reserved. > > +#include > #include > #include > #include > @@ -450,6 +451,9 @@ int geni_se_resources_off(struct geni_se *se) > { > int ret; > > + if (has_acpi_companion(se->dev)) > + return 0; > + > ret = pinctrl_pm_select_sleep_state(se->dev); > if (ret) > return ret; > @@ -487,6 +491,9 @@ int geni_se_resources_on(struct geni_se *se) > { > int ret; > > + if (has_acpi_companion(se->dev)) > + return 0; > + > ret = geni_se_clks_on(se); > if (ret) > return ret; > @@ -724,12 +731,14 @@ static int geni_se_probe(struct platform_device *pdev) > if (IS_ERR(wrapper->base)) > return PTR_ERR(wrapper->base); > > - wrapper->ahb_clks[0].id = "m-ahb"; > - wrapper->ahb_clks[1].id = "s-ahb"; > - ret = devm_clk_bulk_get(dev, NUM_AHB_CLKS, wrapper->ahb_clks); > - if (ret) { > - dev_err(dev, "Err getting AHB clks %d\n", ret); > - return ret; > + if (!has_acpi_companion(&pdev->dev)) { > + wrapper->ahb_clks[0].id = "m-ahb"; > + wrapper->ahb_clks[1].id = "s-ahb"; > + ret = devm_clk_bulk_get(dev, NUM_AHB_CLKS, wrapper->ahb_clks); > + if (ret) { > + dev_err(dev, "Err getting AHB clks %d\n", ret); > + return ret; > + } > } > > dev_set_drvdata(dev, wrapper); > -- > 2.17.1 >