From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1A53C31E4B for ; Fri, 14 Jun 2019 18:56:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C801C21473 for ; Fri, 14 Jun 2019 18:56:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="KcCX5mU3" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726046AbfFNS4E (ORCPT ); Fri, 14 Jun 2019 14:56:04 -0400 Received: from mail-pg1-f194.google.com ([209.85.215.194]:45395 "EHLO mail-pg1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725809AbfFNS4E (ORCPT ); Fri, 14 Jun 2019 14:56:04 -0400 Received: by mail-pg1-f194.google.com with SMTP id s21so2019760pga.12 for ; Fri, 14 Jun 2019 11:56:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Vi9HOqhVGYAs7GQ1RGU6Au5JJxjAyVHZ1t3+UITLDWM=; b=KcCX5mU37AGn3G3Wc0liG/jc8GtXaM2IsJzf9mOsShHLTiWFHUKFqTCT42vg2eB+Q7 8PSsg1gghWwbdHmqGZMVPntXTFyG6yoY0N90EQ36+PBbZeMfTxZcpRTKLZfl6//wrAK4 SDvVd5e0150rwYewbq+DsFK3frIYOG5SX6HN9BaLhVvd3vwCmrAnC3PoxI2sD4j4uNqX 5EMYKvnnMmd95YfKhE1dM44Fzwap2ygjtdKBzCLirgKWHiGYnKemGVp9hq6IsL59iU2V X3UZlVy2HJxDiz7/YrvBkRz77XWOLJ77jsf2S8FQ0anVH2r26eX84KzTevp62JW/eRmX komA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Vi9HOqhVGYAs7GQ1RGU6Au5JJxjAyVHZ1t3+UITLDWM=; b=gggNVhoZRntkPfezt61Dg1TNtppSzpY8ioGb/eOzRKZ3f9/rAsHNhfrXrLQ8Ji3FkM 2Px8S5XGMgx0H7ZsWK6YO+kKeHeaD3gdVoldWxwPnV+P5d1u8YqlCbdoWtLSEoS6PKQ6 +MpkHJiFqw1fMBZVZXcWKaZ/r51303xxDAOvOTyEd/i3Krbqk6a+rMbPVSlza3tVYvEv LkjHVMm4vgH3DojJhr3jgV32XnAC3RXDGMJw+WptyumFxT4TLmwUnjzhOBl39Ug6toJU 7K9bBJYdpj0MCiWuE4Z8yFIpH6dwSkR/pCKKMyHesfAmcNcQ9xTHH8eHE20mA0k3mO2B dJuQ== X-Gm-Message-State: APjAAAWAosnIkHTaoAUOAQMS+z4JJhPrTbAxcsZOcWpbYmi6ambNc+4Q vrpX7AF13ZIcKxKtOi6xVHTEAM4D4aOzKVu/mZzknQ== X-Google-Smtp-Source: APXvYqwU93ybihiYA9qI1ZfNbjRei7zFHARUnTO+Rc8QUH+8TNozlwasI5X3wqGb0bv42HyvcYj6+f7tryRZXmfjnTI= X-Received: by 2002:a63:306:: with SMTP id 6mr24242533pgd.263.1560538563050; Fri, 14 Jun 2019 11:56:03 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Nick Desaulniers Date: Fri, 14 Jun 2019 11:55:52 -0700 Message-ID: Subject: Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c To: Sean Paul Cc: Nathan Huckleberry , Jeykumar Sankaran , Rob Clark , Dave Airlie , Daniel Vetter , linux-arm-msm , dri-devel , freedreno@lists.freedesktop.org, clang-built-linux Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Jun 13, 2019 at 1:50 PM Sean Paul wrote: > > On Thu, Jun 13, 2019 at 4:13 PM Nathan Huckleberry wrote: > > > > Hey all, > > > > I'm looking into cleaning up ignored warnings in the kernel so we can > > remove compiler flags to ignore warnings. > > > > There are several unused variables in dpu_formats.c > > ('dpu_format_map_tile', 'dpu_format_map_p010', > > 'dpu_format_map_p010_ubwc', 'dpu_format_map_tp10_ubwc'). > > They look like modifiers that were never implemented. I'd like to > > remove these variables if there are no plans moving forward to > > implement them. Otherwise I'll just leave them. > > We can probably remove them for now and if someone wants to add > support, they can dredge them back up. Yep, this has been the feedback for other patches for this warning when the code was dead or not obviously some kind of bug/typo/copy-pasta. Nathan, please submit a patch removing the dead code; it may be reverted later when it's actually wired up. Nothing is truly lost w/ git*. -- Thanks, ~Nick Desaulniers