From: Rob Herring <robh+dt@kernel.org>
To: Michal Simek <michal.simek@xilinx.com>
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>,
Linux LED Subsystem <linux-leds@vger.kernel.org>,
devicetree@vger.kernel.org,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"open list:ARM/Rockchip SoC..."
<linux-rockchip@lists.infradead.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
"open list:ARM/QUALCOMM SUPPORT" <linux-soc@vger.kernel.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
koen.kooi@linaro.org,
Nicolas Dechesne <nicolas.dechesne@linaro.org>
Subject: Re: [PATCH v3 6/7] arm64: dts: xilinx: ultra96: Standardize LED labels and triggers
Date: Thu, 24 Jan 2019 10:49:30 -0600 [thread overview]
Message-ID: <CAL_Jsq+zfV66EZHX7psh2=r-=wDrmLLcr5PWtSzuKRNOdMR-Dw@mail.gmail.com> (raw)
In-Reply-To: <9f4f05cb-f326-a4e3-e306-cfbf64b629b4@xilinx.com>
On Fri, Dec 21, 2018 at 12:51 AM Michal Simek <michal.simek@xilinx.com> wrote:
>
> On 21. 12. 18 3:37, Manivannan Sadhasivam wrote:
> > On Mon, Oct 29, 2018 at 03:12:44PM +0530, Manivannan Sadhasivam wrote:
> >> For all 96Boards, the following standard is used for onboard LEDs.
> >>
> >> green:user1 default-trigger: heartbeat
> >> green:user2 default-trigger: mmc0/disk-activity(onboard-storage)
> >> green:user3 default-trigger: mmc1 (SD-card)
> >> green:user4 default-trigger: none, panic-indicator
> >> yellow:wlan default-trigger: phy0tx
> >> blue:bt default-trigger: hci0-power
> >>
> >> So lets adopt the same for Ultra96, which is one of the 96Boards
> >> CE and AI platform. Since the WLAN and BT LEDs are hardwired onboard,
> >> consolidate only User LEDs.
> >>
> >
> > Hello,
> >
> > Any update on this patch?
>
> I am still waiting for reaction from Rob.
> We are keep trying to keep backward compatibility and this patch is
> breaking it that's why I want to know DT guys reaction on this change.
dts changes and backwards compatibility are ultimately up to the
platform maintainers. Your users can yell at you if they care. I only
ask that changes that break compatibility are documented as doing so.
Personally, I'm in favor of this change. I'd rather seem uniformity
across boards and this is just a dev board and LED functions won't
affect booting.
Rob
next prev parent reply other threads:[~2019-01-24 16:49 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-29 9:42 [PATCH v3 0/7] Standardize onboard LED support for 96Boards Manivannan Sadhasivam
2018-10-29 9:42 ` [PATCH v3 1/7] arm64: dts: rockchip: ficus: Add on-board LED support Manivannan Sadhasivam
2018-12-11 19:11 ` Heiko Stuebner
2018-10-29 9:42 ` [PATCH v3 2/7] arm64: dts: rockchip: rock960: " Manivannan Sadhasivam
2018-12-11 19:11 ` Heiko Stuebner
2018-10-29 9:42 ` [PATCH v3 3/7] arm64: dts: hisilicon: hikey: Standardize LED labels and triggers Manivannan Sadhasivam
2018-10-29 9:42 ` [PATCH v3 4/7] arm64: dts: hisilicon: hikey960: " Manivannan Sadhasivam
2018-10-29 9:42 ` [PATCH v3 5/7] arm64: dts: hisilicon: poplar: " Manivannan Sadhasivam
2018-10-29 9:42 ` [PATCH v3 6/7] arm64: dts: xilinx: ultra96: " Manivannan Sadhasivam
2018-12-21 2:37 ` Manivannan Sadhasivam
2018-12-21 6:50 ` Michal Simek
2019-01-24 16:49 ` Rob Herring [this message]
2019-01-29 13:17 ` Michal Simek
2018-10-29 9:42 ` [PATCH v3 7/7] arm64: dts: qcom: apq8016-sbc: Standardize LED labels Manivannan Sadhasivam
2018-12-21 2:35 ` Manivannan Sadhasivam
2019-02-05 19:00 ` Nicolas Dechesne
2019-02-05 19:24 ` Bjorn Andersson
2018-10-31 13:38 ` [PATCH v3 0/7] Standardize onboard LED support for 96Boards Linus Walleij
[not found] ` <CAHTX3dJTXtuA0i-ffPjoiWuxEcF_5JY55VJtWd9zxW4HxK1K3w@mail.gmail.com>
2018-10-31 21:17 ` Linus Walleij
2018-11-01 10:49 ` Heiko Stübner
2018-11-29 15:42 ` Wei Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAL_Jsq+zfV66EZHX7psh2=r-=wDrmLLcr5PWtSzuKRNOdMR-Dw@mail.gmail.com' \
--to=robh+dt@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=koen.kooi@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-soc@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=michal.simek@xilinx.com \
--cc=nicolas.dechesne@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).