From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C060C43603 for ; Mon, 9 Dec 2019 16:16:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2034E207FD for ; Mon, 9 Dec 2019 16:16:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575908205; bh=l4AhqF+61Jiy/j68RJXORhPY3suI4I2IVJ52J64y4Zk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:List-ID:From; b=l3IgFHdV6l/TKmQk/iDY5zIOjZIqCpu90NsEtaL0DXjn6npu43zKZ1S3nN8YhTmxf q0B7dPi8a0eWejFDWrw3URSi/qbWNY65lVTXOcwWupepJk9gC3WoZCZuTFn+vzNKVB D4aYprMF0J6b4Mqoy0qmuy7nkskpmC849otHAeyg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726483AbfLIQQl (ORCPT ); Mon, 9 Dec 2019 11:16:41 -0500 Received: from mail.kernel.org ([198.145.29.99]:54984 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbfLIQQl (ORCPT ); Mon, 9 Dec 2019 11:16:41 -0500 Received: from mail-qk1-f180.google.com (mail-qk1-f180.google.com [209.85.222.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B251920828; Mon, 9 Dec 2019 16:16:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1575908199; bh=l4AhqF+61Jiy/j68RJXORhPY3suI4I2IVJ52J64y4Zk=; h=References:In-Reply-To:From:Date:Subject:To:Cc:From; b=0wDWFAoulgr5XplI38skCakA+bNiEcj2Wxof1qA3rXeM9rIeY4K0yEcqH3yvjr05P QIGUWPh6AIJCl7capcigI94Qpb2MYx7Ja+ANKu/yNtAKWaChuWo/kjXO4LCf5i+dRa XHkcsS0d1WFvuMnWFd56LGf7qF4UGCmZm6SHt7lg= Received: by mail-qk1-f180.google.com with SMTP id v23so13563567qkg.2; Mon, 09 Dec 2019 08:16:39 -0800 (PST) X-Gm-Message-State: APjAAAXIAKnW6A0hfaI7t6Vh7HPGUTtMSOfFxMYyg+r5j7Ny+cAqXnz7 IZAA+SUip30trvJbj/39EdOrnC+EgoPZ8doxng== X-Google-Smtp-Source: APXvYqzm+y1a+nHLIKKviHPGNroxVtdzzfAl0KJk/UiMX5C7PNHWL6f86VHVl/ycQZQyz1jGTdzQuSJozTV+lWFQMio= X-Received: by 2002:a37:85c4:: with SMTP id h187mr28125112qkd.223.1575908198803; Mon, 09 Dec 2019 08:16:38 -0800 (PST) MIME-Version: 1.0 References: <20191205002503.13088-1-masneyb@onstation.org> <20191205002503.13088-5-masneyb@onstation.org> <20191209005436.GA13647@onstation.org> In-Reply-To: <20191209005436.GA13647@onstation.org> From: Rob Herring Date: Mon, 9 Dec 2019 10:16:26 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH 4/7] dt-bindings: Input: introduce new clock vibrator bindings To: Brian Masney Cc: Stephen Boyd , Dmitry Torokhov , Mark Rutland , Andy Gross , Bjorn Andersson , Michael Turquette , Linux Input , devicetree@vger.kernel.org, "linux-kernel@vger.kernel.org" , linux-arm-msm , linux-clk Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Sun, Dec 8, 2019 at 6:54 PM Brian Masney wrote: > > On Thu, Dec 05, 2019 at 07:56:10AM -0600, Rob Herring wrote: > > On Wed, Dec 4, 2019 at 6:25 PM Brian Masney wrote: > > > > > > Add support for clock-based vibrator devices where the speed can be > > > controlled by changing the duty cycle. > > > > > > Signed-off-by: Brian Masney > > > --- > > > .../bindings/input/clk-vibrator.yaml | 60 +++++++++++++++++++ > > > 1 file changed, 60 insertions(+) > > > create mode 100644 Documentation/devicetree/bindings/input/clk-vibrator.yaml > > > > > > diff --git a/Documentation/devicetree/bindings/input/clk-vibrator.yaml b/Documentation/devicetree/bindings/input/clk-vibrator.yaml > > > new file mode 100644 > > > index 000000000000..2103a5694fad > > > --- /dev/null > > > +++ b/Documentation/devicetree/bindings/input/clk-vibrator.yaml > > > @@ -0,0 +1,60 @@ > > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > > > +%YAML 1.2 > > > +--- > > > +$id: http://devicetree.org/schemas/bindings/input/clk-vibrator.yaml# > > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > > + > > > +title: Clock vibrator > > > + > > > +maintainers: > > > + - Brian Masney > > > + > > > +description: | > > > + Support for clock-based vibrator devices where the speed can be controlled > > > + by changing the duty cycle. > > > + > > > +properties: > > > + compatible: > > > + const: clk-vibrator > > > + > > > + clocks: > > > + maxItems: 1 > > > + > > > + clock-names: > > > + description: output clock that controls the speed > > > + items: > > > + - const: core > > > > No point in making up a name when there's only one clock, so drop. > > OK, will do. > > > > > > + > > > + clock-frequency: true > > > > Given the frequency is variable, what does this mean in this case? > > The clock frequency is fixed. The duty cycle is what's variable. That sounds like a PWM then... Rob