From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9E3BEB64DC for ; Wed, 14 Jun 2023 07:29:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234403AbjFNH3D (ORCPT ); Wed, 14 Jun 2023 03:29:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47222 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233802AbjFNH3B (ORCPT ); Wed, 14 Jun 2023 03:29:01 -0400 Received: from mail-vs1-xe30.google.com (mail-vs1-xe30.google.com [IPv6:2607:f8b0:4864:20::e30]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1936C11B for ; Wed, 14 Jun 2023 00:29:00 -0700 (PDT) Received: by mail-vs1-xe30.google.com with SMTP id ada2fe7eead31-43dc3f77accso782679137.3 for ; Wed, 14 Jun 2023 00:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20221208.gappssmtp.com; s=20221208; t=1686727739; x=1689319739; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=5CRRGmdvDVbIEVTAFye64zUK3XOXIsv8ssMpfcABwlc=; b=Nf0/wLoZ38LsOopYbyo0ezI8LUQxgJTAFLkmLtgB++4Cqtqg95I3NTpGl9TXnYDDkY wQhNpaGtN+5iKwyxA/Sc3yKL4QWEEoRYv1tUv0/rZ1jPqpc9h2liqXzIFsH7Mk0PzJ2D 8Dt9l/8xaaR/qGP/pxdKD42jgFfMPgpFD59+6wt7ykOg3xU4OOQOIVjAB7xnsarGe2xV S1QJ6zDt5NlO/4rFM4tBxEctZeiRwHUUbqReFG2sT+6YQbOdFDmCmmmOhAPgpwdAefLP SOVujR+y+Jx1AZxSFRB5PTZR3D5aXGCdsLrtMDajNAzKERlzusmNmNlP39Tdtw7fIp0C Jqdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686727739; x=1689319739; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5CRRGmdvDVbIEVTAFye64zUK3XOXIsv8ssMpfcABwlc=; b=K04yTp6rXWWKs8yuHMqgykhGFexxKYigwMVrY0p5T/5uHLocJlq2WvuIf4h6Hgag3t bFfJp59OxI3fq9AJ7mUnuGQ23rlwXLuUnoNbvaCMB8uqeMl6KB/Oq9NzuUkBB0WqBOHX CJF+kmt+ow7LyHMLvIRJnAy6KznBQ0WQfgODX46bYPT0OLWT9D6rSGxR1/dBX9guaJOa 7fv2WiOVJacZPU/iwINCza1rRiIhDZI9JY+YXjIeeoeujv/zyv/fNZo/emHK4x9wbGp9 NeySji5DXRAAZr0PtV1QQPEoXvHjBxXXBAvEkDuQO9Vk+16keW5K4etEfBUl1C9hTWDo WP7g== X-Gm-Message-State: AC+VfDysoov+4Z+7WEga6Zou0q5ATF+dO0ebQluHtTg2LaCIqs7h7N1+ KFJK+FmpZ9v1u80XoJVUcPzHxja1AH7uZY8/qA+inQ== X-Google-Smtp-Source: ACHHUZ5IOUv06tiZXv2OeC2IVs2JPsy0d5AliyorYz0hKnjFQVcPktvrX5L1vFgxFRciusLts8S8bofr4NgaMAhMxQo= X-Received: by 2002:a05:6102:ca:b0:43d:54e9:35fb with SMTP id u10-20020a05610200ca00b0043d54e935fbmr7796848vsp.14.1686727739229; Wed, 14 Jun 2023 00:28:59 -0700 (PDT) MIME-Version: 1.0 References: <20230612092355.87937-1-brgl@bgdev.pl> <20230612092355.87937-21-brgl@bgdev.pl> <712b2650-f0c1-088a-612c-ef6d6bcc1eb0@linaro.org> In-Reply-To: <712b2650-f0c1-088a-612c-ef6d6bcc1eb0@linaro.org> From: Bartosz Golaszewski Date: Wed, 14 Jun 2023 09:28:48 +0200 Message-ID: Subject: Re: [PATCH 20/26] dt-bindings: net: qcom,ethqos: add description for sa8775p To: Krzysztof Kozlowski Cc: Vinod Koul , Bhupesh Sharma , Andy Gross , Bjorn Andersson , Konrad Dybcio , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kishon Vijay Abraham I , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , netdev@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jun 14, 2023 at 9:25=E2=80=AFAM Krzysztof Kozlowski wrote: > > On 12/06/2023 11:23, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > > > Add the compatible for the MAC controller on sa8775p platforms. This MA= C > > works with a single interrupt so add minItems to the interrupts propert= y. > > The fourth clock's name is different here so change it. Enable relevant > > PHY properties. > > > > I think the patch should be squashed with previous. Adding compatible to > common snps,dwmac binding does not make sense on its own. It makes sense > with adding compatible here. > > > Signed-off-by: Bartosz Golaszewski > > --- > > .../devicetree/bindings/net/qcom,ethqos.yaml | 14 +++++++++++++- > > 1 file changed, 13 insertions(+), 1 deletion(-) > > > > diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/D= ocumentation/devicetree/bindings/net/qcom,ethqos.yaml > > index 60a38044fb19..b20847c275ce 100644 > > --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > > +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml > > @@ -20,6 +20,7 @@ properties: > > compatible: > > enum: > > - qcom,qcs404-ethqos > > + - qcom,sa8775p-ethqos > > - qcom,sc8280xp-ethqos > > - qcom,sm8150-ethqos > > > > @@ -32,11 +33,13 @@ properties: > > - const: rgmii > > > > interrupts: > > + minItems: 1 > > items: > > - description: Combined signal for various interrupt events > > - description: The interrupt that occurs when Rx exits the LPI s= tate > > > > interrupt-names: > > + minItems: 1 > > items: > > - const: macirq > > - const: eth_lpi > > @@ -49,11 +52,20 @@ properties: > > - const: stmmaceth > > - const: pclk > > - const: ptp_ref > > - - const: rgmii > > + - enum: > > + - rgmii > > + - phyaux > > > > iommus: > > maxItems: 1 > > > > + phys: true > > + > > + phy-supply: true > > Isn't this property of the phy? > It is, and as discussed elsewhere with Andrew, I will move it to the SerDes PHY driver. Bart > > + > > + phy-names: > > + const: serdes > > Keep the phy-names after phys. > > > Best regards, > Krzysztof >