From: Konrad Dybcio <konradybcio@gmail.com>
To: Amit Pundir <amit.pundir@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
John Stultz <john.stultz@linaro.org>,
Sumit Semwal <sumit.semwal@linaro.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
dt <devicetree@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium)
Date: Sun, 6 Sep 2020 16:35:20 +0200 [thread overview]
Message-ID: <CAMS8qEVrSBPqtnMhAMY25yrUJ+M+3UrrGt+yikLaCyFDCUqCCw@mail.gmail.com> (raw)
In-Reply-To: <CAMi1Hd2ZakhXm+qNh-VMF_OndqCaQxxY3CC+UfQ6x2PyL_5sPQ@mail.gmail.com>
> Thank you for the pointer. I dug around the vph_pwr fixed-regulator
> node used by fellow sdm845 devices. I assume it is safe to copy it
> from sdm845-mtp but I couldn't verify it in the downstream
> device-tree, so I'm a bit hesitant. My main concern is that I don't
> want to burn down my only device :)
Sure, nobody does ^^
> I did find a few regulator nodes downstream which matches with
> upstream sdm845-mtp but since I'm not using any of them in my
> beryllium dts, I'm going to skip them for now.
Looking at their DTSes, Xiaomi doesn't seem to stray far away from MTP designs.
> As you pointed out, in case of regulator lookup failure Linux will
> fall back to dummy regulators, which is working fine for me so far.
> Also I see that vdd-*-supply properties are optional according to
> Documentation/devicetree/bindings/regulator/qcom,rpmh-regulator.txt,
> so I assume it is safe to skip them?
Yes, but keep in mind it would be a good idea to add them later, after
you're sure everything's okay :)
P.S. My current daily driver is Xiaomi Mi 8, which is basically Poco
with an OLED and glass back (among some other minor nicer things), so
thanks for your work, I might benefit from it in the future :)
Konrad
prev parent reply other threads:[~2020-09-06 14:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-31 5:24 [PATCH v6] arm64: dts: qcom: Add support for Xiaomi Poco F1 (Beryllium) Amit Pundir
2020-08-31 5:37 ` Amit Pundir
2020-08-31 7:57 ` Konrad Dybcio
2020-08-31 8:00 ` Konrad Dybcio
2020-09-02 13:27 ` Amit Pundir
2020-09-06 14:35 ` Konrad Dybcio [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAMS8qEVrSBPqtnMhAMY25yrUJ+M+3UrrGt+yikLaCyFDCUqCCw@mail.gmail.com \
--to=konradybcio@gmail.com \
--cc=agross@kernel.org \
--cc=amit.pundir@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sumit.semwal@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).