From: Loic Poulain <loic.poulain@linaro.org>
To: Jarvis Jiang <jarvis.w.jiang@gmail.com>
Cc: Manivannan Sadhasivam <mani@kernel.org>,
Hemant Kumar <hemantk@codeaurora.org>,
open list <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Chi-Wei Chen50 <cchen50@lenovo.com>,
Mark Pearson <mpearson@lenovo.com>
Subject: Re: [PATCH v1] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN
Date: Wed, 28 Apr 2021 10:38:40 +0200 [thread overview]
Message-ID: <CAMZdPi-H=mnH9SFQZ7XQ8fjb0VtYbaWKGFhoXYyurDAB+RpQ5w@mail.gmail.com> (raw)
In-Reply-To: <20210421065501.3134-1-jarvis.w.jiang@gmail.com>
On Wed, 21 Apr 2021 at 08:56, Jarvis Jiang <jarvis.w.jiang@gmail.com> wrote:
>
> According to MHI v1.1 specification, change the channel name of T99W175
> from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33,
> so that the channels can be bound to the Qcom WWAN control driver, and
> device node such as /dev/wwan0p3AT will be generated, which is very useful
> for debugging modem
>
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
Ok, it seems the spec claims it's a DUN channel, but all vendors use
it for AT protocol, so it's fine (and correctly handled by the
mhi_wwan_ctrl driver).
Could you please add a Fixes tag since it fixes your previous commit?
with that
Reviewed-by: Loic Poulain <loic.poulain@linaro.org>
> ---
> drivers/bus/mhi/pci_generic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 7c810f02a2ef..8c7f6576e421 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -311,8 +311,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
> MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
> MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
> MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> - MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0),
> - MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0),
> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> };
> --
> 2.25.1
>
next prev parent reply other threads:[~2021-04-28 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 6:55 [PATCH v1] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN Jarvis Jiang
2021-04-28 8:38 ` Loic Poulain [this message]
2021-04-29 1:22 ` Jarvis Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAMZdPi-H=mnH9SFQZ7XQ8fjb0VtYbaWKGFhoXYyurDAB+RpQ5w@mail.gmail.com' \
--to=loic.poulain@linaro.org \
--cc=cchen50@lenovo.com \
--cc=hemantk@codeaurora.org \
--cc=jarvis.w.jiang@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mpearson@lenovo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).