From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5B79C433DB for ; Tue, 9 Mar 2021 08:25:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8848C652B1 for ; Tue, 9 Mar 2021 08:25:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229520AbhCIIZI (ORCPT ); Tue, 9 Mar 2021 03:25:08 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35910 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229599AbhCIIYs (ORCPT ); Tue, 9 Mar 2021 03:24:48 -0500 Received: from mail-pf1-x42d.google.com (mail-pf1-x42d.google.com [IPv6:2607:f8b0:4864:20::42d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B385AC06175F for ; Tue, 9 Mar 2021 00:24:48 -0800 (PST) Received: by mail-pf1-x42d.google.com with SMTP id x7so5538096pfi.7 for ; Tue, 09 Mar 2021 00:24:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=133xFANkNnvXsS/Gcj7xoFzGV1TFyuCxTpiSDGedfLQ=; b=bhBxe3eGIKx2n1tXLkj/kt4qLfcPr8e+Lh8ddardt+U/dQY5KOMT8UpMHyARVTVGVQ LglQLDxlJ5WsCIFQaFAG91rp3avAZmYwSdUUkR+fLHZZq5yAAUbpZ0u1Cpw7zFaGKcNA D+FFmgFHhFpSTMrGZF9Lnds6DZmQzzH47WZWlyXUREM54sWxViJrSwUYJQyF77NTHje2 cQibfnUUzWGV6tiABIkOOFoJ+Oc3WS1yudZSKYK8Xa0haQw5SkVawB+zovGSAMtX5Yac ziNW0VBuXttb3kwimxU3fQ2bQStF8hVgXGHfGOcL9jXi50bfrPiNO3/22Vonolaz3qxd P85A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=133xFANkNnvXsS/Gcj7xoFzGV1TFyuCxTpiSDGedfLQ=; b=sTXrzgdONRehq/Eti0bRkp2Rz0/m8cER/85fOgzdwYoCgDCwLqCGlNaxipz4vNCt7U ikvWSlPI37qgvP9PZBWqNBKZzHjfKhJlCOOVn2HoWd7Qv7vALx44npqOw5M5gFlDbvpT I/uiAXI+w0jpqTynCXOk1nKyVNUAXjmSa1fJePSwFWuSvKThpiiIV11XrdixtD8bNQJ0 lxGm5508UirIJe9kDfBmTalVd293efdRbPVTUIhiYCVeU1aw3D1gqfakd2G7ow0mphXp z6JDIKCe6KbBWrzyrz3rNDw+BDmzvB/29FbZes5wQ64WMg+Wy760cbOAsAWWSFykv+pa vkeQ== X-Gm-Message-State: AOAM530YIscFllYxYACUjFZ4acNb2HQebwwuRsEVr6B823GWmZID17fd uaw96wRWDWcBFolmpa81i0+C7n4WEpHrKQMqj35Dmg== X-Google-Smtp-Source: ABdhPJxJZT+QQX3Qi/RyHF/HLj4uXQeq8a86sg9PH5SuEdoEnUxOLdvvEGc83GXcAwk/DmN5njH1BgFqqX0gNRJO9cA= X-Received: by 2002:a63:2262:: with SMTP id t34mr24607341pgm.303.1615278288204; Tue, 09 Mar 2021 00:24:48 -0800 (PST) MIME-Version: 1.0 References: <1615237167-19969-1-git-send-email-loic.poulain@linaro.org> In-Reply-To: From: Loic Poulain Date: Tue, 9 Mar 2021 09:32:39 +0100 Message-ID: Subject: Re: [PATCH v2] bus: mhi: Add Qcom WWAN control driver To: Greg KH Cc: Manivannan Sadhasivam , Hemant Kumar , linux-arm-msm , Aleksander Morgado , open list , Jakub Kicinski , David Miller , Network Development , Bjorn Andersson Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 9 Mar 2021 at 09:19, Greg KH wrote: > > On Mon, Mar 08, 2021 at 09:59:27PM +0100, Loic Poulain wrote: > > The MHI WWWAN control driver allows MHI Qcom based modems to expose > > different modem control protocols to userspace, so that userspace > > modem tools or daemon (e.g. ModemManager) can control WWAN config > > and state (APN config, SMS, provider selection...). A Qcom based > > modem can expose one or several of the following protocols: > > - AT: Well known AT commands interactive protocol (microcom, minicom...) > > - MBIM: Mobile Broadband Interface Model (libmbim, mbimcli) > > - QMI: Qcom MSM/Modem Interface (libqmi, qmicli) > > - QCDM: Qcom Modem diagnostic interface (libqcdm) > > - FIREHOSE: XML-based protocol for Modem firmware management > > (qmi-firmware-update) > > > > The different interfaces are exposed as character devices, in the same > > way as for USB modem variants. > > > > Note that this patch is mostly a rework of the earlier MHI UCI > > tentative that was a generic interface for accessing MHI bus from > > userspace. As suggested, this new version is WWAN specific and is > > dedicated to only expose channels used for controlling a modem, and > > for which related opensource user support exist. Other MHI channels > > not fitting the requirements will request either to be plugged to > > the right Linux subsystem (when available) or to be discussed as a > > new MHI driver (e.g AI accelerator, WiFi debug channels, etc...). > > > > Co-developed-by: Hemant Kumar > > Signed-off-by: Hemant Kumar > > Signed-off-by: Loic Poulain > > --- > > v2: update copyright (2021) > > > > drivers/bus/mhi/Kconfig | 12 + > > drivers/bus/mhi/Makefile | 3 + > > drivers/bus/mhi/wwan_ctrl.c | 559 ++++++++++++++++++++++++++++++++++++++++++++ > > As Jakub said, why is this file in this directory? > > Flat out ignoring review comments is a sure way to always get pushed to > the bottom of the list of things anyone wants to ever look at... Yes, it's a legacy of the previous driver that was kind of a generic a mhi bus accessor. I'm going to move it inside network since it's about WWAN. Thanks, Loic > > greg k-h