From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23C0DC49EA5 for ; Thu, 24 Jun 2021 15:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0675C613E3 for ; Thu, 24 Jun 2021 15:30:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232109AbhFXPct (ORCPT ); Thu, 24 Jun 2021 11:32:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230267AbhFXPcs (ORCPT ); Thu, 24 Jun 2021 11:32:48 -0400 Received: from mail-pj1-x1036.google.com (mail-pj1-x1036.google.com [IPv6:2607:f8b0:4864:20::1036]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDA8AC061574 for ; Thu, 24 Jun 2021 08:30:28 -0700 (PDT) Received: by mail-pj1-x1036.google.com with SMTP id s17-20020a17090a8811b029016e89654f93so6153189pjn.1 for ; Thu, 24 Jun 2021 08:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GKu79Jy0wP/pVLbay2WCl0HQlTcf+F7A2KNkIRNIJy4=; b=Fyky1i94qfhy+kdxE5taKryG8XZa+NEyCr/pmvB1UvjRhgxQ5anKy+S/BMvAF+/Z23 W1+VH7Q1K80RYPmz8sYHF70V4Lmz9tDCOoh+pi6oae8vHOLj9ul80KCyrJn+MmdL3c40 lzJ8Jy520/8FvCYxQJgE6WNiBO1te5XzJT7V9Mi3dx6SazdsPEspuX5U4l0DHcSgYGOv zv/91rGmkvwGYZeNHydZqrsKuYYR1q1CDPt0pkjiMXzxBLKs+0Iwd+9fI+wC5+8gau/N H3c/rijIC5sh5XwBHvZHhLdZH8JsYVtqycxO6gmj0jC8OvuYIYe/nUnK2RGXmfIm05TH YHVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GKu79Jy0wP/pVLbay2WCl0HQlTcf+F7A2KNkIRNIJy4=; b=FnIapn6tpc/E2XDzsfG53f7IKs9kXz5sc0XYvQ5dutVktvjD/K9lq8AwfY6JdrDiRZ WUToNaAiJgsu5H4erXsU4dqybQrtZaENA4n/crTtZUo0mw60vzCDJpu8KzIB9RAYupNv gr61de4eznNY7imKRk0OlenRkgSdqvUS0lrYKAvEtYtGlhJzHQ10j6D4dABcR/bzp7c+ lgjMCEIDLtETUUmuoCUQQlF7Ig4uGmXhiA4WOLc52Sdai31J2+YQOqbM8nOc5n0Ins+n K9eOHA2Ej1HjRC+6D8fbvE+WeLW51azHbeXTcDnBpQa3vPu8wxlwPrTU4hOXNALUjQGi 2qlw== X-Gm-Message-State: AOAM5324K4bKwx44m8EtRn1/P4vraELC+N9HvkTuGsA7e/+lTu5agsuK /SjiWutu/6L+2rQl+VXjZdbCyHJRUxKhiAkY5v6bow== X-Google-Smtp-Source: ABdhPJyuUEdd3ounqqk/N9c8OldDL7cnuqef1j4apMAbjh4tkOrLl8eDwvYu7gh3xfYp0RkvOYlNT9O4FCc0aYAczeE= X-Received: by 2002:a17:90a:640b:: with SMTP id g11mr6201944pjj.18.1624548628083; Thu, 24 Jun 2021 08:30:28 -0700 (PDT) MIME-Version: 1.0 References: <20210621161616.77524-1-manivannan.sadhasivam@linaro.org> <20210621161616.77524-5-manivannan.sadhasivam@linaro.org> In-Reply-To: From: Loic Poulain Date: Thu, 24 Jun 2021 17:39:58 +0200 Message-ID: Subject: Re: [PATCH 4/8] bus: mhi: Add inbound buffers allocation flag To: Greg KH Cc: Manivannan Sadhasivam , Hemant Kumar , Bhaumik Bhatt , linux-arm-msm , open list , Jakub Kicinski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Greg, On Thu, 24 Jun 2021 at 15:51, Greg KH wrote: > > On Mon, Jun 21, 2021 at 09:46:12PM +0530, Manivannan Sadhasivam wrote: > > From: Loic Poulain > > > > Currently, the MHI controller driver defines which channels should > > have their inbound buffers allocated and queued. But ideally, this is > > something that should be decided by the MHI device driver instead, > > which actually deals with that buffers. > > > > Add a flag parameter to mhi_prepare_for_transfer allowing to specify > > if buffers have to be allocated and queued by the MHI stack. > > > > Keep auto_queue flag for now, but should be removed at some point. > > > > Signed-off-by: Loic Poulain > > Tested-by: Bhaumik Bhatt > > Reviewed-by: Bhaumik Bhatt > > Reviewed-by: Hemant Kumar > > Reviewed-by: Manivannan Sadhasivam > > Acked-by: Jakub Kicinski > > Link: https://lore.kernel.org/r/1621603519-16773-1-git-send-email-loic.poulain@linaro.org > > Signed-off-by: Manivannan Sadhasivam [...] > > +/** > > + * enum mhi_chan_flags - MHI channel flags > > + * @MHI_CH_INBOUND_ALLOC_BUFS: Automatically allocate and queue inbound buffers > > + */ > > +enum mhi_chan_flags { > > + MHI_CH_INBOUND_ALLOC_BUFS = BIT(0), > > Why is an enumerated type a bitfield? > > Please just use integers for enumerated types. This 'trick' for listing flags is used in other places like drm, mac80211, etc...: grep -r "BIT(0)," ./include/ I don't understand why it would not be right? should we simply use a list of defines for this? Regards, Loic