* [PATCH v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN
@ 2021-04-29 1:42 Jarvis Jiang
2021-05-03 8:09 ` Loic Poulain
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Jarvis Jiang @ 2021-04-29 1:42 UTC (permalink / raw)
To: mani, hemantk, loic.poulain
Cc: linux-kernel, linux-arm-msm, cchen50, mpearson, Jarvis Jiang
According to MHI v1.1 specification, change the channel name of T99W175
from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33,
so that the channels can be bound to the Qcom WWAN control driver, and
device node such as /dev/wwan0p3AT will be generated, which is very useful
for debugging modem
Fixes: aac426562f56 ("bus: mhi: pci_generic: Introduce Foxconn T99W175 support")
Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
---
v2: Add: Fixes: aac426562f56
drivers/bus/mhi/pci_generic.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
index 7c810f02a2ef..8c7f6576e421 100644
--- a/drivers/bus/mhi/pci_generic.c
+++ b/drivers/bus/mhi/pci_generic.c
@@ -311,8 +311,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
- MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0),
- MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0),
+ MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
+ MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
};
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN
2021-04-29 1:42 [PATCH v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN Jarvis Jiang
@ 2021-05-03 8:09 ` Loic Poulain
2021-05-21 11:55 ` Manivannan Sadhasivam
2021-05-21 17:37 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Loic Poulain @ 2021-05-03 8:09 UTC (permalink / raw)
To: Hemant Kumar, Manivannan Sadhasivam
Cc: Jarvis Jiang, open list, linux-arm-msm, Chi-Wei Chen50, Mark Pearson
Hi Mani, Hemant,
On Thu, 29 Apr 2021 at 03:44, Jarvis Jiang <jarvis.w.jiang@gmail.com> wrote:
>
> According to MHI v1.1 specification, change the channel name of T99W175
> from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33,
> so that the channels can be bound to the Qcom WWAN control driver, and
> device node such as /dev/wwan0p3AT will be generated, which is very useful
> for debugging modem
>
> Fixes: aac426562f56 ("bus: mhi: pci_generic: Introduce Foxconn T99W175 support")
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
Should be considered for 5.13-rc* since to properly fix the issue.
Thanks,
Loic
> ---
>
> v2: Add: Fixes: aac426562f56
>
> drivers/bus/mhi/pci_generic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 7c810f02a2ef..8c7f6576e421 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -311,8 +311,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
> MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
> MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
> MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> - MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0),
> - MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0),
> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN
2021-04-29 1:42 [PATCH v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN Jarvis Jiang
2021-05-03 8:09 ` Loic Poulain
@ 2021-05-21 11:55 ` Manivannan Sadhasivam
2021-05-21 17:37 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2021-05-21 11:55 UTC (permalink / raw)
To: Jarvis Jiang
Cc: hemantk, loic.poulain, linux-kernel, linux-arm-msm, cchen50, mpearson
On Wed, Apr 28, 2021 at 06:42:26PM -0700, Jarvis Jiang wrote:
> According to MHI v1.1 specification, change the channel name of T99W175
> from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33,
> so that the channels can be bound to the Qcom WWAN control driver, and
> device node such as /dev/wwan0p3AT will be generated, which is very useful
> for debugging modem
>
> Fixes: aac426562f56 ("bus: mhi: pci_generic: Introduce Foxconn T99W175 support")
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Thanks,
Mani
> ---
>
> v2: Add: Fixes: aac426562f56
>
> drivers/bus/mhi/pci_generic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 7c810f02a2ef..8c7f6576e421 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -311,8 +311,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
> MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
> MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
> MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> - MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0),
> - MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0),
> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN
2021-04-29 1:42 [PATCH v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN Jarvis Jiang
2021-05-03 8:09 ` Loic Poulain
2021-05-21 11:55 ` Manivannan Sadhasivam
@ 2021-05-21 17:37 ` Manivannan Sadhasivam
2 siblings, 0 replies; 4+ messages in thread
From: Manivannan Sadhasivam @ 2021-05-21 17:37 UTC (permalink / raw)
To: Jarvis Jiang
Cc: hemantk, loic.poulain, linux-kernel, linux-arm-msm, cchen50, mpearson
On Wed, Apr 28, 2021 at 06:42:26PM -0700, Jarvis Jiang wrote:
> According to MHI v1.1 specification, change the channel name of T99W175
> from "AT" to "DUN" (Dial-up networking) for both channel 32 and 33,
> so that the channels can be bound to the Qcom WWAN control driver, and
> device node such as /dev/wwan0p3AT will be generated, which is very useful
> for debugging modem
>
> Fixes: aac426562f56 ("bus: mhi: pci_generic: Introduce Foxconn T99W175 support")
> Signed-off-by: Jarvis Jiang <jarvis.w.jiang@gmail.com>
Applied to mhi-fixes!
Thanks,
Mani
> ---
>
> v2: Add: Fixes: aac426562f56
>
> drivers/bus/mhi/pci_generic.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/bus/mhi/pci_generic.c b/drivers/bus/mhi/pci_generic.c
> index 7c810f02a2ef..8c7f6576e421 100644
> --- a/drivers/bus/mhi/pci_generic.c
> +++ b/drivers/bus/mhi/pci_generic.c
> @@ -311,8 +311,8 @@ static const struct mhi_channel_config mhi_foxconn_sdx55_channels[] = {
> MHI_CHANNEL_CONFIG_DL(5, "DIAG", 32, 1),
> MHI_CHANNEL_CONFIG_UL(12, "MBIM", 32, 0),
> MHI_CHANNEL_CONFIG_DL(13, "MBIM", 32, 0),
> - MHI_CHANNEL_CONFIG_UL(32, "AT", 32, 0),
> - MHI_CHANNEL_CONFIG_DL(33, "AT", 32, 0),
> + MHI_CHANNEL_CONFIG_UL(32, "DUN", 32, 0),
> + MHI_CHANNEL_CONFIG_DL(33, "DUN", 32, 0),
> MHI_CHANNEL_CONFIG_HW_UL(100, "IP_HW0_MBIM", 128, 2),
> MHI_CHANNEL_CONFIG_HW_DL(101, "IP_HW0_MBIM", 128, 3),
> };
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-05-21 17:37 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 1:42 [PATCH v2] bus: mhi: pci_generic: T99W175: update channel name from AT to DUN Jarvis Jiang
2021-05-03 8:09 ` Loic Poulain
2021-05-21 11:55 ` Manivannan Sadhasivam
2021-05-21 17:37 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).