From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AE58EB64D9 for ; Thu, 15 Jun 2023 16:16:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232638AbjFOQQS (ORCPT ); Thu, 15 Jun 2023 12:16:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57280 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230173AbjFOQQR (ORCPT ); Thu, 15 Jun 2023 12:16:17 -0400 Received: from mail-qv1-xf32.google.com (mail-qv1-xf32.google.com [IPv6:2607:f8b0:4864:20::f32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E30EF1BC3 for ; Thu, 15 Jun 2023 09:16:15 -0700 (PDT) Received: by mail-qv1-xf32.google.com with SMTP id 6a1803df08f44-62fec6068bbso9856876d6.2 for ; Thu, 15 Jun 2023 09:16:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686845775; x=1689437775; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=6yWsfiUJJCvl+Wv0FctXyQzF721u6gSJIygDxkbWkMk=; b=E4KlQwbQ++CSrrIZdif35vuUr+DGSfR63orJ/lJntfMtLnLHuyAUocoz6tWuUWKpbe Df7w2DZdy019+oLj8Snsp7hIGq/BjzIP9i6PsgWe4OliXMtYZ6oCSmCMeWDbSgKwe5wx w5iSYk+aI2ecG+MiT1GzYOw4L9IElOLFLq704Aq9DGx3JFdc8I9dtrLXf8F0lZPh5/BP pjDzPrQTfC1Ytgscjig9fe6bGkA13hbvNXrBGJQmOLkX0e06AKj4zVxtc/Ca+8u5Ybmw qFMfXowsUp8pslXe7mvpcM5e7c+YU6+ZIC62a+zodr+tGKJg54eYT6aTStLzHLEFsBLr Vj1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686845775; x=1689437775; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6yWsfiUJJCvl+Wv0FctXyQzF721u6gSJIygDxkbWkMk=; b=OuhL7JxohPle85fKKUL3zRQZT6J1mAmRQ+h/yT9brVNMRNAJlDTtAnvxDmul5Zj1PX 9ce87wDBu39mWzRvKsg0dOji/sSyW9EzTHZh7uiblvVDyK8iKJGP0yJgE0FZ3jbOAGg8 ZCTb/8JvFGnk1NcYuus7u7evwWUrYPejiw0uptHmQ2PNHSvGL1iVGqK2KcD3Hd0eQ6Ft 3p/lit+s1kjCrFqn/V/AXCwH0qUmS65eyUx3RJ5MzH4kIdtGYucbN1nA3+pZL+HWMyQC B8iz18X2/5k5yN84c3ujHYLv3gXitSHakrjwADwF5X03ky2n+kD69HczE8JzN6hpXrpX Bd1A== X-Gm-Message-State: AC+VfDzzr4gXP4b2HryzBQF7likUslFnw+qIDuXb2ee07o+bYJd4vMm5 X/mBbpBWz7yGMG0LIvxBuI1yWqRO5R3Q9mUnQXLmRg== X-Google-Smtp-Source: ACHHUZ5rkNC7B8YRnDNzfvuAiPiPsqY5+hNHIigtI5y5xhEvASIbbl1WVbYh/O9KrpkeHQGLHg+UO7kJGyjiOqqSTcA= X-Received: by 2002:ad4:5ba6:0:b0:626:1b8f:4940 with SMTP id 6-20020ad45ba6000000b006261b8f4940mr22082159qvq.23.1686845775002; Thu, 15 Jun 2023 09:16:15 -0700 (PDT) MIME-Version: 1.0 References: <20230602161246.1855448-1-amit.pundir@linaro.org> <358c69ad-fa8a-7386-fe75-92369883ee48@leemhuis.info> <0f6c9dcb-b7f6-fff9-6bed-f4585ea8e487@linaro.org> <0ec6c988-d678-c96c-a7a2-af38e6701404@linaro.org> In-Reply-To: From: Amit Pundir Date: Thu, 15 Jun 2023 21:45:38 +0530 Message-ID: Subject: Re: [PATCH] arm64: dts: qcom: sdm845-db845c: Move LVS regulator nodes up To: Krzysztof Kozlowski Cc: Linux regressions mailing list , Mark Brown , Doug Anderson , Bjorn Andersson , Andy Gross , Rob Herring , Konrad Dybcio , Krzysztof Kozlowski , Caleb Connolly , Conor Dooley , linux-arm-msm , dt , lkml Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 15 Jun 2023 at 21:39, Amit Pundir wrote: > > On Thu, 15 Jun 2023 at 20:33, Krzysztof Kozlowski > wrote: > > > > On 15/06/2023 15:47, Amit Pundir wrote: > > > On Thu, 15 Jun 2023 at 00:38, Amit Pundir wrote: > > >> > > >> On Thu, 15 Jun 2023 at 00:17, Krzysztof Kozlowski > > >> wrote: > > >>> > > >>> On 14/06/2023 20:18, Linux regression tracking (Thorsten Leemhuis) wrote: > > >>>> On 02.06.23 18:12, Amit Pundir wrote: > > >>>>> Move lvs1 and lvs2 regulator nodes up in the rpmh-regulators > > >>>>> list to workaround a boot regression uncovered by the upstream > > >>>>> commit ad44ac082fdf ("regulator: qcom-rpmh: Revert "regulator: > > >>>>> qcom-rpmh: Use PROBE_FORCE_SYNCHRONOUS""). > > >>>>> > > >>>>> Without this fix DB845c fail to boot at times because one of the > > >>>>> lvs1 or lvs2 regulators fail to turn ON in time. > > >>>> > > >>>> /me waves friendly > > >>>> > > >>>> FWIW, as it's not obvious: this... > > >>>> > > >>>>> Link: https://lore.kernel.org/all/CAMi1Hd1avQDcDQf137m2auz2znov4XL8YGrLZsw5edb-NtRJRw@mail.gmail.com/ > > >>>> > > >>>> ...is a report about a regression. One that we could still solve before > > >>>> 6.4 is out. One I'll likely will point Linus to, unless a fix comes into > > >>>> sight. > > >>>> > > >>>> When I noticed the reluctant replies to this patch I earlier today asked > > >>>> in the thread with the report what the plan forward was: > > >>>> https://lore.kernel.org/all/CAD%3DFV%3DV-h4EUKHCM9UivsFHRsJPY5sAiwXV3a1hUX9DUMkkxdg@mail.gmail.com/ > > >>>> > > >>>> Dough there replied: > > >>>> > > >>>> ``` > > >>>> Of the two proposals made (the revert vs. the reordering of the dts), > > >>>> the reordering of the dts seems better. It only affects the one buggy > > >>>> board (rather than preventing us to move to async probe for everyone) > > >>>> and it also has a chance of actually fixing something (changing the > > >>>> order that regulators probe in rpmh-regulator might legitimately work > > >>>> around the problem). That being said, just like the revert the dts > > >>>> reordering is still just papering over the problem and is fragile / > > >>>> not guaranteed to work forever. > > >>>> ``` > > >>>> > > >>>> Papering over obviously is not good, but has anyone a better idea to fix > > >>>> this? Or is "not fixing" for some reason an viable option here? > > >>>> > > >>> > > >>> I understand there is a regression, although kernel is not mainline > > >>> (hash df7443a96851 is unknown) and the only solutions were papering the > > >>> problem. Reverting commit is a temporary workaround. Moving nodes in DTS > > >>> is not acceptable because it hides actual problem and only solves this > > >>> one particular observed problem, while actual issue is still there. It > > >>> would be nice to be able to reproduce it on real mainline with normal > > >>> operating system (not AOSP) - with ramdiks/without/whatever. So far no > > >>> one did it, right? > > >> > > >> No, I did not try non-AOSP system yet. I'll try it tomorrow, if that > > >> helps. With mainline hash. > > > > > > Hi, here is the crash report on db845c running vanilla v6.4-rc6 with a > > > debian build https://bugs.linaro.org/attachment.cgi?id=1142 > > > > > > And fwiw here is the db845c crash log with AOSP running vanilla > > > v6.4-rc6 https://bugs.linaro.org/attachment.cgi?id=1141 > > > > > > Regards, > > > Amit Pundir > > > > > > PS: rootfs in this bug report doesn't matter much because I'm loading > > > all the kernel modules from a ramdisk and in the case of a crash the > > > UFS doesn't probe anyway. > > > > I just tried current next with defconfig (I could not find your config, > > neither here, nor in your previous mail thread nor in bugzilla). Also > > with REGULATOR_QCOM_RPMH as module. > > > > I tried also v6.4-rc6 - also defconfig with default and module > > REGULATOR_QCOM_RPMH. > > > > All the cases work on my RB3 - no warnings reported. > > > > If you do not use defconfig, then in all reports please mention the > > differences (the best) or at least attach it. > > Argh.. Sorry about that. Big mistake from my side. I did want to > upload my defconfig but forgot. Defconfig plays a key role because, as > I mentioned in one of my previous email, it is a timing/race bug and > if I do any much changes in my defconfig (i.e. enable ftrace for > example or as little as add printk in qcom_rpmh_regulator code) then I > can't reproduce this bug. So needless to say that I can't reproduce > this bug with default arm64 defconfig. > > Please find my custom (but upstream) defconfig here > https://bugs.linaro.org/attachment.cgi?id=1143 and prebuilt binaries > here https://people.linaro.org/~amit.pundir/db845c-userdebug/rpmh_bug/. > "fastboot flash boot ./boot.img-6.4-rc6 reboot" and/or a few (<5) > reboots should be enough to trigger the crash. > > I have downloaded the initrd from here > https://snapshots.linaro.org/96boards/dragonboard845c/linaro/debian/569/initrd.img-5.15.0-qcomlt-arm64 > but edited ramdisk/init to run "load_module" function early in the > boot and ramdisk/conf/initramfs.conf has "MODULES=list" instead of > "MODULES=most", where all the kernel modules are listed at > /etc/initramfs-tools/modules. Sorry it is ramdisk/conf/modules not ramdisk/etc/initramfs-tools/modules. > > Regards, > Amit Pundir