From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 308D4C433DB for ; Fri, 5 Feb 2021 13:23:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D447964FC0 for ; Fri, 5 Feb 2021 13:23:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229565AbhBENWe (ORCPT ); Fri, 5 Feb 2021 08:22:34 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37578 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229989AbhBENQh (ORCPT ); Fri, 5 Feb 2021 08:16:37 -0500 Received: from mail-yb1-xb2c.google.com (mail-yb1-xb2c.google.com [IPv6:2607:f8b0:4864:20::b2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A809CC0613D6 for ; Fri, 5 Feb 2021 05:15:57 -0800 (PST) Received: by mail-yb1-xb2c.google.com with SMTP id s61so6712182ybi.4 for ; Fri, 05 Feb 2021 05:15:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eMddkzoLtzudk6Saw9haOw0jx/RFJpF2riNKCfwuqgA=; b=RF4nwrg/bI2QEh/WsUpLibjI3mQomXHb2vuTc+uJUHticYqHRHVZN4pY7kach2qUP3 b2ivhKJ38YAJghUzI2MwT8xBhEbUWyI0TmRmDSecrz6bXz6mpYM7dzVlnIOmK4Z89ffa FfASdFuLG72rqoDVYfG/5MJfikNWmyVgqKX3FHsq+gb0ivvHYmDuabct6s07+8xD2MX1 CL+QIU4OwpqVWWzzVusw0VYq912podjjaSzg8cBxTX6i6QyvRR4SWdRbnCRMXta7Z8w0 kCqjWhdpHJUMPxBHj764KNf+HLxSGxHKWW3mEP1d3K4yOmwDsN2y2uIGZ/a+iXonm9q6 sQ3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eMddkzoLtzudk6Saw9haOw0jx/RFJpF2riNKCfwuqgA=; b=Pe3K7fZr0Sc/egvWGx6Z/Z+FT2zSYAc+9aCiMN5L+eR5pdovXPsf8qQ7OzCZLEICs7 Lv+OS/G7nRwZSrv308/L4KqmIeQu89sckNRdV4mBp8qU3k0Eu0O+U+dxn/TKyRoXXyoy nbiZsqso8OImp/66lmbTp/WO1gwrQqeVVPNlZWXpHvEbqgzRspV6BQ1J8KKQuJ3ikYdS 33hjm3wOik21D8hgz8wRZKQ6cixVypuBD6+Ivj5yBBH2Jx8hUxZPHYEljrKX3gYfLIY8 Q5e6sarQ06GDoFdCglbbb+JQGzTEzarYE3iibNZa1YZ7aRb3bGkvAV1UHAKe2GUGfr7w h1MA== X-Gm-Message-State: AOAM5323hv0wsir9omM2rR8Sjaks2cCzfgbYXlLb0vFMzpof3Laf9MTp jc3ysXHUn4VXv7512hnNW5P5y1g7txtlzHuY5QUOjw== X-Google-Smtp-Source: ABdhPJyhGAXEhx3VeGUjX84AVY7g2N8qPiWTR3n4heInBOto2Tcb4lOfLcSIy1g6eC9M61iOlCDdJrlNah6gn/LAJa8= X-Received: by 2002:a25:41cb:: with SMTP id o194mr5820275yba.167.1612530956948; Fri, 05 Feb 2021 05:15:56 -0800 (PST) MIME-Version: 1.0 References: <1612426177-6611-1-git-send-email-amit.pundir@linaro.org> <889e6ed8-133a-9416-be3b-5b2a97ea7fbb@somainline.org> In-Reply-To: <889e6ed8-133a-9416-be3b-5b2a97ea7fbb@somainline.org> From: Amit Pundir Date: Fri, 5 Feb 2021 18:45:21 +0530 Message-ID: Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-xiaomi-beryllium: Add DSI and panel bits To: Konrad Dybcio Cc: Andy Gross , Bjorn Andersson , Rob Herring , John Stultz , Sumit Semwal , linux-arm-msm , dt , lkml , phone-devel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Konrad, On Thu, 4 Feb 2021 at 19:46, Konrad Dybcio wrote: > > Hi! > > >vreg_l14a_1p88: ldo14 { > >+ regulator-min-microvolt = <1800000>; > >+ regulator-max-microvolt = <1800000>; > > Should probably be renamed to vreg_l14a_1p8 then. ack. > > > >+ ports { > >+ port@1 { > >+ endpoint { > >+ remote-endpoint = <&tianma_nt36672a_in_0>; > >+ data-lanes = <0 1 2 3>; > >+ }; > >+ }; > >+ }; > > The endpoint has a label, you can simply use &dsi0_out {};. I didn't get what you meant there. Care to point to some reference dts snippet please? > > >+ vddpos-supply = <&lab>; > >+ vddneg-supply = <&ibb>; > > With Angelo's latest series [1] merged in, I reckon you should explicitly configure lab/ibb (like in [2]), > as wrong settings (which CAN BE SET BY THE BOOTLOADER in some instances!!) can lead to hardware damage. So iirc in the case of beryllium device, these regulators are pre set by the bootloader and I can't find any reference of we setting/resetting it explicitly to switch ON the panel and display. So far default lab/ibb nodes are working fine for us and I'm hesitant to tinker around anything regulator related that can potentially damage the hardware. Having said that, I do see lab/ibb nodes being set in the downstream dts, with relevant soft-start and discharge-resistor properties and I can try switching to that once the new lab/ibb changes land upstream. Regards, Amit Pundir > > > > Konrad > > [1] https://lore.kernel.org/linux-arm-msm/20210119174421.226541-1-angelogioacchino.delregno@somainline.org/ > [2] https://github.com/SoMainline/linux/commit/4f4853b2e252b5f9d03e90119110aac80258fc53