From: Nathan Hebert <nhebert@chromium.org>
To: Rob Clark <robdclark@gmail.com>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
linux-firmware@kernel.org, linux-arm-msm@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Fritz Koenig <frkoenig@chromium.org>,
Vikash Garodia <vgarodia@qti.qualcomm.com>
Subject: Re: [PULL V2]: qcom: SC7180 and SC7280 venus firmware updates
Date: Tue, 25 Oct 2022 13:58:10 -0700 [thread overview]
Message-ID: <CANHAJhEWXf8U-FJJbOUpRV1gCXsd++H8kzbiBP1Z7iryaOCoYQ@mail.gmail.com> (raw)
In-Reply-To: <CAF6AEGs3RoB7zm8NjgsHMfqGY=-+etr8-EEuZw1MPUaXbDBy_A@mail.gmail.com>
On Tue, Oct 25, 2022 at 7:24 AM Rob Clark <robdclark@gmail.com> wrote:
>
> On Mon, Oct 24, 2022 at 4:13 PM Nathan Hebert <nhebert@chromium.org> wrote:
> >
> > On Thu, Oct 20, 2022 at 11:02 AM Dmitry Baryshkov
> > <dmitry.baryshkov@linaro.org> wrote:
> > >
> > > On Thu, 20 Oct 2022 at 20:08, Nathan Hebert <nhebert@chromium.org> wrote:
> > > >
> > > > The following changes since commit 48407ffd7adb9511701547068b1e6f0956bd1c94:
> > > >
> > > > cnm: update chips&media wave521c firmware. (2022-10-17 10:20:43 -0400)
> > > >
> > > > are available in the Git repository at:
> > > >
> > > > https://github.com/nathan-google/linux-firmware.git
> > > > update_sc7180_and_sc7280_firmwares_v2
> > > >
> > > > for you to fetch changes up to 054271e4164b6b4c069a3aaaeb9bfcde8c850339:
> > > >
> > > > qcom: update venus firmware files for VPU-2.0 (2022-10-20 09:37:35 -0700)
> > > >
> > > > ----------------------------------------------------------------
> > > > Nathan Hebert (3):
> > > > qcom: update venus firmware files for v5.4
> > > > qcom: remove split SC7280 venus firmware images
> > > > qcom: update venus firmware files for VPU-2.0
> > > >
> > > > WHENCE | 17 ++---------------
> > > > qcom/venus-5.4/venus.b00 | Bin 212 -> 212 bytes
> > > > qcom/venus-5.4/venus.b01 | Bin 6808 -> 6808 bytes
> > > > qcom/venus-5.4/venus.b02 | Bin 873596 -> 875020 bytes
> > > > qcom/venus-5.4/venus.b03 | Bin 33792 -> 33896 bytes
> > > > qcom/venus-5.4/venus.mbn | Bin 919708 -> 921236 bytes
> > > > qcom/venus-5.4/venus.mdt | Bin 7020 -> 7020 bytes
> > > > qcom/vpu-2.0/venus.b00 | Bin 692 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b01 | Bin 7376 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b02 | Bin 300 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b03 | Bin 20 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b04 | Bin 20 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b05 | Bin 20 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b06 | Bin 20 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b07 | Bin 24 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b08 | Bin 16 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b09 | Bin 939184 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b10 | Bin 42976 -> 0 bytes
> > > > qcom/vpu-2.0/venus.b19 | 1 -
> > > > qcom/vpu-2.0/venus.mbn | Bin 2031188 -> 2031620 bytes
> > > > qcom/vpu-2.0/venus.mdt | Bin 8068 -> 0 bytes
> > > > 21 files changed, 2 insertions(+), 16 deletions(-)
> > > > delete mode 100644 qcom/vpu-2.0/venus.b00
> > > > delete mode 100644 qcom/vpu-2.0/venus.b01
> > > > delete mode 100644 qcom/vpu-2.0/venus.b02
> > > > delete mode 100644 qcom/vpu-2.0/venus.b03
> > > > delete mode 100644 qcom/vpu-2.0/venus.b04
> > > > delete mode 100644 qcom/vpu-2.0/venus.b05
> > > > delete mode 100644 qcom/vpu-2.0/venus.b06
> > > > delete mode 100644 qcom/vpu-2.0/venus.b07
> > > > delete mode 100644 qcom/vpu-2.0/venus.b08
> > > > delete mode 100644 qcom/vpu-2.0/venus.b09
> > > > delete mode 100644 qcom/vpu-2.0/venus.b10
> > > > delete mode 100644 qcom/vpu-2.0/venus.b19
> > > > delete mode 100644 qcom/vpu-2.0/venus.mdt
> > >
> > > As I wrote in another email thread, it might be better to drop split
> > > files, add only venus.mbn and then use Link: lines to create venus.mdt
> > > -> venus.mbn symlinks.
> > Thanks for the feedback. There was some concern from Vikash at Qualcomm
> > about making a change to the venus-5.4 firmware to drop the split files.
> >
> > Vikash, are you able to comment about whether or not it is a concern to replace
> > the venus.mdt and split files with a symbolic link to venus.mdn for
> > the venus-5.4
> > files? I tested the suggested approach on ChromeOS with kernels based on 5.4
> > and 5.15 and did not see any issues.
> >
> > This is a holiday week, so his response may be slow.
> >
>
> The symlink trick that Dmitry suggested would cover the case that
> Vikash is concerned about.
>
> BR,
> -R
Thanks Rob, Dmitry, and Vikash for the feedback. I have sent a V3 pull
request that incorporates Dmitry's suggestion to the linux-firmware
mailing list.
BR,
Nathan
prev parent reply other threads:[~2022-10-25 20:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-20 17:07 [PULL V2]: qcom: SC7180 and SC7280 venus firmware updates Nathan Hebert
2022-10-20 18:02 ` Dmitry Baryshkov
2022-10-24 23:13 ` Nathan Hebert
2022-10-25 14:24 ` Rob Clark
2022-10-25 20:58 ` Nathan Hebert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANHAJhEWXf8U-FJJbOUpRV1gCXsd++H8kzbiBP1Z7iryaOCoYQ@mail.gmail.com \
--to=nhebert@chromium.org \
--cc=andersson@kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=frkoenig@chromium.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-firmware@kernel.org \
--cc=robdclark@gmail.com \
--cc=vgarodia@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).