From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 440A1C11F66 for ; Mon, 28 Jun 2021 23:45:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 24BAD61CAD for ; Mon, 28 Jun 2021 23:45:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234743AbhF1Xr2 (ORCPT ); Mon, 28 Jun 2021 19:47:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47278 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234680AbhF1XrZ (ORCPT ); Mon, 28 Jun 2021 19:47:25 -0400 Received: from mail-vk1-xa2e.google.com (mail-vk1-xa2e.google.com [IPv6:2607:f8b0:4864:20::a2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA507C061766 for ; Mon, 28 Jun 2021 16:44:56 -0700 (PDT) Received: by mail-vk1-xa2e.google.com with SMTP id k140so1309980vkk.6 for ; Mon, 28 Jun 2021 16:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=K+u9zamzkTK0tcOtoSmHBJMw1wdjgvet+oYikY+vPpw=; b=gHLbIqQSZA+sYnsVzhDgRcVbz0BRC2ayMuV17e7qZzEMN4HF7dGJqkddBXrMM4rghH GeoQQojrKE9FUO/96fJpvJ2tOoQooUQ3iwBawTeKxoxyRmQWpCw0i7GfqY+OyikgTU11 SFjZOVK0ZexOcYN4FekunaLJlFEWU2wL6ijfU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=K+u9zamzkTK0tcOtoSmHBJMw1wdjgvet+oYikY+vPpw=; b=bqQdxUlYqaoaz1wuibH+vbmUr7ido2fddyK0YHSfW5gnJC6S1QOlLPQxwXVi+CsddR Wy2Ei98eAExyedyDFzICMEJ0r4Hm631CFrd1AL6tgOF8P3VB5bGmTKXqX+Q4s8cq0JVw IT5mjbT/4FujNFRrYn0ErMQDnb07Omo378k5IBZmvoxODvJlqn1T/yk/nxpQruMQee2c rQQwFHltRM21CMieUpTrOC44twkspALkzekvHxEnLccRq3QteXa+Q0Mt1Y4hkpDCTRDM c5kNpwtO8kf2Y1fQgnAOfE+alxn4FVULLiXPDYfmf8m6a09VTtXsaS1Ru6aRYVxkzNIB 0JlQ== X-Gm-Message-State: AOAM530wevUwWUCrZtgGY3DH0h501PxN0zIc+YT7O3HPsZV1ZDkmqkKx WPBNL3/9EpiZLOWDxotzUXkbZ/cN9pQYCKjqXMnNzQ== X-Google-Smtp-Source: ABdhPJzu8m7WzPUvBstEnrLdEWviDthvRrwmL0ifVahCxK9zdAzvpMQjspmMVmZthMZJ0Wl9qUBJ9r+Xqn08qNV929U= X-Received: by 2002:a1f:4582:: with SMTP id s124mr19508263vka.10.1624923895693; Mon, 28 Jun 2021 16:44:55 -0700 (PDT) MIME-Version: 1.0 References: <20210211113309.1.I629b2366a6591410359c7fcf6d385b474b705ca2@changeid> In-Reply-To: From: Nicolas Boichat Date: Tue, 29 Jun 2021 07:44:44 +0800 Message-ID: Subject: Re: [PATCH] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features To: Linus Walleij Cc: Andrzej Hajda , Robert Foss , Chun-Kuang Hu , Daniel Vetter , David Airlie , Emil Velikov , Inki Dae , Jernej Skrabec , Jonas Karlman , Joonyoung Shim , Jordan Crouse , Krzysztof Kozlowski , Kyungmin Park , Laurent Pinchart , Maarten Lankhorst , Matthias Brugger , Maxime Ripard , Neil Armstrong , Philipp Zabel , Rajendra Nayak , Rikard Falkeborn , Rob Clark , Sam Ravnborg , Sean Paul , Seung-Woo Kim , Thierry Reding , Thomas Zimmermann , Viresh Kumar , Xin Ji , "open list:DRM PANEL DRIVERS" , freedreno , Linux ARM , MSM , "linux-kernel@vger.kernel.org" , "moderated list:ARM/Mediatek SoC support" , linux-samsung-soc Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Mon, Jun 28, 2021 at 7:10 PM Linus Walleij wrote: > > On Wed, Mar 3, 2021 at 11:31 AM Nicolas Boichat wrote: > > On Mon, Mar 1, 2021 at 4:59 PM Linus Walleij wrote: > > > > > dsi->mode_flags = > > > > MIPI_DSI_CLOCK_NON_CONTINUOUS | > > > > - MIPI_DSI_MODE_EOT_PACKET; > > > > + MIPI_DSI_MODE_NO_EOT_PACKET; > > > > > > Same, just delete the flag. > > > > > > These are all just semantic bugs due to the ambiguity of the flags, it is > > > possible to provide a Fixes: flag for each file using this flag the wrong way > > > but I dunno if it's worth it. > > > > Wow nice catch. > > > > I think we should fix all of those _before_ my patch is applied, with > > proper Fixes tags so that this can be backported to stable branches, > > even if it's a no-op. I can look into it but that may take a bit of > > time. > > This is fixed now, please will you proceed with this patch, because I > really like it! Thanks for the ping, that fell off my radar, v2 on its way ,-) > Yours, > Linus Walleij