From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7EECC4338F for ; Tue, 27 Jul 2021 10:29:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9265E61131 for ; Tue, 27 Jul 2021 10:29:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236186AbhG0K3X (ORCPT ); Tue, 27 Jul 2021 06:29:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49314 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236195AbhG0K3U (ORCPT ); Tue, 27 Jul 2021 06:29:20 -0400 Received: from mail-ua1-x92d.google.com (mail-ua1-x92d.google.com [IPv6:2607:f8b0:4864:20::92d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48114C061764 for ; Tue, 27 Jul 2021 03:29:20 -0700 (PDT) Received: by mail-ua1-x92d.google.com with SMTP id t26so4690780uao.12 for ; Tue, 27 Jul 2021 03:29:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BNXOQOHHvkyOlpYQvBOMgkkH26gWwGd0okW8oi8QdqI=; b=VA9XBSq4CQhlCAZrPbTm3nskntRBag7xfqyt0l5ZRi4tj4r7Nwmj7cH8Q//ULvZ68Y 5rx6ds4fUh1cKyKjtK9DlDLoCmoMTBGuBTVGak7TJbutzKps51Gx+PW0a4zDeLzgCVRA 7v+taAWoRMIo4GLW7W31F6kuP0wNC9VL3N8Xk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BNXOQOHHvkyOlpYQvBOMgkkH26gWwGd0okW8oi8QdqI=; b=ImrFqOATqBQQgbO0RqBzA6F4bRFmnSk7XkAthtiRFjD323zAnoqbeTBaCS0H1srHlB c94DouAuZNGiTKbgMz47wktatuz4SjhtHnCxlMI1HlG67eh2WOkjBOunziyZGGfHuYWd eRkoyXEl33ns1QKYZBvKNpklaG96WijBbApV4R59IJ7GRTHyYCI8uiH30Quxzth29plI w3ox9ZjidAR1XdMs1uWvsbMVZOkRAbPe+NmGMSCsXQz5M3nmE9T0E9Tj9yDIxRFTiPx4 H/5neITMBWjOhUGuEePjy81K5e+Q1YvDDeppK/ou2UZEBZhNvYbCI+RT9kcW6jxCZy1f AO4Q== X-Gm-Message-State: AOAM533JPeOz4Shz7r4rrmwuvV8X2NxGtYe87mZCkGglgwT4t1rhzalX KP+Xz2ySBCbP/2VGEZYI5zsQdsFveQfdP5eBZ9xIiw== X-Google-Smtp-Source: ABdhPJyx7sQwhJ8UE8NDg2Kx4YHR88sGvEf5AH10FBKUxfscAE8LJuhcwnvw8wjRTLPiqyBoy6zqtE4uvHrV7c6EPNE= X-Received: by 2002:ab0:2641:: with SMTP id q1mr16151134uao.82.1627381759398; Tue, 27 Jul 2021 03:29:19 -0700 (PDT) MIME-Version: 1.0 References: <20210727094435.v3.1.I629b2366a6591410359c7fcf6d385b474b705ca2@changeid> In-Reply-To: From: Nicolas Boichat Date: Tue, 27 Jul 2021 18:29:08 +0800 Message-ID: Subject: Re: [PATCH v3] drm/dsi: Add _NO_ to MIPI_DSI_* flags disabling features To: Sam Ravnborg Cc: Neil Armstrong , David Airlie , Viresh Kumar , dri-devel , Jordan Crouse , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Andrzej Hajda , Joonyoung Shim , Jonathan Marek , Krzysztof Kozlowski , Jernej Skrabec , Tzung-Bi Shih , Adrien Grassein , Chun-Kuang Hu , Jonas Karlman , MSM , Yangtao Li , Abhinav Kumar , linux-samsung-soc , "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih , Hsin-Yi Wang , Matthias Brugger , Sean Paul , Xin Ji , linux-arm Mailing List , Rajendra Nayak , Thomas Zimmermann , Seung-Woo Kim , lkml , Robert Foss , Kyungmin Park , Yu Jiahua , Dmitry Baryshkov , freedreno Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jul 27, 2021 at 4:35 PM Sam Ravnborg wrote: > > Hi Nicolas, > On Tue, Jul 27, 2021 at 09:45:21AM +0800, Nicolas Boichat wrote: > > Many of the DSI flags have names opposite to their actual effects, > > e.g. MIPI_DSI_MODE_EOT_PACKET means that EoT packets will actually > > be disabled. Fix this by including _NO_ in the flag names, e.g. > > MIPI_DSI_MODE_NO_EOT_PACKET. > > > > Signed-off-by: Nicolas Boichat > > Reviewed-by: Linus Walleij > > Reviewed-by: Robert Foss > > Reviewed-by: Laurent Pinchart > > Reviewed-by: Andrzej Hajda > > Reviewed-by: Xin Ji # anx7625.c > > Reviewed-by: Abhinav Kumar # msm/dsi > > --- > > I considered adding _DISABLE_ instead, but that'd make the > > flag names a big too long. > > > > Generated with: > > flag=MIPI_DSI_MODE_VIDEO_HFP; git grep $flag | cut -f1 -d':' | \ > > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HFP/" {} > > flag=MIPI_DSI_MODE_VIDEO_HBP; git grep $flag | cut -f1 -d':' | \ > > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HBP/" {} > > flag=MIPI_DSI_MODE_VIDEO_HSA; git grep $flag | cut -f1 -d':' | \ > > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_VIDEO_NO_HSA/" {} > > flag=MIPI_DSI_MODE_EOT_PACKET; git grep $flag | cut -f1 -d':' | \ > > xargs -I{} sed -i -e "s/$flag/MIPI_DSI_MODE_NO_EOT_PACKET/" {} > > (then minor format changes) > > > > Changes in v3: > > - Added all R-b tags from v1 and v2 (hopefully didn't miss any). > > > > Changes in v2: > > - Rebased on latest linux-next, after some of the flags got fixed > > (Linus Walleij). > > Thanks for the update, applied to drm-misc-next. Thanks Sam! > > Sam