From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FF10C47404 for ; Mon, 7 Oct 2019 17:44:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 567DF2084D for ; Mon, 7 Oct 2019 17:44:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="rvVxfGOR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728079AbfJGRoR (ORCPT ); Mon, 7 Oct 2019 13:44:17 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:43087 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728031AbfJGRoR (ORCPT ); Mon, 7 Oct 2019 13:44:17 -0400 Received: by mail-wr1-f66.google.com with SMTP id j18so15539917wrq.10; Mon, 07 Oct 2019 10:44:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wW1V6y+LNxCMJgLglkcDUpnlWBml+CeBEdMclmrUkYs=; b=rvVxfGORMifDJp8Ave2inD37kzbiqQLr7LScpWwaxDoY2oe8K8T14vLH/jcwdQREB2 I+SVlPfVMBDU0Y0skqn2jYbmoY74PZsq5VIy8ByI3pXLxYIMo+H8UTqfzEQItcmS3EZS KgyxkdToCbm6BMZoZkXyVU7XaN08QWcW0R30pAzr3hu0coUvIMUUyw9nbDfjFu5Kiy61 Cyr+wQI/f/0st5y46xGei1GiRHdbnxqcf7KvCZJGkk6+cBdn8wMMLf07m8Cd1a20WE28 92eyLz/2aJ6CHQOAT1ZbLsWcgZ6Hkbxcv0ogqQy6tZKR1WCcqzvZqB5jwnoaAssal4M5 Ks1w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wW1V6y+LNxCMJgLglkcDUpnlWBml+CeBEdMclmrUkYs=; b=i5wVwD9YqjVNSfMWiFcjlk6tB+pNNIt9Q4LRM6W1u6qAiaM4L+aOPyBx1T/xaA6kXA XZMPPfRDsjcpVInvfpBe7zCSXdXPnGt8B3xVdQf7PUua7AZSIBv2NAJiRmgYFSHMM6+B mxtFHFBIAxJxRwR5NUSWe8pgJJd3nB4cSSnIn911215P/OAflMtKVFZbVZC9dtAshA+P 4WIn6oeYkooFxiSaazlaBnRUwXr2TN8fB5xsGP3umyvqeRnmCfEMcHxZZd8xMOu3xTsL IBOnAR/Tmqn5YLF1w9n0zLk7eyuRYFrXg2E6gi4tgn8q4O97t90zclhmuyC73kQnw/bJ ga9A== X-Gm-Message-State: APjAAAXiU+cgVqskbs3lMqndOY+PdXrDIzu+h9hAcBGEqNkeCqTXiZwy TFUF1iEx3LMSr099ZRph+3myDFPNbKYOh1yZHLw= X-Google-Smtp-Source: APXvYqyBQEIoI2mpyfHmG2vJ8+RyfCMHGGYI93kPz9FtXQWOgikwjvB+30AaYJryXUffl4E+0n6tQgYqZhm5iF1/r34= X-Received: by 2002:a5d:4f0d:: with SMTP id c13mr24060562wru.317.1570470253994; Mon, 07 Oct 2019 10:44:13 -0700 (PDT) MIME-Version: 1.0 References: <20190724044906.12007-1-vkoul@kernel.org> <20190724044906.12007-2-vkoul@kernel.org> In-Reply-To: <20190724044906.12007-2-vkoul@kernel.org> From: John Stultz Date: Mon, 7 Oct 2019 10:44:02 -0700 Message-ID: Subject: Re: [PATCH v2 1/5] arm64: dts: qcom: sdm845: Add unit name to soc node To: Vinod Koul Cc: Andy Gross , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Linux Kernel Mailing List , Stephen Boyd , Amit Kucheria , Marc Gonzalez , Amit Pundir Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Jul 23, 2019 at 9:51 PM Vinod Koul wrote: > > We get a warning about missing unit name for soc node, so add it. > > arch/arm64/boot/dts/qcom/sdm845.dtsi:623.11-2814.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name > > Signed-off-by: Vinod Koul > Reviewed-by: Stephen Boyd > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 601cfb078bd5..e81f4a6d08ce 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -620,7 +620,7 @@ > method = "smc"; > }; > > - soc: soc { > + soc: soc@0 { > #address-cells = <2>; > #size-cells = <2>; > ranges = <0 0 0 0 0x10 0>; So Amit Pundir noted that this patch is causing 5.4-rc to no longer boot on db845 w/ AOSP, due to it changing the userland sysfs paths from "/devices/platform/soc/1a00000.mdss" to "/devices/platform/soc@0/1a00000.mdss" Is there a better solution here that might not break userspace? thanks -john