From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
To: Krzysztof Wilczynski <kw@linux.com>
Cc: Rob Clark <robdclark@gmail.com>, Sean Paul <sean@poorly.run>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Alexios Zavras <alexios.zavras@intel.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Allison Randal <allison@lohutok.net>,
MSM <linux-arm-msm@vger.kernel.org>,
"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
freedreno <freedreno@lists.freedesktop.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/msm/dsi: Move static keyword to the front of declarations
Date: Thu, 5 Sep 2019 08:26:39 -0600 [thread overview]
Message-ID: <CAOCk7Npab7Ffi1fKQ8p9s6_XbrGJaG6tTa7W2dXNqn+rrP2Onw@mail.gmail.com> (raw)
In-Reply-To: <20190904211551.10381-1-kw@linux.com>
On Wed, Sep 4, 2019 at 3:15 PM Krzysztof Wilczynski <kw@linux.com> wrote:
>
> Move the static keyword to the front of declarations
> of msm_dsi_v2_host_ops, msm_dsi_6g_host_ops and
> msm_dsi_6g_v2_host_ops, and resolve the following
> compiler warnings that can be seen when building
> with warnings enabled (W=1):
>
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:150:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:161:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> drivers/gpu/drm/msm/dsi/dsi_cfg.c:172:1: warning:
> ‘static’ is not at beginning of declaration [-Wold-style-declaration]
>
> Signed-off-by: Krzysztof Wilczynski <kw@linux.com>
Seems fine to me.
Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
prev parent reply other threads:[~2019-09-05 14:26 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-04 21:15 [PATCH] drm/msm/dsi: Move static keyword to the front of declarations Krzysztof Wilczynski
2019-09-05 14:26 ` Jeffrey Hugo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOCk7Npab7Ffi1fKQ8p9s6_XbrGJaG6tTa7W2dXNqn+rrP2Onw@mail.gmail.com \
--to=jeffrey.l.hugo@gmail.com \
--cc=airlied@linux.ie \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=kw@linux.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).