From: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
To: Rob Clark <robdclark@gmail.com>
Cc: "open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
Rob Clark <robdclark@chromium.org>,
David Airlie <airlied@linux.ie>,
MSM <linux-arm-msm@vger.kernel.org>,
Jordan Crouse <jcrouse@codeaurora.org>,
Abhinav Kumar <abhinavk@codeaurora.org>,
lkml <linux-kernel@vger.kernel.org>, Sean Paul <sean@poorly.run>,
Sibi Sankar <sibis@codeaurora.org>,
Daniel Vetter <daniel@ffwll.ch>,
freedreno <freedreno@lists.freedesktop.org>,
Chandan Uddaraju <chandanu@codeaurora.org>
Subject: Re: [Freedreno] [PATCH 3/3] drm/msm/dsi: make sure we have panel or bridge earlier
Date: Tue, 2 Jul 2019 14:30:39 -0600 [thread overview]
Message-ID: <CAOCk7NpyYSiDHP84E4bQiTA1Wk9Sd4w-F8-Zqu9tKtDoUTsFDw@mail.gmail.com> (raw)
In-Reply-To: <20190630131445.25712-4-robdclark@gmail.com>
On Sun, Jun 30, 2019 at 7:16 AM Rob Clark <robdclark@gmail.com> wrote:
> --- a/drivers/gpu/drm/msm/dsi/dsi_host.c
> +++ b/drivers/gpu/drm/msm/dsi/dsi_host.c
> @@ -1824,6 +1824,20 @@ int msm_dsi_host_init(struct msm_dsi *msm_dsi)
> goto fail;
> }
>
> + /*
> + * Make sure we have panel or bridge early, before we start
> + * touching the hw. If bootloader enabled the display, we
> + * want to be sure to keep it running until the bridge/panel
> + * is probed and we are all ready to go. Otherwise we'll
> + * kill the display and then -EPROBE_DEFER
> + */
> + if (IS_ERR(of_drm_find_panel(msm_host->device_node)) &&
> + !of_drm_find_bridge(msm_host->device_node)) {
> + pr_err("%s: no panel or bridge yet\n", __func__);
pr_err() doesn't seem right for a probe defer condition. pr_dbg?
> + return -EPROBE_DEFER;
> + }
> +
> +
Tested-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
Reviewed-by: Jeffrey Hugo <jeffrey.l.hugo@gmail.com>
next prev parent reply other threads:[~2019-07-03 1:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-30 13:14 [PATCH 0/3] drm/msm: few small cleanups Rob Clark
2019-06-30 13:14 ` [PATCH 1/3] drm/msm: don't open-code governor name Rob Clark
2019-07-11 18:46 ` Jordan Crouse
2019-06-30 13:14 ` [PATCH 2/3] drm/msm/dpu: remove dpu_mdss:hwversion Rob Clark
2019-07-11 18:47 ` [Freedreno] " Jordan Crouse
2019-06-30 13:14 ` [PATCH 3/3] drm/msm/dsi: make sure we have panel or bridge earlier Rob Clark
2019-07-02 20:30 ` Jeffrey Hugo [this message]
2019-07-02 21:29 ` [Freedreno] " Jeffrey Hugo
2019-07-04 6:39 ` Andrzej Hajda
2019-07-04 14:00 ` Rob Clark
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAOCk7NpyYSiDHP84E4bQiTA1Wk9Sd4w-F8-Zqu9tKtDoUTsFDw@mail.gmail.com \
--to=jeffrey.l.hugo@gmail.com \
--cc=abhinavk@codeaurora.org \
--cc=airlied@linux.ie \
--cc=chandanu@codeaurora.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jcrouse@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robdclark@chromium.org \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=sibis@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).