From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10964C433ED for ; Wed, 28 Apr 2021 16:39:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D173461418 for ; Wed, 28 Apr 2021 16:39:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231623AbhD1QkX (ORCPT ); Wed, 28 Apr 2021 12:40:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34864 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230243AbhD1QkX (ORCPT ); Wed, 28 Apr 2021 12:40:23 -0400 Received: from mail-qv1-xf35.google.com (mail-qv1-xf35.google.com [IPv6:2607:f8b0:4864:20::f35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 155FFC061573 for ; Wed, 28 Apr 2021 09:39:38 -0700 (PDT) Received: by mail-qv1-xf35.google.com with SMTP id a30so4338534qvb.12 for ; Wed, 28 Apr 2021 09:39:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+bqujsD1CEh1BMsQ6Vfhu0Dtl9EKMPvmnj/WQm5NOQY=; b=X5QjYOktKo0SOMzzXCGGEhJ1B+vtKaNQV8NPxuiFMVZI1s8N5Hsv83Svtsg50rgxqV Wme5k2pnWmXoL95EzEKY4g5itbI+wPpjl1gJvv8E9H6g6iahugJUDWBiswRZjV0HuMRk UKmaoLRN5K1bRs4417u9LHMJfv8sfU53FKwfI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+bqujsD1CEh1BMsQ6Vfhu0Dtl9EKMPvmnj/WQm5NOQY=; b=X61TeTTVJV8blHDTN/tMPBUtMmNy+npxLsFpeUZTlWE87GyLJD0rqGJ43uMZgo8g8r BLL9cUiA8Iu3YAsG7AWxAQbQxeP9hdTjWuKuK2ljRv5yWmwr5IWnmyJYsyWrVkp3m0XM YLbtwl0lxpszeFcB+r4f8TKalsT5DeuGvcYRt5ytX0XqygDxB4e6rMR2djVg+yXdQWFS t6x3U/Wf5oissRxf8DG2V9j5kILe4GHux3nsdM5aE2vllUUAPugA0BJZ/sxgPqK64VIn j1j+vW5KM40t0c3YGjxI8v9J9QxVd8RRBFH6V4mcz72mN3Xr/GZXhEJ2SGMLdX+oVw33 sv7Q== X-Gm-Message-State: AOAM530K7tUrsuFZhonhMsF14l6zh0eIlTNsLEIG+cJT8D3Ma20KjZ6n d6iWlOAtL/kFFzdLQ/LtCMeGBaTgLF/m+A== X-Google-Smtp-Source: ABdhPJy4udQsargIxT1q+BR6okQLJoSiwoI2Y5MEz53tf6Fbg6iKAPecq1fgp+UPDWAwSDRz5oDfFQ== X-Received: by 2002:ad4:5587:: with SMTP id e7mr22586418qvx.6.1619627977147; Wed, 28 Apr 2021 09:39:37 -0700 (PDT) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com. [209.85.219.177]) by smtp.gmail.com with ESMTPSA id c15sm385949qtg.31.2021.04.28.09.39.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 09:39:36 -0700 (PDT) Received: by mail-yb1-f177.google.com with SMTP id t94so21493829ybi.3 for ; Wed, 28 Apr 2021 09:39:36 -0700 (PDT) X-Received: by 2002:a25:382:: with SMTP id 124mr19702977ybd.25.1619627606430; Wed, 28 Apr 2021 09:33:26 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> In-Reply-To: <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> From: Sean Paul Date: Wed, 28 Apr 2021 12:32:48 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , robdclark@chromium.org, dri-devel , David Airlie , linux-arm-msm , Steev Klimaszewski , Stephen Boyd , Stanislav Lisovskiy , Thierry Reding , linux-i2c@vger.kernel.org, Bjorn Andersson , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Apr 23, 2021 at 12:59 PM Douglas Anderson wrote: > > In commit 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to > avoid excessive unprepare / prepare") we started using pm_runtime, but > my patch neglected to add the proper pm_runtime_disable(). Doh! Add > them now. > > Fixes: 3235b0f20a0a ("drm/panel: panel-simple: Use runtime pm to avoid excessive unprepare / prepare") > Reported-by: Bjorn Andersson Reviewed-by: Sean Paul > Signed-off-by: Douglas Anderson > --- > > Changes in v5: > - Missing pm_runtime_disable() patch new for v5. > > drivers/gpu/drm/panel/panel-simple.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index 6b22872b3281..9746eda6f675 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -797,12 +797,14 @@ static int panel_simple_probe(struct device *dev, const struct panel_desc *desc) > > err = drm_panel_of_backlight(&panel->base); > if (err) > - goto free_ddc; > + goto disable_pm_runtime; > > drm_panel_add(&panel->base); > > return 0; > > +disable_pm_runtime: > + pm_runtime_disable(dev); > free_ddc: > if (panel->ddc) > put_device(&panel->ddc->dev); > @@ -818,6 +820,7 @@ static int panel_simple_remove(struct device *dev) > drm_panel_disable(&panel->base); > drm_panel_unprepare(&panel->base); > > + pm_runtime_disable(dev); > if (panel->ddc) > put_device(&panel->ddc->dev); > > -- > 2.31.1.498.g6c1eba8ee3d-goog > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel