From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B0D8C433ED for ; Wed, 28 Apr 2021 16:51:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 578FD61400 for ; Wed, 28 Apr 2021 16:51:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241338AbhD1Qv7 (ORCPT ); Wed, 28 Apr 2021 12:51:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37606 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241342AbhD1Qv5 (ORCPT ); Wed, 28 Apr 2021 12:51:57 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EC7E8C061574 for ; Wed, 28 Apr 2021 09:51:11 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id n22so7583318qtk.9 for ; Wed, 28 Apr 2021 09:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=i7bjsRegze0J8KMBLsd6S1kBXzifIu76DMKQBA84MfE=; b=H6GvR/jJOzxy5yvUfCUkF+EMKldJel4VTzuxpNzjmhRH8YjlZLt2EzcmEoB9kuRTpp J+S1tttlyYfNfXCYv1VnThpaRAKe35vjhUfbxu7lWEsG6xkD6fpttoWrTCDJyaB4s1yh qpsFpp1ULXf6O5GRNrGy8VZodsPVr2ptimptY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=i7bjsRegze0J8KMBLsd6S1kBXzifIu76DMKQBA84MfE=; b=Inav0WD8IMItGjZ3Pw5aRaz5mChBaFsYVfFcOaC6PE9p6youYgOjnfHpETn6J8ah0t sWFbKaGwmzLahUI9fFu6hfGE7HolXLf2dl8u9pxbUHi9xqZ7LYgmkCOxO4rL23S1WoWG LGBmWQ1+og6fVlHYfRQ/jUBxePQqScyvwOIldXTV9YIleFaa4YDUrykioI3Qi9ondDVw ZdN6ruaKdnlAfJai8C05GykjxnF0WtYynJ9QwSZ/Yc+RwjZDjbTiWQxtpuFTSFAWXhHx Ljs+QvtYAQdWubTN4lOS/japcRe6zSWz3VffXfTDDH96QpO71FU9+CPax1eb6X8rdmHb 1aOQ== X-Gm-Message-State: AOAM533/mo5yNtzA997lsw658zLzL/URWkg1cIb9xwlAIP5J5v4RE1rA PeR2g0ETPHfP4o4THvKmkde0eyaLrCkj6g== X-Google-Smtp-Source: ABdhPJxlufCdx1v1YEQXXSwOO4+IVkhIyBeaVT3OU1Dd/sDHtdD+hcc3bYN0F8OsfxwUGzJv5HTKxg== X-Received: by 2002:ac8:5545:: with SMTP id o5mr29237743qtr.330.1619628670891; Wed, 28 Apr 2021 09:51:10 -0700 (PDT) Received: from mail-yb1-f182.google.com (mail-yb1-f182.google.com. [209.85.219.182]) by smtp.gmail.com with ESMTPSA id q10sm203666qke.55.2021.04.28.09.51.09 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Apr 2021 09:51:10 -0700 (PDT) Received: by mail-yb1-f182.google.com with SMTP id t94so21541292ybi.3 for ; Wed, 28 Apr 2021 09:51:09 -0700 (PDT) X-Received: by 2002:a25:778d:: with SMTP id s135mr31447093ybc.21.1619628668908; Wed, 28 Apr 2021 09:51:08 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.18.If050957eaa85cf45b10bcf61e6f7fa61c9750ebf@changeid> In-Reply-To: <20210423095743.v5.18.If050957eaa85cf45b10bcf61e6f7fa61c9750ebf@changeid> From: Sean Paul Date: Wed, 28 Apr 2021 12:50:30 -0400 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v5 18/20] drm/panel: panel-simple: Cache the EDID as long as we retain power To: Douglas Anderson Cc: Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , robdclark@chromium.org, dri-devel , David Airlie , linux-arm-msm , Steev Klimaszewski , Stephen Boyd , Stanislav Lisovskiy , Thierry Reding , linux-i2c@vger.kernel.org, Bjorn Andersson , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Apr 23, 2021 at 1:00 PM Douglas Anderson wrote: > > It doesn't make sense to go out to the bus and read the EDID over and > over again. Let's cache it and throw away the cache when we turn power > off from the panel. Autosuspend means that even if there are several > calls to read the EDID before we officially turn the power on then we > should get good use out of this cache. > I think i915 caches the edid once on init and never refreshes it (assuming no hotplugs). That said, I think it makes sense for a more conservative approach in panel-simple. > Signed-off-by: Douglas Anderson > Reviewed-by: Bjorn Andersson > --- > > (no changes since v1) > > drivers/gpu/drm/panel/panel-simple.c | 17 ++++++++++------- > 1 file changed, 10 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index a12dfe8b8d90..9be050ab372f 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -189,6 +189,8 @@ struct panel_simple { > struct gpio_desc *enable_gpio; > struct gpio_desc *hpd_gpio; > > + struct edid *edid; > + > struct drm_display_mode override_mode; > > enum drm_panel_orientation orientation; > @@ -345,6 +347,9 @@ static int panel_simple_suspend(struct device *dev) > regulator_disable(p->supply); > p->unprepared_time = ktime_get(); > > + kfree(p->edid); > + p->edid = NULL; > + > return 0; > } > > @@ -510,15 +515,13 @@ static int panel_simple_get_modes(struct drm_panel *panel, > > /* probe EDID if a DDC bus is available */ > if (p->ddc) { > - struct edid *edid; > - > pm_runtime_get_sync(panel->dev); > > - edid = drm_get_edid(connector, p->ddc); > - if (edid) { > - num += drm_add_edid_modes(connector, edid); > - kfree(edid); > - } > + if (!p->edid) > + p->edid = drm_get_edid(connector, p->ddc); > + > + if (p->edid) > + num += drm_add_edid_modes(connector, p->edid); I suppose this would keep banging on the ddc if drm_get_edid() continuously returns NULL, but maybe that's desireable (it'll succeed sometime in the future)? At any rate, this is an improvement on current behavior so it has my vote. Reviewed-by: Sean Paul > > pm_runtime_mark_last_busy(panel->dev); > pm_runtime_put_autosuspend(panel->dev); > -- > 2.31.1.498.g6c1eba8ee3d-goog > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel