From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5404C4CEC9 for ; Tue, 17 Sep 2019 09:18:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 92A5521897 for ; Tue, 17 Sep 2019 09:18:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oNed/+kk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727011AbfIQJS6 (ORCPT ); Tue, 17 Sep 2019 05:18:58 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:44580 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727009AbfIQJS5 (ORCPT ); Tue, 17 Sep 2019 05:18:57 -0400 Received: by mail-qk1-f193.google.com with SMTP id i78so3122954qke.11 for ; Tue, 17 Sep 2019 02:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Qk1/kEMCc7hdtCl5vveWWjPTyqEJHdmDX9cEtBBSrMo=; b=oNed/+kkOpBqzgWZvc8m2HoCUsR870bim/7U6M6ciIxMGGmQnC551uF2G+T6HjZMHn +tnBXLKaFDx//RH0OvknlYwyJjua5GUILPW76AwekbFW4gPNNHQWqlAH4s5xrNqkwCoB Wey4KwVBY8lZ0wjk/+/+9RyqneCmbw0VT5aIgRFL0GxyzK0CT8F88x3UA3dPNxET1fu/ OSZ7kE5axDPfK8IoDCxOgCJNiFdLhCO3p2wFfyEzUsfMeqmW1FsD2p9l9ZGWs/5739Nw OeoXkpjTP/5rN2yaGgIRa81J7wB6isbp9Y8NRB3FNE8afvWkC7TCs+fnOzWO8YMOXpU5 cn+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Qk1/kEMCc7hdtCl5vveWWjPTyqEJHdmDX9cEtBBSrMo=; b=dBGvumwZrhpGOMMCOCq1vdxC8tQia43rhpvkSpg1m0+P3dfNA9ffhDvZGNtGp0iRkA eROa4rF0Fsvsj57g6tSQmZCgHU1izXIuWAlqN02WmYScFKpxP+j/0dLqSrqZ0KoYy8Ci zQF2hb5iBv/OUnN68hdMuijSg+MBdqZjYm9fX25OAnsDhjMWXOmf9p0oiNSTXiq5FyMq fklkH8emR5I+nlg/zLECdoeFVnh5uGpLFf1jBDssvENtZDfrKaoKeW5M2WqDT+Pop/3d 6euOqH9Z4R+IjLzQcH6C2Hw/sD2+KpQfQU+x9cYWiVLdso+crwbh54K9xb557TcjlaRk kOKg== X-Gm-Message-State: APjAAAWTK7epFNJgLajnkdpLw3GVnp4dLqXbSp0AXAqGoRJ96YGBsWl2 kKp3JJwAeZWcWMwcHvcseR3K8zM7CMhHBdjQ+IMq5g== X-Google-Smtp-Source: APXvYqwsTYtRd0bAtTCshwktiNew7SgVScj0W0wJ6hvvFn22AcBW3g9dZ5tlXLrT4/NrL+dTsEI2JmRuYRQSgRLij8o= X-Received: by 2002:a37:6d2:: with SMTP id 201mr2596626qkg.106.1568711936825; Tue, 17 Sep 2019 02:18:56 -0700 (PDT) MIME-Version: 1.0 References: <97b6f861e6e6a2ac7b50efb7211f3c8e7fe872b0.1568240476.git.amit.kucheria@linaro.org> <6920d231-73cf-d83d-2cc7-f29e5f73192c@linaro.org> In-Reply-To: <6920d231-73cf-d83d-2cc7-f29e5f73192c@linaro.org> From: Amit Kucheria Date: Tue, 17 Sep 2019 14:48:45 +0530 Message-ID: Subject: Re: [PATCH 1/5] thermal: Initialize thermal subsystem earlier To: Daniel Lezcano Cc: Linux Kernel Mailing List , linux-arm-msm , Bjorn Andersson , Eduardo Valentin , Andy Gross , Taniya Das , Stephen Boyd , Lina Iyer , "Rafael J. Wysocki" , Viresh Kumar , Zhang Rui , Linux PM list Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Sep 17, 2019 at 1:30 AM Daniel Lezcano wrote: > > On 12/09/2019 00:32, Amit Kucheria wrote: > > From: Lina Iyer > > > > Now that the thermal framework is built-in, in order to facilitate > > thermal mitigation as early as possible in the boot cycle, move the > > thermal framework initialization to core_initcall. > > > > However, netlink initialization happens only as part of subsys_initcall. > > At this time in the boot process, the userspace is not available yet. So > > initialize the netlink events later in fs_initcall. > > Why not kill directly the netlink part, no one is using it in the kernel? That's a good point. I wasn't sure if anybody was using it, but I can remove it completely since no driver seems to be using the thermal_generate_netlink_event() api. Regards, Amit $ git grep thermal_generate_netlink_event Documentation/thermal/sysfs-api.rst:just need to call thermal_generate_netlink_event() with two arguments viz drivers/thermal/thermal_core.c:int thermal_generate_netlink_event(struct thermal_zone_device *tz, drivers/thermal/thermal_core.c:EXPORT_SYMBOL_GPL(thermal_generate_netlink_event); include/linux/thermal.h:extern int thermal_generate_netlink_event(struct thermal_zone_device *tz, include/linux/thermal.h:static inline int thermal_generate_netlink_event(struct thermal_zone_device *tz,