From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82516C1975A for ; Wed, 25 Mar 2020 15:44:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 598AD2073E for ; Wed, 25 Mar 2020 15:44:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iK5q0pYA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727773AbgCYPo6 (ORCPT ); Wed, 25 Mar 2020 11:44:58 -0400 Received: from mail-lj1-f193.google.com ([209.85.208.193]:41549 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727731AbgCYPo5 (ORCPT ); Wed, 25 Mar 2020 11:44:57 -0400 Received: by mail-lj1-f193.google.com with SMTP id n17so2958818lji.8 for ; Wed, 25 Mar 2020 08:44:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tXD0NIbBQHX+z9/5Cn5kHqlwTwqxUoD/Q190EABWTDY=; b=iK5q0pYAem2IC9HXIUCtWiUmOAneNwO6eapMhrlo9VLWa65nib3Eh+CzYBy8hLhorL sJ4Ms9eG4HklmPaumOYkym3iEypfey3ioMh+Mc6r/X19Mg1orDDY+UGlORpAE8tku7Nh 7gpopkJi24jMwYndQtn+iUf5ezVwgYYcdQSeIBhFo8isbCYnJrJ//SIkfBE8NVQuGkeE FZBlZH1Vf1AvT+2gJKE8uCmSZ594hEBMXA9G2KD/ZO5I7JRV/XFxF+OZjkP0q9edpq3+ Wm9FPFp5/Z+Ok9ICmPaZcJrNO3u4h+skHjnxo25GXnJpos3CSOSMUP2WU+ep05IltdLY GYaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tXD0NIbBQHX+z9/5Cn5kHqlwTwqxUoD/Q190EABWTDY=; b=DNycDzSrE3+nS87GMPG9VgG1r0kk/Mp3PbYYR5rzu73X9/LMy15ooMfdfZshCJW8gp mHFNo+59DDSibxHl6uoROAWaLWZhiahkGV/ipSPCPFPEJgcqJTHNqc5sPg4r489IsOie WtCjcDIOPyW0yP5wjNUTbgvZPq2fnfWgpuHq+UoURlCtErTDX+/qhZnCGEvmtx8kz0Fw fM8K/Y7JhAyCxV0Afd0N7LmkNKqUfZLsxCE7fo44M5rIHyesP4KX4FSy5DOxSMIN9JuU xofOqbfJEDsmi3esedHrg9g1/dP5kVnX8TURq9W6fntwKpPqKdMdhL6m86DFn7hGbD4y IFYg== X-Gm-Message-State: ANhLgQ1RpcuF3gzG6udizM3qrnx109yDmF7Z+gI3b+WSI1qfzvpZ6a/v f5ed7BvxkZFROJH+1Tbl9fUwxVpr+ljJnu5EyGDsQg== X-Google-Smtp-Source: ADFU+vv1RzjW7k7FmbN6HbpO06Hw8i+AT0m5YUev5QnYHDYHVSTJXBwOqWeX+HKNht/1FR17wexRpRGTCquA6m7QabQ= X-Received: by 2002:a2e:90c4:: with SMTP id o4mr2215674ljg.287.1585151095466; Wed, 25 Mar 2020 08:44:55 -0700 (PDT) MIME-Version: 1.0 References: <20200324180513.3882-1-robh@kernel.org> <20200324180513.3882-2-robh@kernel.org> In-Reply-To: <20200324180513.3882-2-robh@kernel.org> From: Amit Kucheria Date: Wed, 25 Mar 2020 21:14:44 +0530 Message-ID: Subject: Re: [PATCH 2/2] dt-bindings: thermal: tsens: Set 'additionalProperties: false' To: Rob Herring Cc: Daniel Lezcano , Andy Gross , Bjorn Andersson , Zhang Rui , linux-arm-msm , Linux PM list , DTML Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Mar 24, 2020 at 11:35 PM Rob Herring wrote: > > Ensure the node only contains the properties listed in the schema by > setting 'additionalProperties: false'. Doing this requires reworking the > interrupt properties schemas so that they are defined in the main > 'properties' section. Reviewed-by: Amit Kucheria > Fixes: a877e768f655 ("dt-bindings: thermal: tsens: Convert over to a yaml schema") > Cc: Andy Gross > Cc: Bjorn Andersson > Cc: Amit Kucheria > Cc: Zhang Rui > Cc: Daniel Lezcano > Cc: linux-arm-msm@vger.kernel.org > Cc: linux-pm@vger.kernel.org > Cc: devicetree@vger.kernel.org > Signed-off-by: Rob Herring > --- > .../bindings/thermal/qcom-tsens.yaml | 28 ++++++++++++------- > 1 file changed, 18 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > index 7a38d2116059..3492447e42e9 100644 > --- a/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > +++ b/Documentation/devicetree/bindings/thermal/qcom-tsens.yaml > @@ -46,6 +46,18 @@ properties: > - description: TM registers > - description: SROT registers > > + interrupts: > + minItems: 1 > + items: > + - description: Combined interrupt if upper or lower threshold crossed > + - description: Interrupt if critical threshold crossed > + > + interrupt-names: > + minItems: 1 > + items: > + - const: uplow > + - const: critical > + > nvmem-cells: > minItems: 1 > maxItems: 2 > @@ -88,22 +100,16 @@ allOf: > then: > properties: > interrupts: > - items: > - - description: Combined interrupt if upper or lower threshold crossed > + maxItems: 1 > interrupt-names: > - items: > - - const: uplow > + maxItems: 1 > > else: > properties: > interrupts: > - items: > - - description: Combined interrupt if upper or lower threshold crossed > - - description: Interrupt if critical threshold crossed > + minItems: 2 > interrupt-names: > - items: > - - const: uplow > - - const: critical > + minItems: 2 > > required: > - compatible > @@ -113,6 +119,8 @@ required: > - interrupt-names > - "#thermal-sensor-cells" > > +additionalProperties: false > + > examples: > - | > #include > -- > 2.20.1 >