From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF316C43331 for ; Fri, 6 Sep 2019 15:28:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AC00F2082C for ; Fri, 6 Sep 2019 15:28:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Jg4D3B8s" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403861AbfIFP2F (ORCPT ); Fri, 6 Sep 2019 11:28:05 -0400 Received: from mail-lj1-f196.google.com ([209.85.208.196]:36666 "EHLO mail-lj1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732456AbfIFP2F (ORCPT ); Fri, 6 Sep 2019 11:28:05 -0400 Received: by mail-lj1-f196.google.com with SMTP id l20so6402334ljj.3 for ; Fri, 06 Sep 2019 08:28:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=hbMU3iw6suD9Pa8NpBysxN0nHVf+3AA+w6KB+ur557E=; b=Jg4D3B8sAIRTKTDuClimaMSkTIkAwZCVhKloS7socUuIkOP35trTMY7w0oBbCU1o1s 8tikyGGNa73XbIifm59+RdFYWI57KfYKmlgKfp0BuKOmz/6R/wjepHrsMrwCHb6G92K3 gLYnulkj3G2BYqh2AjSfmZFfoFdZZNZPTHGQJgW5R8ONpBsg4sa0X1cxR8I0q9rGPmOq xvzy2myvQeIzPgWhm2I5S4Gl33PUfrLXL1/rS7ip6RMr06Z/Gdzz2zuWtH0ITbGAl+Ai RY/h5t80C9mrqxOQsRRHQ9SeS/lOBGjh7qYAM6gZq59geaXHCKZR8nwFglbF3nOGGfjf QXwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=hbMU3iw6suD9Pa8NpBysxN0nHVf+3AA+w6KB+ur557E=; b=SZK8Xi7JeKekP5ioSt0Q6JTZy55kitY6AIG9GATper3q3P1j1pO1WshjUBedMyjRrB kXzGOse9uGJJ9PK3FMvlxequRdqbxzi2f2737IScsw+cnQ6iP1/JifxQII2loRy5u/r/ RXwjrRiRCnP6TeYdK13VN9CjEXnmqlA/+uRbnDzFgNqNeT7gdTWEeH3m549GBjMA8NmT NIIj9fiEirgWOCuxW7jEFsyk22HmlCvIs6DWDcF5M2y6gXaC+MCdlqA6UYxrqvAM06iS acEA+a8qd1vRjFS6BNy3xT++L1wRd/2iliii3gIlbyHgF46ILPtMq1tN/94zlqh7IhFM PRnw== X-Gm-Message-State: APjAAAXY3mfUjpHfS0ka5ZfS0PR0XcLKb+VW7UEG4a3acmn+XSoF1geL q9e1tnp/gyf9EZRx9zYCg6PggcvrLxCiXqwITqtVoQ== X-Google-Smtp-Source: APXvYqygjznMFLLV5koxljvc/AmTD8IFpb6iCmQITWmi4irLDjdK/YEee+qEQJhA2ycRyRZGL0es0Dh1lUNECYau62k= X-Received: by 2002:a2e:1b02:: with SMTP id b2mr6089604ljb.211.1567783681216; Fri, 06 Sep 2019 08:28:01 -0700 (PDT) MIME-Version: 1.0 References: <20190904112653.22452-1-festevam@gmail.com> In-Reply-To: From: Nicolas Dechesne Date: Fri, 6 Sep 2019 17:27:49 +0200 Message-ID: Subject: Re: [PATCH] qcom: Add firmware files for Adreno A200 To: Chris Healy Cc: Josh Boyer , Fabio Estevam , Bjorn Andersson , Jordan Crouse , robdclark@chromium.org, Linux Firmware , Jonathan Marek , freedreno , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Sep 6, 2019 at 5:09 PM Chris Healy wrote: > > Hi All, > > I'll start by saying that I'm no expert on this subject! My > understanding with this Adreno 2xx firmware though is that these two > firmware files are generally equivalent to what was distributed > previously in an include file in the following two files for the NXP > i.MX51 and i.MX53 which utilize the Adreno 200: > > https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/mxc/amd-gpu/common/pm4_microcode.inl?h=imx_2.6.35_1.1.0_caf&id=61ade304d0eddc3f44fb2ee0b2b7ccf3ffcf85d5 > https://source.codeaurora.org/external/imx/linux-imx/tree/drivers/mxc/amd-gpu/common/pfp_microcode_nrt.inl?h=imx_2.6.35_1.1.0_caf&id=61ade304d0eddc3f44fb2ee0b2b7ccf3ffcf85d5 > > I'm not suggesting we don't get someone from qcom to provide a > Signed-off-by. I'm only pointing out that it looks like this firmware > was previously made available and that it did have a license that > perhaps we can continue to use for this firmware that's also for the > Adreno 200? I was not saying the firmware can't be distributed, I was just pointing out that most likely using LICENSE.qcom was wrong. I was involved when we created LICENSE.qcom and submitted it first, and I know that the i.MX firmware can't be distributed with these license terms. If the firmware have been released previously , especially on codeaurora.org then they are definitely good candidates for linux-firmware, but the license and WHENCE need to be adjusted accordingly. > > Regards, > > Chris > > On Wed, Sep 4, 2019 at 8:35 AM Josh Boyer wrote: > > > > On Wed, Sep 4, 2019 at 8:09 AM Nicolas Dechesne > > wrote: > > > > > > hi Fabio, > > > > > > On Wed, Sep 4, 2019 at 1:27 PM Fabio Estevam wrote: > > > > > > > > Add firmware files for Adreno A200. > > > > > > > > These firmware files are needed for running the adreno kernel > > > > driver on i.MX51 and i.MX53 SoCs. > > > > > > > > Signed-off-by: Fabio Estevam > > > > --- > > > > WHENCE | 2 ++ > > > > qcom/yamato_pfp.fw | Bin 0 -> 1156 bytes > > > > qcom/yamato_pm4.fw | Bin 0 -> 9220 bytes > > > > 3 files changed, 2 insertions(+) > > > > create mode 100644 qcom/yamato_pfp.fw > > > > create mode 100644 qcom/yamato_pm4.fw > > > > > > > > diff --git a/WHENCE b/WHENCE > > > > index a8ec628..5e46d33 100644 > > > > --- a/WHENCE > > > > +++ b/WHENCE > > > > @@ -4418,6 +4418,8 @@ File: qcom/a530_zap.b00 > > > > File: qcom/a530_zap.b01 > > > > File: qcom/a530_zap.b02 > > > > File: qcom/a530_zap.mdt > > > > +File: qcom/yamato_pfp.fw > > > > +File: qcom/yamato_pm4.fw > > > > > > Where did you get these files from in the first place? On which > > > devices do you expect these firmware files to work? We were recently > > > discussing how to structure /lib/firmware/qcom more carefully. And the > > > general consensus that we reached with Rob C. and Bjorn is that if a > > > firmware is expected to work on a specific device (maybe it is signed) > > > it should be placed in /lib/firmware/qcom/ and if it's > > > unsigned and can be used on several devices based on the same SoC (dev > > > boards, ..) then it should be /lib/firmware/qcom/. > > > > > > > > > > > Licence: Redistributable. See LICENSE.qcom and qcom/NOTICE.txt for details > > > > > > Are they really distributed under these license terms? That's a > > > specific license that we came up with with Qualcomm a couple of years > > > ago based on their Dragonboard offers. > > > > So everyone understands, I'm not pulling this for now. If there are > > questions on provenance of the firmware and the license it's under, > > that's a big red flag for me. Ideally we'd see someone from qcom add > > a Signed-off-by or otherwise acknowledge these are meant to be > > redistributable. > > > > josh > > > > > > diff --git a/qcom/yamato_pfp.fw b/qcom/yamato_pfp.fw > > > > new file mode 100644 > > > > index 0000000000000000000000000000000000000000..61a576eb997ce2ee0d32b135adc5d8c789d8e118 > > > > GIT binary patch > > > > literal 1156 > > > > zcmaKr%WG3X7{!10-ZY7A3K1$6=_76G1N!h4AK=1^>7q~ > > > znc9aU-RVwT2qFk+Q_@myY|Wy$6#N(5NpywGZ*xWlo-D@qsc1s > > > > zPiBZtq;Lo > > > zvx)jy!_iTK&JzB^96f&7=Jy2U|K?k+gt(ON1sa9FwHhv?DgHb|R9rnZ-6s0-6jM&z > > > > zb=By > > > > z8`b=UTDGpZL%olqwSLyuMi > > > z_Iu;H3)M*(Z_;Vjwjatfch;}iOVyu=r@M4c9_##P#7|+_;(b9#$`3g#E&H)G(&EW# > > > > zxHmG)zn>;t$l(^GuMl!ic#FAX%}uRm#-DUZ1hd+EFuQ1Z%pKHqw^N~=sumk-JviU7 > > > > z&1%0qeGi$+F4LlD>Nu(BfzF~^Ik@AK4f|)~+w9LSVPYeflWINSJtW>%jmAE-X`N`o > > > > z($Z#o#}~_Q`saDO4AgL=$zW+=$D6RMuoF#~Id3&ZPDx9}ei!DQJAO!1 > > > zw84=e&!8{|-Sa>8&3oD$%MmN&SySBjIZa%1lT+oXSj=m{xNPnN27?{z{g3~>S}*2o > > > > z+!Sjl6<_79MgKjLeBh|wK|hyBla<>kPV$Ih9y6j|j?+bkAujSpCsw$^Yp(K*QPvsb > > > > aBNKdPk}Yn^%`G{<%{x^na)+4oG>_jjN)4X? > > > > > > > > literal 0 > > > > HcmV?d00001 > > > > > > > > diff --git a/qcom/yamato_pm4.fw b/qcom/yamato_pm4.fw > > > > new file mode 100644 > > > > index 0000000000000000000000000000000000000000..b45ea20ba5773ef6da25e21abd29914ea9162c07 > > > > GIT binary patch > > > > literal 9220 > > > > zcmeHMU2I%O6+Y{%UFT-AU2k1ujB&@i>-9SF&jM9cEJ3bFYHh4aq;GvR>H~i&R3H_K > > > > z5Otf75}?qOh&)jG$6sG~=>rdaC@Ulc0tr>TAbx8k3J4@36+}TQTE1^)&b@QTyG{^A > > > > zykxAs_uMnzIdkUBnKM5Y5qZ}cBT_bfkhUc9lzsoTBr > > > zs{_iHp8Q-%V)C+gYfkUTJ!4MRB%QwUAG&=-Ns*Cy0@ > > > ztwX(3!185BGQ8wIk&&{-$_-A4Y>aKF61?{+{P@??#kOKQ^LA6hMQS3=y7wpO))1Zl > > > > z4D7E$WD54PTsoAGR|((X_sMs~^(&N}M1@Hf`yPPT-t-!tH{ho_iBb9%&={{2FL@Jw > > > > zjmWl>;L+7Fe;YiQwvT@&c#NSKe;0VuBltHD;qQPK_6wgf=KKEN*i1c)VcKc+RGqKt > > > > z6S<#>I26u{UJx^$9%38CWC1_pb;|!h=lJWSGxTBThvaqD|Gqxw-6&rn&pfEP$i=py > > > > z3uOR > > > zC_0{}$w#$jKJDM9dKPj$%b}k6T+djZZ{_ > > > zo6Us=Au^7isp}k{l$OseH-X<8%d?M2fBGzV@blB^XMAGr8@}AUp1IA^=kZ*cx!2}! > > > > zGRFOSL3(Y*@Wp8(&FUGs2$JKK@q0O+IU(btdy1$1%AXAQ^?)yi_%1lEoISc?3D|!r > > > > zwEyLv > > > z-($)Xj^k3*jVZ@^sqQdn>#Vj#|FryAe2bWw+z;VcG>#k8qNMQE_8EB&B*!A-b1Xcc > > > > zW0CRcbI)g6%C}?T`5X)7gB10@9hYrq4{ScCHWMRZZp601^6Vp(C-4S-=p6s}cp3YU > > > > zooxQ1L;XzFugmtkw%^Z|KkNAqpiw_x > > > zpQ~IenC~2r9|P~oj%;#JP+s)&9U+jlWyh;%XYx~v7I{_*`;GFSJ)int0d2=FlKt6m > > > > z*|AvG#zQ3gtKqVhSa!&op8R&WY!b^dUq!x6em`7xB9@&PBCD9lSCh(DU&+C-k > > > z{F+G+w%9M#{MgBuHalUIvv>KPKZ*BX-=dsGwo%I;&y > > > > zr#-KcVEO;q!(q0C_DsV6N5L7EXR7C8{{FK`=%2&Ts_We-oou)k=J_zU`!m!4 > > > zIs8W88x0pTXiGW`$ETi7G`||?3&Uy37*=E97HJnT > > > zWww;1u!pHAUv?Yq+_sfsyOp<42}-G!=c_~QeBC+h^~8QFW$otsWU6Y > > > z-)X!JPgi39XdgLeS;9W@TgMLkuZQuV{6C?AkY5gL!~SP3MLlGnP|TGVzWp1OrGA`` > > > > z=1w|HLI087uC0yE%X? > > > z`L&*TyH$7lG&w`s`L-Hhp!4BSr}}|rwCc|Pz?>h3c{4Cgzb7%EFPa9P?tItr?Lzi5 > > > > zDm!>Lbo%{34Y=maqQ%qxr5P7*wl99Zu=1PpnGIi5J?z)=w(FPGqx&N0(LL=^VAKz= > > > > z;d3fWo!ZAy{$Y{}WIsJjmU@1e+xDnpLfb^Tvc7qNP+O)}jeXO%8}D>uVHrW*h}OHx > > > > z{aHNh&sSDfvOAD$zr?jZjMZ*&{wAMPoxa_}z&E1(|2f4#|D#lhGUey>4CtnhG4f;C > > > > zhcj6hxBQGTpN%kVBF0<-hB?6;cY5sk#nTf3pL-<5Oa?UjrF<^hN*@Vmj#u37<;*rW > > > > zAKe~i5lAil=_i3fTzyT)-PZI>%C~K++US#>!cTqmH>glNF{|6}vA%WtoTC0`px+hO > > > > zclI~7^I2!Z > > > > zFb2?8AqUE;vzY=%dWJ8%Uy9p(LHp?Q+fBf!uXwkkG-Jcm8!2A4oUOUJ!$XqJQ;uVH > > > > ze}ZMX>Ca7r!Qe{JudpwWNb%FM|BOa|HmZvXz}uh8&{)IkpC!iUAI6F1SPDH-Gkn1? > > > > z@|_RitL*H?s&l6^e&Kwixt$o4z=%}(@Ei0zq~nXv!h9D$uXzut > > > zUh-=yv1RYrA3*N{zP{k%0kkX^@s(eAd}ThBUxKFowFQHxySG^m?o@eaNSzdk+nwj& > > > > z+OpSi?e5A!?fx!k_vHiHB}{W5e3j)!HWl0O7l0W*if8`UI|r^KYjXxq`uwHA`esjF > > > > z0iI*6c&?|4#}X9auK=ITDX9f_JMWFoYwUYyC+EBBk7H)s&nfUPXbb=@6FL8yVyRYh > > > > zF>lv9e@8?;v43uKV`SDhU97&kSiHynfxlM??PpF?`>DU{*9+z!< > > > z0ZRWoQpBXNl{JVNZ` > > > z5qBd|-_awhKb!CT)_ZvB)H}~TBs5ZyeBB+zX;}x~ > > > > zj&*^r7`Bq%!$dkOw?cMETb57B?o3ZMf#H6y>-T;(PW(L>`R!mI7@d6*%DR&F`5rr3 > > > > zycde>NlpOI9MxU0?sV<8d(s > > > zcrE$+I@0Yqw~r;gypYo?ZAWw8zT(eT@p($ubckkipZKLlmn@XBbo^Zt$D)(*;fszT > > > > z0ObJ8q_KztG5-EMwoPL=K6fWQ)yewM_W > > > > z2o#8Xp4>@UTT=Us&ShoIMT+@AhTrM)|B}jA3TMOWhco`JWrzQ#2=g8*E8frC2d=dZ > > > > zS+=Z3eZ0@>oa(0XG16FIR^RHzF`Ub+Qk(4_(#IZ^c1tb}N%Ic>QvgHu8=99G1I!zr > > > > zi1Y}@ICo@a`B48;n0CbW%pYR_Qsz)QLg*1$h@e3#Xfy{tO > > > zwne_$27Z>)_P6yQp|(tQjeWDNRo@o-eywM&%T#WQ%Pp2X;EeVak3TYLEEIMY_QUx9 > > > > zqvg9te~$lq0_I8W`>?x(r!pIM1KI23bq`$kK5w > > > > za^l+s*`HWUYwZ4^I_qL&rhs>CJukJ=9PD7(D%kV9tV_@8{7C6>+4dM`=gpQ+`X5sE > > > > l^kJ#ukL4Y57ixAa{T)yr9DB?*aBv?-_5Eu6ah%T`=HI~S@q7RP > > > > > > > > literal 0 > > > > HcmV?d00001 > > > > > > > > -- > > > > 2.17.1 > > > >