From: Ulf Hansson <ulf.hansson@linaro.org>
To: Veerabhadrarao Badiganti <vbadigan@codeaurora.org>
Cc: Adrian Hunter <adrian.hunter@intel.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>
Subject: Re: [PATCH V5 0/3] Internal voltage control for qcom SDHC
Date: Mon, 6 Jul 2020 16:49:14 +0200 [thread overview]
Message-ID: <CAPDyKFqG5iVda4A2swYx9-3nE__R+sSYKtJJyKAMwsQJ9z96gA@mail.gmail.com> (raw)
In-Reply-To: <1592919288-1020-1-git-send-email-vbadigan@codeaurora.org>
On Tue, 23 Jun 2020 at 15:35, Veerabhadrarao Badiganti
<vbadigan@codeaurora.org> wrote:
>
> On qcom SD host controllers voltage switching be done after the HW
> is ready for it. The HW informs its readiness through power irq.
> The voltage switching should happen only then.
>
> So added support to register voltage regulators from the msm driver
> and use them.
>
> This patchset was posted long back but not actively pursued
> https://lore.kernel.org/linux-arm-msm/1539004739-32060-1-git-send-email-vbadigan@codeaurora.org/
> So posting it as fresh patchset.
>
> Changes since V4:
> - Added clear comments on condtion which allows either to
> tunf off/on Vqmmc or to set load.
> - Added mmc_card_removable() to the condtion whcih checks
> if the card is eMMC or other card.
> - Rerturning error for unsupported voltagtes in
> sdhci_msm_start_signal_voltage_switch()
> - Moved setting ios.power_mode to mmc_alloc_host().
>
> Changes since V3:
> - Dropped reading of regulator load values from device tree.
> - Dropped documentaiton chagne.
> - Since only Vqmmc supply of eMMC would be kept On during suspend,
> setting load only for this regulator so that it can go to LPM.
> And since this Load reamins same, load value is hard-coded in the driver.
>
> Changes since V2:
> - Removed redundant log from sdhci_msm_set_vmmc.
> - Added the condition for skiping disabling of vqmmc for eMMC.
> - Updated logic such that, setting load for vqmmc only if
> it is kept ON.
> - Retained ack by Adrian for second patch.
> - Updated dt properties names as per Robs comments.
>
> Changes since V1:
> - Removed setting load for Vmmc regulator while turning it on/off.
> Instead setting the active load once during probe.
> - Simplified handlng of supplies for BUS_ON/OFF cases in shci_msm_handle_pwr_irq().
> - Moved common code out of switch case in sdhci_msm_start_signal_voltage_switch().
> - Updated variable name to sdhci_core_to_disable_vqmmc.
> - Updated pr_err logs to dev_err logs.
> Veerabhadrarao Badiganti (2):
> mmc: core: Set default power mode in mmc_alloc_host
> mmc: sdhci-msm: Use internal voltage control
>
> Vijay Viswanath (1):
> mmc: sdhci: Allow platform controlled voltage switching
>
> drivers/mmc/core/host.c | 1 +
> drivers/mmc/host/sdhci-msm.c | 206 +++++++++++++++++++++++++++++++++++++++++--
> drivers/mmc/host/sdhci.c | 32 ++++---
> drivers/mmc/host/sdhci.h | 1 +
> 4 files changed, 218 insertions(+), 22 deletions(-)
>
V5 applied for next (did some minor amendment to patch 2), thanks!
Kind regards
Uffe
prev parent reply other threads:[~2020-07-06 14:50 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 11:18 [PATCH V1 0/3] Internal voltage control for qcom SDHC Veerabhadrarao Badiganti
2020-05-15 11:18 ` [PATCH V1 1/3] dt-bindings: mmc: Supply max load for mmc supplies Veerabhadrarao Badiganti
2020-05-15 11:18 ` [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control Veerabhadrarao Badiganti
2020-05-18 19:57 ` Bjorn Andersson
2020-05-19 3:11 ` Bjorn Andersson
2020-05-20 11:16 ` Veerabhadrarao Badiganti
2020-05-21 18:21 ` Bjorn Andersson
2020-05-15 11:18 ` [PATCH V1 3/3] mmc: sdhci: Allow platform controlled voltage switching Veerabhadrarao Badiganti
2020-05-19 6:06 ` Adrian Hunter
2020-05-20 11:19 ` Veerabhadrarao Badiganti
2020-05-21 15:23 ` [PATCH V2 0/3] Internal voltage control for qcom SDHC Veerabhadrarao Badiganti
2020-05-21 15:23 ` [PATCH V2 1/3] dt-bindings: mmc: Supply max load for mmc supplies Veerabhadrarao Badiganti
2020-05-28 23:23 ` Rob Herring
2020-05-21 15:23 ` [PATCH V2 2/3] mmc: sdhci-msm: Use internal voltage control Veerabhadrarao Badiganti
2020-05-21 19:07 ` Bjorn Andersson
2020-05-22 13:27 ` Veerabhadrarao Badiganti
2020-05-22 17:04 ` Bjorn Andersson
2020-05-28 7:13 ` Veerabhadrarao Badiganti
2020-05-21 15:23 ` [PATCH V2 3/3] mmc: sdhci: Allow platform controlled voltage switching Veerabhadrarao Badiganti
2020-05-25 5:42 ` Adrian Hunter
2020-06-02 10:47 ` [PATCH V3 0/3] Internal voltage control for qcom SDHC Veerabhadrarao Badiganti
2020-06-02 10:47 ` [PATCH V3 1/3] dt-bindings: mmc: Supply max load for mmc supplies Veerabhadrarao Badiganti
2020-06-09 23:02 ` Rob Herring
2020-06-10 10:00 ` Mark Brown
2020-06-02 10:47 ` [PATCH V3 2/3] mmc: sdhci: Allow platform controlled voltage switching Veerabhadrarao Badiganti
2020-06-02 10:47 ` [PATCH V3 3/3] mmc: sdhci-msm: Use internal voltage control Veerabhadrarao Badiganti
2020-06-09 3:34 ` Veerabhadrarao Badiganti
2020-06-16 15:36 ` [PATCH V4 0/2] Internal voltage control for qcom SDHC Veerabhadrarao Badiganti
2020-06-16 15:36 ` [PATCH V4 1/2] mmc: sdhci: Allow platform controlled voltage switching Veerabhadrarao Badiganti
2020-06-16 15:36 ` [PATCH V4 2/2] mmc: sdhci-msm: Use internal voltage control Veerabhadrarao Badiganti
2020-06-17 9:34 ` Ulf Hansson
2020-06-17 12:45 ` Veerabhadrarao Badiganti
2020-06-17 14:16 ` Ulf Hansson
2020-06-18 6:30 ` Veerabhadrarao Badiganti
2020-06-23 13:34 ` [PATCH V5 0/3] Internal voltage control for qcom SDHC Veerabhadrarao Badiganti
2020-06-23 13:34 ` [PATCH V5 1/3] mmc: sdhci: Allow platform controlled voltage switching Veerabhadrarao Badiganti
2020-06-23 13:34 ` [PATCH V5 2/3] mmc: core: Set default power mode in mmc_alloc_host Veerabhadrarao Badiganti
2020-06-23 13:34 ` [PATCH V5 3/3] mmc: sdhci-msm: Use internal voltage control Veerabhadrarao Badiganti
2020-07-06 14:49 ` Ulf Hansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAPDyKFqG5iVda4A2swYx9-3nE__R+sSYKtJJyKAMwsQJ9z96gA@mail.gmail.com \
--to=ulf.hansson@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=vbadigan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).