From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 93DB5C43603 for ; Mon, 16 Dec 2019 12:09:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61917206CB for ; Mon, 16 Dec 2019 12:09:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f9FsYCC6" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727497AbfLPMJo (ORCPT ); Mon, 16 Dec 2019 07:09:44 -0500 Received: from mail-vs1-f67.google.com ([209.85.217.67]:38793 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727509AbfLPMJl (ORCPT ); Mon, 16 Dec 2019 07:09:41 -0500 Received: by mail-vs1-f67.google.com with SMTP id y195so3945738vsy.5 for ; Mon, 16 Dec 2019 04:09:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=R41bi6yGX1iFZADmCtGFAtslTM1p//RJUgDUHlg61M4=; b=f9FsYCC6hzMCeJ2TsROTECko+3MS0vbiOrA9N1RR5183cjmeTiP9e9Q7D3ysfb1CKi GP4eeMR4lOF5HpP4h7G1gGF6Tozadvflj2EwnEY07TrIQRRU7xQd5BUlWKbP1khStots TacxY60AnMM6HvZqiS4yy51nkGFlxH9T0CbirWXCaG2VU7yNUbXTRklnduKGN4so/r2Y IjMmpJnQ8FMC8pK0+J9qhQJSNIhPFC4RBARtyLEdZvVcdpFTgFYshG1BMv4UKTHK6Y1s 7gHFfy9afxxhsdqnoi6mOTAXdietwZ6YK1kq+oJQVeR8QtFs0V1N1RP6Uf9a8xNHA5kG unVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=R41bi6yGX1iFZADmCtGFAtslTM1p//RJUgDUHlg61M4=; b=XYTo531HZvAUcR3OupvfWo6wzOidfeW2e1veMQhO+lMJPH5ZPvRlue+xdFkXRG8C5j DFkWKi2czxIgoot8IVR+3rgrzTmo8N5yRWnFHfYubRHI6ofTNpsDLH6g7B5xGPvdzhfm GaHz0zh1ZyE60TP2Hsfrb60I5E3xfx9DRKVvY5w7iQa9zdkhKL0PFeAV76kfZf9x0I9B YoZHJbGlhh8byBNag5jHFS7gu4iWFBQguXLFTHIEszoajcyzZ2pp6CxxY/whgzciO0wT A2Xbem5attB0ERUPrgKVlKxccGcXhV8Juco9nVXfce+9fZZn7puJclex9uzZRVF/OJBL gA2A== X-Gm-Message-State: APjAAAW1U2RG/0Tpo3OsYMbnQERPyjYt5kILfyn+RMxmh5URYIgwKSM2 d6oElQPj1io9BBWL2H746O+Mzoa52eqC9qb2oVq9Tvdd X-Google-Smtp-Source: APXvYqyM+BFHKKpccM+ztT4sO4U92WldyDbTPLgrN1RbEanMHjp2bB6PAG89agGyNwpzRp5oUphcx23VDVg4tfX63sQ= X-Received: by 2002:a67:b649:: with SMTP id e9mr20077581vsm.34.1576498179745; Mon, 16 Dec 2019 04:09:39 -0800 (PST) MIME-Version: 1.0 References: <0101016ea738eb52-8c362755-205a-4383-9181-1a867e82eeed-000000@us-west-2.amazonses.com> <0101016ef47b4d25-49791932-586b-456e-b9a7-6f9a6f95babf-000000@us-west-2.amazonses.com> In-Reply-To: <0101016ef47b4d25-49791932-586b-456e-b9a7-6f9a6f95babf-000000@us-west-2.amazonses.com> From: Ulf Hansson Date: Mon, 16 Dec 2019 13:09:03 +0100 Message-ID: Subject: Re: [PATCH] mmc: sdhci-msm: Correct the offset and value for DDR_CONFIG register To: Veerabhadrarao Badiganti Cc: Adrian Hunter , Asutosh Das , Sahitya Tummala , Sayali Lokhande , cang@codeaurora.org, Ram Prakash Gupta , "linux-mmc@vger.kernel.org" , Linux Kernel Mailing List , linux-arm-msm Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, 11 Dec 2019 at 11:22, Veerabhadrarao Badiganti wrote: > > > On 12/10/2019 3:21 PM, Ulf Hansson wrote: > > On Tue, 26 Nov 2019 at 11:19, Veerabhadrarao Badiganti > > wrote: > >> The DDR_CONFIG register offset got updated after a specific > >> minor version of sdcc V4. This offset change has not been properly > >> taken care of while updating register changes for sdcc V5. > >> > >> Correcting proper offset for this register. > >> Also updating this register value to reflect the recommended RCLK > >> delay. > >> > >> Signed-off-by: Veerabhadrarao Badiganti > > I have applied this for fixes, however it seems like this should also > > be tagged for stable, right? > > Thank you. Yes, I agree. > > > > > Is there a specific commit this fixes or should we just find the > > version it applies to? > > It fixes the bug introduced by commit: > > f153588 (mmc: sdhci-msm: Define new Register address map) Great, thanks added a fixes/stable tag. [...] Kind regards Uffe