From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92613C433E0 for ; Thu, 14 May 2020 03:35:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81B11206E5 for ; Thu, 14 May 2020 03:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="q2pixGRP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725946AbgENDff (ORCPT ); Wed, 13 May 2020 23:35:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725925AbgENDff (ORCPT ); Wed, 13 May 2020 23:35:35 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1BA32C061A0C; Wed, 13 May 2020 20:35:35 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id nv1so1567350ejb.0; Wed, 13 May 2020 20:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8teGw0WwonEFe9dYSN2XrrELypvJtmQCmIWOM6OlgCs=; b=q2pixGRPVyJgRQEOZ/eD+S7cvoG3pUvNGOpDpUS4G2DvW5y/nGjVA21yWWzP7yD36v nsFCJLS4B+skn00jn4IURMxCNAzcY6l/2l7yQvgQgxZmjwyPIHHm5lwCGmI6D7opntcZ 94F8qz8+SgVS07l1vJ0ZTX1iQQKm9qR//Gr0Ghb8w2aw0x6hqcVXmuMqbdZk3oUMN0ll bFMHo0V6/052FEDRrfU7Z535J8RhBXSffrY7OjJHumHpwXSBbdLt9mKtVG26A61bZ1gf 8q+JZJmniw07ZwAxhQQtB5545/p86UePnwLMlDqwNYutBQHo3OKxV5OUuA0VB+MGiz3O /QyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8teGw0WwonEFe9dYSN2XrrELypvJtmQCmIWOM6OlgCs=; b=YkR/wrmVdVGQsrF99mmvVJsseVFDEIiK08h7ca+r5gOWjYh9VKIhwxo7bBVHS183SD Nz0Tr2a+CSLHjAFqMke+97zBF1/s0drFCRr3oR8TaAhbuw8cKSo/+dowf5LBKOj6EeVB 2KhMQIqecJCEvxQCTZ/QzCgqmWFk/VnPHFMME1x9WpnqUg64byXKpxLt1D4vWnoN1lHW 7VmYnJN2IWkQEtCxLPQ0jx8QOyd483BOBofGnEwMxhM+GtIYxtdKaDspue7Pt9Q092lL kez1ah9zlegMI/vErRgZGXQ0kga/xKy3RcoGUIerLEu4/SdN6nbrMvutNlZzoeuywCGe +rVw== X-Gm-Message-State: AOAM530WQNW8lHHJOeeQILSGVM/HnAnWrycwug9cimBMF4QUasdIFV53 yBUGZuOr10+DouTm8EjsIWSLumbQz54dGVQR6cIeRPERafk= X-Google-Smtp-Source: ABdhPJyyZktdYPNGhB3y07CL4rBTGEssk0DDQxtEufoq6hF6/YtOUNOWoGiNzGtBDvdpyzqa5RwbcFsp/Xl7LK1FS68= X-Received: by 2002:a17:906:1e51:: with SMTP id i17mr2009290ejj.336.1589427333496; Wed, 13 May 2020 20:35:33 -0700 (PDT) MIME-Version: 1.0 References: <20200421045508.21137-1-harigovi@codeaurora.org> <20200421045508.21137-2-harigovi@codeaurora.org> <20200506185703.GB8227@ravnborg.org> In-Reply-To: <20200506185703.GB8227@ravnborg.org> From: Dave Airlie Date: Thu, 14 May 2020 13:35:22 +1000 Message-ID: Subject: Re: [PATCH v11 1/2] drm/panel: add support for rm69299 visionox panel driver To: Sam Ravnborg Cc: Harigovindan P , freedreno , devicetree@vger.kernel.org, linux-arm-msm , dri-devel , Matthias Kaehlcke , Sean Paul , Sean Paul Content-Type: text/plain; charset="UTF-8" Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, 7 May 2020 at 04:57, Sam Ravnborg wrote: > > Hi Harigovindan > > On Wed, Apr 29, 2020 at 11:15:14AM +0530, Harigovindan P wrote: > > Add support for Visionox panel driver. > > > > Signed-off-by: Harigovindan P > > Reviewed-by: Matthias Kaehlcke > > Thanks for your persistence on this. > Patch applied. > > I fixed a few lingering --strict releated checkpatch warnings > when I applied. > > Sam I'm seeing WARNING: modpost: missing MODULE_LICENSE() in drivers/gpu/drm/panel/panel-visionox-rm69299.o Can we fix that up? Dave. > > > --- > > > > Changes in v2: > > - Dropping redundant space in Kconfig(Sam Ravnborg). > > - Changing structure for include files(Sam Ravnborg). > > - Removing backlight related code and functions(Sam Ravnborg). > > - Removing repeated printing of error message(Sam Ravnborg). > > - Adding drm_connector as an argument for get_modes function. > > Changes in v3: > > - Adding arguments for drm_panel_init to support against mainline. > > Changes in v4: > > - Removing error messages from regulator_set_load. > > - Removing dev struct entry. > > - Removing checks. > > - Dropping empty comment lines. > > Changes in v5: > > - Removing unused struct member variables. > > - Removing blank lines. > > - Fixed indentation. > > - Invoking dsi_detach and panel_remove while early exiting from probe. > > Changes in v6: > > - Changed "35597" to "rm69299" for power_on function. > > - Removing rm69299_config since it supports single type of panel for now. > > - Fixed alignment. > > - Using goto statements when regulator_set_load fails. > > Changes in v7: > > - Added new goto statement when regulator_set_load fails. > > Changes in v8,v9,v10: > > - Had changes in first patch, did not make any change in panel driver. > > Changes in v11: > > - Fixing checkpatch script errors. > > - Updated assignment of panel.dev property in probe. > > > > drivers/gpu/drm/panel/Kconfig | 8 + > > drivers/gpu/drm/panel/Makefile | 1 + > > .../gpu/drm/panel/panel-visionox-rm69299.c | 304 ++++++++++++++++++ > > 3 files changed, 313 insertions(+) > > create mode 100644 drivers/gpu/drm/panel/panel-visionox-rm69299.c > > > > diff --git a/drivers/gpu/drm/panel/Kconfig b/drivers/gpu/drm/panel/Kconfig > > index d56258b9fcaf..4b6131f5893d 100644 > > --- a/drivers/gpu/drm/panel/Kconfig > > +++ b/drivers/gpu/drm/panel/Kconfig > > @@ -444,6 +444,14 @@ config DRM_PANEL_TRULY_NT35597_WQXGA > > Say Y here if you want to enable support for Truly NT35597 WQXGA Dual DSI > > Video Mode panel > > > > +config DRM_PANEL_VISIONOX_RM69299 > > + tristate "Visionox RM69299" > > + depends on OF > > + depends on DRM_MIPI_DSI > > + help > > + Say Y here if you want to enable support for Visionox > > + RM69299 DSI Video Mode panel. > > + > > config DRM_PANEL_XINPENG_XPP055C272 > > tristate "Xinpeng XPP055C272 panel driver" > > depends on OF > > diff --git a/drivers/gpu/drm/panel/Makefile b/drivers/gpu/drm/panel/Makefile > > index 2335a1e32ae0..8eac3e6fa82c 100644 > > --- a/drivers/gpu/drm/panel/Makefile > > +++ b/drivers/gpu/drm/panel/Makefile > > @@ -47,4 +47,5 @@ obj-$(CONFIG_DRM_PANEL_TPO_TD028TTEC1) += panel-tpo-td028ttec1.o > > obj-$(CONFIG_DRM_PANEL_TPO_TD043MTEA1) += panel-tpo-td043mtea1.o > > obj-$(CONFIG_DRM_PANEL_TPO_TPG110) += panel-tpo-tpg110.o > > obj-$(CONFIG_DRM_PANEL_TRULY_NT35597_WQXGA) += panel-truly-nt35597.o > > +obj-$(CONFIG_DRM_PANEL_VISIONOX_RM69299) += panel-visionox-rm69299.o > > obj-$(CONFIG_DRM_PANEL_XINPENG_XPP055C272) += panel-xinpeng-xpp055c272.o > > diff --git a/drivers/gpu/drm/panel/panel-visionox-rm69299.c b/drivers/gpu/drm/panel/panel-visionox-rm69299.c > > new file mode 100644 > > index 000000000000..3ef4cc80044a > > --- /dev/null > > +++ b/drivers/gpu/drm/panel/panel-visionox-rm69299.c > > @@ -0,0 +1,304 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > > + * Copyright (c) 2019, The Linux Foundation. All rights reserved. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > + > > +#include