From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Anjelique Melendez" <quic_amelende@quicinc.com>, <pavel@ucw.cz>,
<lee@kernel.org>, <thierry.reding@gmail.com>,
<robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<conor+dt@kernel.org>, <agross@kernel.org>,
<andersson@kernel.org>
Cc: <konrad.dybcio@linaro.org>, <u.kleine-koenig@pengutronix.de>,
<quic_subbaram@quicinc.com>, <quic_gurus@quicinc.com>,
<linux-leds@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
<linux-pwm@vger.kernel.org>, <kernel@quicinc.com>
Subject: Re: [PATCH v5 0/7] Add support for LUT PPG
Date: Sun, 01 Oct 2023 16:15:50 +0200 [thread overview]
Message-ID: <CVX5ZUGU9BVE.2TA819U1AI6BZ@otso> (raw)
In-Reply-To: <20230929003901.15086-1-quic_amelende@quicinc.com>
On Fri Sep 29, 2023 at 2:38 AM CEST, Anjelique Melendez wrote:
> In certain PMICs, LUT pattern and LPG configuration is stored in SDAM
> modules instead of LUT peripheral. This feature is called PPG.
>
> This change series adds support for PPG. Thanks!
>
> Changes since v4:
> - Patch 3/7
> - Get rid of r/w helpers
> - Use regmap_read_poll_timeout() in qcom_pbs_wait_for_ack()
> - Update error path in qcom_pbs_trigger_event()
> - Fix reverse christmas tree
> - Patch 4/7
> - Get rid of r/w helpers
> - Update variables to use "sdam" instead of "nvmem"
> - Fix comments
> - Fix reverse christmas tree
> - Update lpg_pattern_set() logic
> - Patch 5/7
> - Removed sdam_lut_base from lpg_data
> Changes since v3:
> - Patch 4/7
> - Fix function returns
> - Move register definition to top of file
> - Revert max_brightness and probe accidental changes
> - Combine init_sdam() and parse_sdam()
> - Change error prints in probe to use dev_err_probe
> - Remove ppg_en variable
> - Update when pbs triggers are set/cleared
> - Patch 6/7
> - Remove use of nvmem_count
> - Move register definition to top of file
> - Remove lpg_get_sdam_lut_idx()
> Changes since v2:
> - Patch 1/7
> - Fix dt_binding_check error
> - Rename binding file to match compatible
> - Iclude SoC specific comptaibles
> - Patch 2/7
> - Update nvmem-names list
> - Patch 3/7
> - Update EXPORT_SYMBOL to EXPORT_SYMBOL_GPL
> - Fix return/break logic in qcom_pbs_wait_for_ack()
> - Update iterators to be int
> - Add constants
> - Fix function calls in qcom_pbs_trigger_event()
> - Remove unnessary comments
> - Return -EPROBE_DEFER from get_pbs_client_device()
> Changes since v1:
> - Patch 1/7
> - Fix dt_binding_check errors
> - Update binding description
> - Path 2/7
> - Fix dt_binding_check errors
> - Update per variant constraints
> - Update nvmem description
> - Patch 3/7
> - Update get_pbs_client_device()
> - Drop use of printk
> - Remove unused function
>
> Tested-by: Luca Weiss <luca.weiss@fairphone.com> # sdm632-fairphone-fp3 (pmi632)
Hi Anjelique,
Actually I've retested this now on PMI632 (and also realized that my
previous tests weren't correct and wasn't actually using hw_pattern).
Using the following commands (after boot) I'm expecting to get a
500ms on 500ms off blinking pattern between white (255 255 255) and off
(0 0 0).
echo pattern > /sys/class/leds/rgb:status/trigger
echo -1 > /sys/class/leds/rgb:status/repeat
echo "255 255 255" > /sys/class/leds/rgb:status/multi_intensity
echo "255 500 255 0 0 500 0 0" > /sys/class/leds/rgb:status/hw_pattern
What I actually see is it blinking between cyan (0 255 255) and red (255
0 0).
At some point after playing with many patterns I got it to actually
cycle between white and off, but I couldn't reproduce this again (or I
didn't try hard enough).
But with this example it correctly blinks red on-off.
echo "255 0 0" > /sys/class/leds/rgb:status/multi_intensity
echo "255 500 255 0 0 500 0 0" > /sys/class/leds/rgb:status/hw_pattern
With "0 255 0" and "0 0 255" the other colors also work fine, it's just
the combinations that seem somewhat broken.
Regards
Luca
>
> Anjelique Melendez (7):
> dt-bindings: soc: qcom: Add qcom,pbs bindings
> dt-bindings: leds: leds-qcom-lpg: Add support for LPG PPG
> soc: qcom: add QCOM PBS driver
> leds: rgb: leds-qcom-lpg: Add support for single SDAM PPG
> leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG
> leds: rgb: leds-qcom-lpg: Include support for PPG with dedicated LUT
> SDAM
> leds: rgb: Update PM8350C lpg_data to support two-nvmem PPG Scheme
>
> .../bindings/leds/leds-qcom-lpg.yaml | 89 ++++-
> .../bindings/soc/qcom/qcom,pbs.yaml | 46 +++
> drivers/leds/rgb/leds-qcom-lpg.c | 359 ++++++++++++++++--
> drivers/soc/qcom/Kconfig | 9 +
> drivers/soc/qcom/Makefile | 1 +
> drivers/soc/qcom/qcom-pbs.c | 243 ++++++++++++
> include/linux/soc/qcom/qcom-pbs.h | 30 ++
> 7 files changed, 749 insertions(+), 28 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/soc/qcom/qcom,pbs.yaml
> create mode 100644 drivers/soc/qcom/qcom-pbs.c
> create mode 100644 include/linux/soc/qcom/qcom-pbs.h
next prev parent reply other threads:[~2023-10-01 14:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-29 0:38 [PATCH v5 0/7] Add support for LUT PPG Anjelique Melendez
2023-09-29 0:38 ` [PATCH v5 1/7] dt-bindings: soc: qcom: Add qcom,pbs bindings Anjelique Melendez
2023-09-29 0:38 ` [PATCH v5 2/7] dt-bindings: leds: leds-qcom-lpg: Add support for LPG PPG Anjelique Melendez
2023-09-29 0:38 ` [PATCH v5 3/7] soc: qcom: add QCOM PBS driver Anjelique Melendez
2023-09-29 0:38 ` [PATCH v5 4/7] leds: rgb: leds-qcom-lpg: Add support for single SDAM PPG Anjelique Melendez
2023-10-05 13:37 ` Lee Jones
2023-09-29 0:38 ` [PATCH v5 5/7] leds: rgb: leds-qcom-lpg: Update PMI632 lpg_data to support PPG Anjelique Melendez
2023-10-05 13:38 ` Lee Jones
2023-09-29 0:38 ` [PATCH v5 6/7] leds: rgb: leds-qcom-lpg: Include support for PPG with dedicated LUT SDAM Anjelique Melendez
2023-10-05 13:44 ` Lee Jones
2023-09-29 0:39 ` [PATCH v5 7/7] leds: rgb: Update PM8350C lpg_data to support two-nvmem PPG Scheme Anjelique Melendez
2023-10-05 13:45 ` Lee Jones
2023-10-01 14:15 ` Luca Weiss [this message]
2023-10-12 21:50 ` [PATCH v5 0/7] Add support for LUT PPG Anjelique Melendez
2023-10-13 6:35 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CVX5ZUGU9BVE.2TA819U1AI6BZ@otso \
--to=luca.weiss@fairphone.com \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lee@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=quic_amelende@quicinc.com \
--cc=quic_gurus@quicinc.com \
--cc=quic_subbaram@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).