From: Avri Altman <Avri.Altman@wdc.com>
To: Avri Altman <Avri.Altman@wdc.com>,
Asutosh Das <asutoshd@codeaurora.org>,
"cang@codeaurora.org" <cang@codeaurora.org>,
"martin.petersen@oracle.com" <martin.petersen@oracle.com>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Cc: "linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>
Subject: RE: [RFC PATCH v3 0/1] Enable power management for ufs wlun
Date: Sun, 14 Feb 2021 07:48:10 +0000 [thread overview]
Message-ID: <DM6PR04MB65758D026C49C4DE9606CCD2FC899@DM6PR04MB6575.namprd04.prod.outlook.com> (raw)
In-Reply-To: <DM6PR04MB6575172ABC466BA0824743D5FC8A9@DM6PR04MB6575.namprd04.prod.outlook.com>
> >
> > This patch attempts to fix a deadlock in ufs while sending SSU.
> > Recently, blk_queue_enter() added a check to not process requests if the
> > queue is suspended. That leads to a resume of the associated device which
> > is suspended. In ufs, that device is ufs device wlun and it's parent is
> > ufs_hba. This resume tries to resume ufs device wlun which in turn tries
> > to resume ufs_hba, which is already in the process of suspending, thus
> > causing a deadlock.
> >
> > This patch takes care of:
> > * Suspending the ufs device lun only after all other luns are suspended
> ufs device lun -> ufs device wlun
You might also want to consider, as a preliminary step in your series,
reverting one or more of the recent "clear uac" patches,
As you are nailing the root cause of the issues/live-lock they witnessed.
Thanks,
Avri
prev parent reply other threads:[~2021-02-14 7:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-11 19:18 [RFC PATCH v3 0/1] Enable power management for ufs wlun Asutosh Das
2021-02-11 19:18 ` [RFC PATCH v3 1/1] scsi: ufs: Enable power management for wlun Asutosh Das
2021-02-13 3:25 ` Bart Van Assche
2021-02-16 17:38 ` Asutosh Das
2021-02-13 21:37 ` Avri Altman
2021-02-16 17:36 ` Asutosh Das
2021-02-17 22:29 ` Asutosh Das
2021-02-19 8:35 ` Adrian Hunter
2021-02-19 18:18 ` Asutosh Das
2021-02-13 20:51 ` [RFC PATCH v3 0/1] Enable power management for ufs wlun Avri Altman
2021-02-14 7:48 ` Avri Altman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR04MB65758D026C49C4DE9606CCD2FC899@DM6PR04MB6575.namprd04.prod.outlook.com \
--to=avri.altman@wdc.com \
--cc=asutoshd@codeaurora.org \
--cc=cang@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).