From: Martin Botka <martin.botka@somainline.org>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
Konrad Dybcio <konrad.dybcio@somainline.org>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@somainline.org>,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
MSM <linux-arm-msm@vger.kernel.org>,
GPIO SUBSYSTEM <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH V3 1/2] dt-bindings: pinctrl: qcom: sm6125: Document SM6125 pinctrl driver
Date: Thu, 27 May 2021 19:30:16 +0200 [thread overview]
Message-ID: <GM0STQ.7UKZA16NEMPI1@somainline.org> (raw)
In-Reply-To: <CACRpkdbPvxN2-VTm+n-j6JiWZnraCviZ2JDFe=A7Z=z93-seVQ@mail.gmail.com>
Hello,
I did run the checks but i have forgoten to do a make clean before
hand. Thats probably why i didnt get that before.
Will send V4 as soon as i can :)
Best regards,
Martin Botka
On Thu, May 27 2021 at 05:05:32 PM +0200, Linus Walleij
<linus.walleij@linaro.org> wrote:
> Hi Martin,
>
> overall this looks good but the bot warned because of this:
>
> On Mon, May 24, 2021 at 9:30 PM Martin Botka
> <martin.botka@somainline.org> wrote:
>>
>> Document the newly added SM6125 pinctrl driver
>>
>> Signed-off-by: Martin Botka <martin.botka@somainline.org>
> (...)
>> +properties:
>> + compatible:
>> + const: qcom,sm6125-tlmm
> (...)
>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>> + pinctrl@500000 {
>> + compatible = "qcom,sm6125-pinctrl";
>
> So it seems like you didn't run the checks?
>
> Yours,
> Linus Walleij
prev parent reply other threads:[~2021-05-27 17:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 19:30 [PATCH V3 1/2] dt-bindings: pinctrl: qcom: sm6125: Document SM6125 pinctrl driver Martin Botka
2021-05-24 19:30 ` [PATCH V3 2/2] drivers: qcom: pinctrl: Add pinctrl driver for sm6125 Martin Botka
2021-05-25 16:58 ` [PATCH V3 1/2] dt-bindings: pinctrl: qcom: sm6125: Document SM6125 pinctrl driver Rob Herring
2021-05-27 15:05 ` Linus Walleij
2021-05-27 17:30 ` Martin Botka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=GM0STQ.7UKZA16NEMPI1@somainline.org \
--to=martin.botka@somainline.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=jamipkettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).