From: Martin Botka <martin.botka@somainline.org>
To: Jassi Brar <jassisinghbrar@gmail.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
konrad.dybcio@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
linux-arm-msm@vger.kernel.org,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH V3 3/3] mailbox: qcom-apcs: Add SM6125 compatible
Date: Mon, 21 Jun 2021 19:02:49 +0200 [thread overview]
Message-ID: <P0A2VQ.Z2SRD0005J6R3@somainline.org> (raw)
In-Reply-To: <CABb+yY3BYYC2na8EFunEeu0XCfLXrUQon=hF3q5p=+FUoigoyw@mail.gmail.com>
On Sun, Jun 20 2021 at 11:03:04 PM -0500, Jassi Brar
<jassisinghbrar@gmail.com> wrote:
> On Sat, Jun 12, 2021 at 4:46 AM Martin Botka
> <martin.botka@somainline.org> wrote:
>>
>> This commit adds compatible for the SM6125 SoC
>>
>> Signed-off-by: Martin Botka <martin.botka@somainline.org>
>> ---
>> Changes in V2:
>> None
>> Changes in V3:
>> Change compatible to apcs-hmss-global
>> drivers/mailbox/qcom-apcs-ipc-mailbox.c | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> index f25324d03842..f24c5ad8d658 100644
>> --- a/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> +++ b/drivers/mailbox/qcom-apcs-ipc-mailbox.c
>> @@ -57,6 +57,10 @@ static const struct qcom_apcs_ipc_data
>> sdm660_apcs_data = {
>> .offset = 8, .clk_name = NULL
>> };
>>
>> +static const struct qcom_apcs_ipc_data sm6125_apcs_data = {
>> + .offset = 8, .clk_name = NULL
>> +};
>> +
>> static const struct qcom_apcs_ipc_data apps_shared_apcs_data = {
>> .offset = 12, .clk_name = NULL
>> };
>> @@ -166,6 +170,7 @@ static const struct of_device_id
>> qcom_apcs_ipc_of_match[] = {
>> { .compatible = "qcom,sc8180x-apss-shared", .data =
>> &apps_shared_apcs_data },
>> { .compatible = "qcom,sdm660-apcs-hmss-global", .data =
>> &sdm660_apcs_data },
>> { .compatible = "qcom,sdm845-apss-shared", .data =
>> &apps_shared_apcs_data },
>> + { .compatible = "qcom,sm6125-apcs-hmss-global", .data =
>> &sm6125_apcs_data },
>> { .compatible = "qcom,sm8150-apss-shared", .data =
>> &apps_shared_apcs_data },
>> { .compatible = "qcom,sdx55-apcs-gcc", .data =
>> &sdx55_apcs_data },
>> {}
>>
> These all are basically different names for the same controller.
> The 'offset' is a configuration parameter and the 'clock', when NULL,
> is basically some "always-on" clock.
> I am sure we wouldn't be doing it, if the controller was third-party.
>
> -Jassi
I'm aware that its not great to duplicate but i just followed
how it was done previously.
I will probably send a patch to lump the common conf together.
Best Regards,
Martin
next prev parent reply other threads:[~2021-06-21 17:07 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 9:46 [PATCH V3 1/3] socinfo: Add missing SoC ID for SM6125 Martin Botka
2021-06-12 9:46 ` [PATCH V3 2/3] dt-bindings: mailbox: Add binding for sm6125 Martin Botka
2021-06-24 19:26 ` Rob Herring
2021-06-12 9:46 ` [PATCH V3 3/3] mailbox: qcom-apcs: Add SM6125 compatible Martin Botka
2021-06-21 4:03 ` Jassi Brar
2021-06-21 17:02 ` Martin Botka [this message]
2021-06-21 19:46 ` Rob Herring
2021-06-21 23:10 ` Jassi Brar
2021-06-21 23:19 ` Rob Herring
2021-06-21 23:35 ` Bjorn Andersson
2021-06-22 1:00 ` Jassi Brar
2021-06-22 2:27 ` Bjorn Andersson
2021-06-22 3:34 ` Jassi Brar
2021-06-22 3:52 ` Bjorn Andersson
2021-06-22 14:36 ` AngeloGioacchino Del Regno
2021-06-22 14:43 ` Jassi Brar
2021-06-24 21:07 ` Bjorn Andersson
2021-06-24 22:59 ` AngeloGioacchino Del Regno
2021-06-25 0:02 ` Bjorn Andersson
2021-06-26 16:50 ` Jassi Brar
2021-06-22 14:37 ` Jassi Brar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=P0A2VQ.Z2SRD0005J6R3@somainline.org \
--to=martin.botka@somainline.org \
--cc=agross@kernel.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=jamipkettunen@somainline.org \
--cc=jassisinghbrar@gmail.com \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).